990332">

Debian Bug report logs - #990332
libcddb: reproducible-builds: Example Makefile embeds build paths and binary paths

version graph

Package: src:libcddb; Maintainer for src:libcddb is Nick Gasson <nick@nickg.me.uk>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Fri, 25 Jun 2021 21:09:01 UTC

Severity: normal

Tags: patch

Fixed in version 1.3.2-7

Done: Nick Gasson <nick@nickg.me.uk>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Eugene V. Lyubimkin <jackyf@debian.org>:
Bug#990332; Package src:libcddb. (Fri, 25 Jun 2021 21:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Eugene V. Lyubimkin <jackyf@debian.org>. (Fri, 25 Jun 2021 21:09:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: libcddb: reproducible-builds: Example Makefile embeds build paths and binary paths
Date: Fri, 25 Jun 2021 14:06:59 -0700
[Message part 1 (text/plain, inline)]
Source: libcddb
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path, several binary paths, and the value of the SHELL
variable are embedded in example Makefiles shipped in the package:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libcddb.html

  ./usr/share/doc/libcddb2-dev/examples/Makefile.gz

  ACLOCAL·=·${SHELL}·'/build/1st/libcddb-1.3.2/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/libcddb-1.3.2/2nd/missing'·aclocal-1.16

  GREP·=·/bin/grep
  vs.
  GREP·=·/usr/bin/grep

  SHELL·=·/bin/bash
  vs.
  SHELL·=·/bin/sh

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.

The attached patch adjusts debian/libcddb2-dev.examples to only install
Makefile.in and Makefile.am.


If that is somehow not an option, an alternate option would be to
sanitize the Makefiles stripping the build path (or replacing with
/usr/src?), and possibly passing various variables to configure
(e.g. GREP=/bin/grep, SHELL=/bin/sh, ...).


Thanks for maintaining libcddb!


live well,
  vagrant
[0001-Do-not-install-example-Makefile.patch (text/x-diff, inline)]
From e658bcb574a9cfc68f422c56671e1a13aad806fe Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 25 Jun 2021 20:57:00 +0000
Subject: [PATCH] Do not install example Makefile.

The build path, several binary paths, and the value of the SHELL
variable are embedded in a Makefile shipped in the package.

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are included in the package.
---
 debian/libcddb2-dev.examples | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/libcddb2-dev.examples b/debian/libcddb2-dev.examples
index bdd6e0e..3a5ea45 100644
--- a/debian/libcddb2-dev.examples
+++ b/debian/libcddb2-dev.examples
@@ -1,3 +1,3 @@
 examples/*.c
 examples/*.h
-examples/Makefil*
+examples/Makefile.*
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Reply sent to Nick Gasson <nick@nickg.me.uk>:
You have taken responsibility. (Sun, 19 Sep 2021 15:03:05 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sun, 19 Sep 2021 15:03:05 GMT) (full text, mbox, link).


Message #10 received at 990332-done@bugs.debian.org (full text, mbox, reply):

From: Nick Gasson <nick@nickg.me.uk>
To: 990332-done@bugs.debian.org
Cc: Vagrant Cascadian <vagrant@reproducible-builds.org>
Subject: Re: libcddb: reproducible-builds: Example Makefile embeds build paths and binary paths
Date: Sun, 19 Sep 2021 22:37:13 +0800
Version: 1.3.2-7

On 26/06/21 05:06 am, Vagrant Cascadian wrote:
>
> The build path, several binary paths, and the value of the SHELL
> variable are embedded in example Makefiles shipped in the package:
>
> Since these values may differ with the installed system, in order to use
> the example Makefiles, a person would have to regenerate them from
> Makefile.am or Makefile.in, which are also provided.
>
> The attached patch adjusts debian/libcddb2-dev.examples to only install
> Makefile.in and Makefile.am.
>

I applied a similar patch to this when I adopted the package recently
but I missed this bug report, sorry.  Anyway I believe it's building
reproducibly now.

--
Thanks,
Nick



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 18 Oct 2021 07:27:04 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 01:35:25 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.