990084">

Debian Bug report logs - #990084
graphicsmagick: reproducible builds: Embeds different paths on usrmerge system

version graph

Package: src:graphicsmagick; Maintainer for src:graphicsmagick is Laszlo Boszormenyi (GCS) <gcs@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Sun, 20 Jun 2021 01:57:02 UTC

Severity: normal

Tags: patch

Fixed in version graphicsmagick/1.4+really1.3.37-1

Done: Laszlo Boszormenyi (GCS) <gcs@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Laszlo Boszormenyi (GCS) <gcs@debian.org>:
Bug#990084; Package src:graphicsmagick. (Sun, 20 Jun 2021 01:57:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Laszlo Boszormenyi (GCS) <gcs@debian.org>. (Sun, 20 Jun 2021 01:57:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, different on usrmerge systems: > > https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/graphicsmagick.html > > ./usr/lib/GraphicsMagick-1.4/config/delegates.mgk > > > vs. > > > The attached patch fixes this in debian/rules by passing arguments to > configure to use the paths in the non-usrmerge paths, as usrmerge > systems typically have compatibility symlinks, while non-usrmerge > systems do not. > > > This patch does not resolve all reproducibility issues, though the only > remaining issue is build paths, which is not tested in the "testing" > suite, so applying this patch should result in reproducible builds once > it migrates to "testing". > > > Thanks for maintaining graphicsmagick! > > > live well, > vagrant &In-Reply-To=<87sg1dl2tg.fsf@yucca>">reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: graphicsmagick: reproducible builds: Embeds different paths on usrmerge system
Date: Sat, 19 Jun 2021 18:52:59 -0700
[Message part 1 (text/plain, inline)]
Source: graphicsmagick
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The delegates.mgk file embeds the full path to the "mv" binary, which is
different on usrmerge systems:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/graphicsmagick.html

  ./usr/lib/GraphicsMagick-1.4/config/delegates.mgk

  <delegate·decode="hpg"·command='"hp2xx"·-q·-m·eps·-f·`basename·"%o"`·"%i"·&&·/bin/mv·-f·`basename·"%o"`·"%o"'·/>
  vs.
  <delegate·decode="hpg"·command='"hp2xx"·-q·-m·eps·-f·`basename·"%o"`·"%i"·&&·/usr/bin/mv·-f·`basename·"%o"`·"%o"'·/>

The attached patch fixes this in debian/rules by passing arguments to
configure to use the paths in the non-usrmerge paths, as usrmerge
systems typically have compatibility symlinks, while non-usrmerge
systems do not.


This patch does not resolve all reproducibility issues, though the only
remaining issue is build paths, which is not tested in the "testing"
suite, so applying this patch should result in reproducible builds once
it migrates to "testing".


Thanks for maintaining graphicsmagick!


live well,
  vagrant
[0001-debian-rules-Pass-MVDelegate-to-configure.patch (text/x-diff, inline)]
From d5054356232c666ba611742a55de9d6660740143 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 20 Jun 2021 01:39:52 +0000
Subject: [PATCH] debian/rules: Pass MVDelegate to configure.

The path to "mv" may end up in binaries or documentation, which may be
/bin/mv or /usr/bin/mv depending on if the running system is a
usrmerge system or not. Consistently use /bin/mv as this is the most
compatible path.

https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 46fcb72..4c48093 100755
--- a/debian/rules
+++ b/debian/rules
@@ -52,6 +52,7 @@ configure-stamp:
 	dh_testdir
 	dh_autoreconf
 	CFLAGS="$(CFLAGS)" CXXFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" \
+	MVDelegate=/bin/mv \
 	    ./configure $(gm_confflags) \
 		--enable-shared \
 		--enable-static \
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Reply sent to Laszlo Boszormenyi (GCS) <gcs@debian.org>:
You have taken responsibility. (Mon, 13 Dec 2021 18:24:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Mon, 13 Dec 2021 18:24:03 GMT) (full text, mbox, link).


Message #10 received at 990084-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 990084-close@bugs.debian.org
Subject: Bug#990084: fixed in graphicsmagick 1.4+really1.3.37-1
Date: Mon, 13 Dec 2021 18:20:43 +0000
Source: graphicsmagick
Source-Version: 1.4+really1.3.37-1
Done: Laszlo Boszormenyi (GCS) <gcs@debian.org>

We believe that the bug you reported is fixed in the latest version of
graphicsmagick, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 990084@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <gcs@debian.org> (supplier of updated graphicsmagick package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 13 Dec 2021 17:50:54 +0100
Source: graphicsmagick
Architecture: source
Version: 1.4+really1.3.37-1
Distribution: unstable
Urgency: high
Maintainer: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Changed-By: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Closes: 990084
Changes:
 graphicsmagick (1.4+really1.3.37-1) unstable; urgency=high
 .
   * New upstream release, including many security fixes.
   * Update library symbols for this release.
 .
   [ Vagrant Cascadian <vagrant@reproducible-builds.org> ]
   * Pass MVDelegate to configure for fixing reproducible builds on usrmerge
     systems (closes: #990084).
Checksums-Sha1:
 30675340f1301b3c5b931f5f6db4cf1aa15a71f7 2860 graphicsmagick_1.4+really1.3.37-1.dsc
 94e0103f7d2286d1ba46c633d68ab0e1bfa2b2d3 5623688 graphicsmagick_1.4+really1.3.37.orig.tar.xz
 d9b21709eefd2e074e7d82b0a6b167f0632b6c6d 148476 graphicsmagick_1.4+really1.3.37-1.debian.tar.xz
Checksums-Sha256:
 a779c060e55cd0e02f9bbc42a8193fc1ab7e8f7d8713ba6e771983d6d26df4cd 2860 graphicsmagick_1.4+really1.3.37-1.dsc
 90dc22f1a7bd240e4c9065a940962bf13da43c99bcc36cb111cc3c1a0d7477d4 5623688 graphicsmagick_1.4+really1.3.37.orig.tar.xz
 c154c4d32217054d3fdbbffb2d87870e111e6f6220c351735421c7bbb912fbce 148476 graphicsmagick_1.4+really1.3.37-1.debian.tar.xz
Files:
 3002789513190bd5202f841567641964 2860 graphics optional graphicsmagick_1.4+really1.3.37-1.dsc
 ec6c7f9a587f15ae4a0d15dda81907cd 5623688 graphics optional graphicsmagick_1.4+really1.3.37.orig.tar.xz
 135f13d46a80ee4c0fb27bc95e74362d 148476 graphics optional graphicsmagick_1.4+really1.3.37-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAmG3i3wACgkQ3OMQ54ZM
yL9hgg/+M4cs+PI/nhfpa95laQRq6WYAi9pvosmkxEcnxh2IPjnMAHqew6Qho3Z5
MHQs1GhsN1qSno06K8wdYFT/EdDhpBvw9uxT15L1uthI63AMvorT7kRtN939S9OZ
OsA8/ew+1IfkldSWb1DqVlaRMsCPGueuopjEz9WWqXPDVcPq73nmLx+CDpsD6CpZ
mbR1yzFtqZcJhvzzqLxvslNYin3WLARiQdHVjwD4VM7psZc5PuqdG6bA+2cTaLB1
jl/sYvftsEIHt6iIpjQ9PnjHVB90MY3IsJRqm94/JZmgqkIVJ/YKW+DX/VDwumIz
9XOrKJKclN+diVWinA9OSpw7kyXa2czfPB2BhQ03wKEvF+uHpvM550nnngOtgmMf
rC/t3fE00nYhcWaw8oWVwH1ouiYPz9lxUp6OuzhZYEHHkSpcjt1PXxXuccpIw69d
vM9TFBtqCNgjpWnJaHtKYAiyaRUybuhIgyqC30RLwnAXFi8r3yR1l3pzA19L2apU
atTnQd8/GTCPFJRbVEgWkJRtIzMcOa21RdfCf6WAynWfLEyATbq8W7gwiVLmwhPy
OeAi1TwX0L6lrutp++RgJ3rB7xZ52DO0pr/yaWo5Zvf7RBiHxzSSbdETpI4MG+3C
Czi2S1YuEU3M1uuhRhy179zJrh7tGHxooQbc6ZlR5Avkj8Uckyk=
=9SIH
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 15 Jan 2022 07:29:38 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:19:51 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.