989583">

Debian Bug report logs - #989583
liblip: Fails to build reproducibly: multiple problems

version graph

Package: src:liblip; Maintainer for src:liblip is Debian QA Group <packages@qa.debian.org>;

Reported by: Nilesh Patra <nilesh@debian.org>

Date: Mon, 7 Jun 2021 23:24:01 UTC

Severity: normal

Tags: patch

Found in version liblip/2.0.0-1.2

Fixed in versions liblip/2.0.0-1.4, liblip/2.0.0-1.5

Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, nilesh@debian.org, nilesh@debian.org, reproducible-bugs@lists.alioth.debian.org, Juan Esteban Monsalve Tobon <esteban@v7w.com>:
Bug#989583; Package src:liblip. (Mon, 07 Jun 2021 23:24:04 GMT) (full text, mbox, link).


Acknowledgement sent to Nilesh Patra <nilesh@debian.org>:
New Bug report received and forwarded. Copy sent to nilesh@debian.org, nilesh@debian.org, reproducible-bugs@lists.alioth.debian.org, Juan Esteban Monsalve Tobon <esteban@v7w.com>. (Mon, 07 Jun 2021 23:24:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Nilesh Patra <nilesh@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: liblip: Fails to build reproducibly: multiple problems
Date: Tue, 08 Jun 2021 04:51:08 +0530
[Message part 1 (text/plain, inline)]
Source: liblip
Version: 2.0.0-1.2
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps, buildpath
X-Debbugs-Cc: nilesh@debian.org, nilesh@debian.org, reproducible-bugs@lists.alioth.debian.org

Dear Maintainer,

The following problems cause problems in liblip being reproducible:

a) It embeds timestamps into gzip headers, simply passing -n with gzip
  fixes it
b) md5sum that it injects to DEBIAN/md5sums are random in order, simply
  sorting them does the trick
c) It embeds buildpath in resulting .deb because -ffile-prefix-map isn't
  injected by default since this does not seem to use debhelper, and uses a hand-coded d/rules w/o dh
  customizations and compat level. Manually adding the -ffile-prefix-map
  with relevant options seems to do the trick.

Please consider applying the attached patch.

Thanks!
Nilesh


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
[reproducible.patch (text/plain, attachment)]

Added tag(s) pending. Request was from Vagrant Cascadian <vagrant@reproducible-builds.org> to 1001513-submit@bugs.debian.org. (Thu, 15 Dec 2022 22:39:06 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Juan Esteban Monsalve Tobon <esteban@v7w.com>:
Bug#989583; Package src:liblip. (Thu, 15 Dec 2022 22:39:09 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Juan Esteban Monsalve Tobon <esteban@v7w.com>. (Thu, 15 Dec 2022 22:39:09 GMT) (full text, mbox, link).


Message #12 received at 989583@bugs.debian.org (full text, mbox, [ ! -f Makefile ] || $(MAKE) distclean > -rm -f config.log config.cache > - ./configure --prefix=/usr --enable-static > - $(MAKE) install prefix=$(CURDIR)/static > + ./configure --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE) --prefix=/usr --enable-static &In-Reply-To=<87tu1wgut7.fsf@contorta>&References=<162310806895.304493.10844084089948727078.reportbug@debian> <87tu1wgut7.fsf@contorta>">reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Nilesh Patra <nilesh@debian.org>, 989583@bugs.debian.org, Helmut Grohne <helmut@subdivi.de>, 1001513@bugs.debian.org
Subject: Re: Bug#989583: liblip: Fails to build reproducibly: multiple problems
Date: Thu, 15 Dec 2022 14:34:44 -0800
[Message part 1 (text/plain, inline)]
Control: tags 989583 pending
Control: tags 1001513 pending

Uploading an NMU to DELAYED/10 fixing reproducible builds and
cross-building issues:

diff -u liblip-2.0.0/debian/changelog liblip-2.0.0/debian/changelog
--- liblip-2.0.0/debian/changelog
+++ liblip-2.0.0/debian/changelog
@@ -1,3 +1,21 @@
+liblip (2.0.0-1.5) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Helmut Grohne ]
+  * Support cross-building (Closes: #1001513)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 15 Dec 2022 14:21:26 -0800
+
+liblip (2.0.0-1.4) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Nilesh Patra ]
+  * Build reproducibly (Closes: #989583)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 15 Dec 2022 13:49:39 -0800
+
 liblip (2.0.0-1.3) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -u liblip-2.0.0/debian/rules liblip-2.0.0/debian/rules
--- liblip-2.0.0/debian/rules
+++ liblip-2.0.0/debian/rules
@@ -2,18 +2,24 @@
 # Copyright (C) 2004-2005 Anibal Monsalve Salazar <anibal@debian.org>
 # Copyright (c) 2005 Juan Esteban Monsalve Tobon <esteban@v7w.com>
 
-STRIP      = strip --strip-unneeded --remove-section=.comment --remove-section=.note
+include /usr/share/dpkg/architecture.mk
+include /usr/share/dpkg/buildtools.mk
+
+STRIP      := $(STRIP) --strip-unneeded --remove-section=.comment --remove-section=.note
+
+CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS)
+CXXFLAGS += -ffile-prefix-map=$(CURDIR)=.
 
 build:
 	$(checkdir)
 	cp -f /usr/share/misc/config.sub .
 	cp -f /usr/share/misc/config.guess .
-	./configure --prefix=/usr --enable-shared
-	$(MAKE) install prefix=$(CURDIR)/shared
+	./configure --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE) --prefix=/usr --enable-shared	./configure --prefix=/usr --enable-shared
+	$(MAKE) install prefix=$(CURDIR)/shared CXXFLAGS="$(CXXFLAGS)"
 	[ ! -f Makefile ] || $(MAKE) distclean
 	-rm -f config.log config.cache
-	./configure --prefix=/usr --enable-static
-	$(MAKE) install prefix=$(CURDIR)/static
+	./configure --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE) --prefix=/usr --enable-static
+	$(MAKE) install prefix=$(CURDIR)/static CXXFLAGS="$(CXXFLAGS)"
 	touch build
 
 clean:
@@ -59,20 +65,22 @@
 	cp -p docs/* debian/liblip2/usr/share/doc/liblip2/
 	cp -p examples/example* debian/liblip2/usr/share/doc/liblip2/examples
 	cp -p examples/makefile debian/liblip2/usr/share/doc/liblip2/examples
-	cd debian/liblip2/usr/share/doc/liblip2 && gzip -9 changelog.Debian examples/*
+	cd debian/liblip2/usr/share/doc/liblip2 && gzip -9n changelog.Debian examples/*
 
 	ln -s liblip2 debian/liblip-dev/usr/share/doc/liblip-dev
 
 	dpkg-shlibdeps debian/liblip2/usr/lib/lip/*
 	dpkg-gencontrol -isp -pliblip2 -Pdebian/liblip2
-	cd debian/liblip2 && md5sum `find * -type f ! -regex "DEBIAN/.*"` > DEBIAN/md5sums
+	cd debian/liblip2 && find * -type f ! -regex "DEBIAN/.*" -print0 |\
+	LC_ALL=C sort -z | xargs -0r md5sum > DEBIAN/md5sums
 	chown -R root.root debian/liblip2
 	chmod -x debian/liblip2/usr/lib/lip/*
 	chmod -R go=rX debian/liblip2
 	dpkg --build debian/liblip2 ..
 
 	dpkg-gencontrol -isp -pliblip-dev -Pdebian/liblip-dev
-	cd debian/liblip-dev && md5sum `find * -type f ! -regex "DEBIAN/.*"` > DEBIAN/md5sums
+	cd debian/liblip-dev && find * -type f ! -regex "DEBIAN/.*" -print0 |\
+	LC_ALL=C sort -z | xargs -0r md5sum > DEBIAN/md5sums
 	chown -R root.root debian/liblip-dev
 	chmod -x debian/liblip-dev/usr/lib/lip/liblip.a
 	chmod -x debian/liblip-dev/usr/lib/lip/liblip.la
[signature.asc (application/pgp-signature, inline)]

Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Sun, 25 Dec 2022 22:51:02 GMT) (full text, mbox, link).


Notification sent to Nilesh Patra <nilesh@debian.org>:
Bug acknowledged by developer. (Sun, 25 Dec 2022 22:51:02 GMT) (full text, mbox, link).


Message #17 received at 989583-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 989583-close@bugs.debian.org
Subject: Bug#989583: fixed in liblip 2.0.0-1.4
Date: Sun, 25 Dec 2022 22:49:16 +0000
Source: liblip
Source-Version: 2.0.0-1.4
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
liblip, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 989583@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated liblip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 15 Dec 2022 13:49:39 -0800
Source: liblip
Architecture: source
Version: 2.0.0-1.4
Distribution: unstable
Urgency: medium
Maintainer: Juan Esteban Monsalve Tobon <esteban@v7w.com>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 989583
Changes:
 liblip (2.0.0-1.4) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Nilesh Patra ]
   * Build reproducibly (Closes: #989583)
Checksums-Sha1:
 4305506686c7d455f8f41190d97279bbe91d7117 1323 liblip_2.0.0-1.4.dsc
 116f5e87b4c250811388cc8cc5f6b58f66d962df 40981 liblip_2.0.0-1.4.diff.gz
Checksums-Sha256:
 5c680a64dc4edd93863460e8f58ca5118d9c82d8922cdcb34a19969f05997952 1323 liblip_2.0.0-1.4.dsc
 e47ec681edb636e7afda51afd5324f3f0397e608dd08396e459b3267b7006577 40981 liblip_2.0.0-1.4.diff.gz
Files:
 5ae2e2d401386f6252b5c20705e2b333 1323 math optional liblip_2.0.0-1.4.dsc
 cbf08212c0cf0006cead8e36bec71e7d 40981 math optional liblip_2.0.0-1.4.diff.gz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY5uYZCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqo5hAP0Qnw9oviwXsRso
3KWSWRMaRPopX8QomXPVPC4hf7YC7AEAscqMizHLHWtm+PzIHpkmUigE3Jh9rw1u
urDcyRAp4A4=
=5bWb
-----END PGP SIGNATURE-----




Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Sun, 25 Dec 2022 23:21:05 GMT) (full text, mbox, link).


Notification sent to Nilesh Patra <nilesh@debian.org>:
Bug acknowledged by developer. (Sun, 25 Dec 2022 23:21:05 GMT) (full text, mbox, link).


Message #22 received at 989583-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 989583-close@bugs.debian.org
Subject: Bug#989583: fixed in liblip 2.0.0-1.5
Date: Sun, 25 Dec 2022 23:19:51 +0000
Source: liblip
Source-Version: 2.0.0-1.5
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
liblip, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 989583@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated liblip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 15 Dec 2022 14:21:26 -0800
Source: liblip
Architecture: source
Version: 2.0.0-1.5
Distribution: unstable
Urgency: medium
Maintainer: Juan Esteban Monsalve Tobon <esteban@v7w.com>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 989583 1001513
Changes:
 liblip (2.0.0-1.5) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Helmut Grohne ]
   * Support cross-building (Closes: #1001513)
 .
 liblip (2.0.0-1.4) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Nilesh Patra ]
   * Build reproducibly (Closes: #989583)
Checksums-Sha1:
 d9a4b16b121edec533c991cde4be2ccda0e847cf 1323 liblip_2.0.0-1.5.dsc
 bec359c57ec93e3e99237a47620591ef72715805 41028 liblip_2.0.0-1.5.diff.gz
Checksums-Sha256:
 b6d9022dc5e6cdb118ea02d12046da938a99a7e01a74b1ae80c33dc5b1e747b0 1323 liblip_2.0.0-1.5.dsc
 d2ba83a34c74a76fc979023db8503f5df84335ad392aad5956483e0d4349cbd0 41028 liblip_2.0.0-1.5.diff.gz
Files:
 9bcf807d419376c3805fe16a4b0113f5 1323 math optional liblip_2.0.0-1.5.dsc
 b1b0223ffd3b5628955d876454593da5 41028 math optional liblip_2.0.0-1.5.diff.gz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY5ufryAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWql0WAP9oQgEbWp4DED0A
VgDsfwqDu3dpIZZQUefLVM10ZpPeZQD+K0uzh/h+N34+3MzczKuL0okA2Yj2TTsm
gZnnZxCYHQ4=
=dlZC
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 28 Jan 2023 07:29:51 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:20:14 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.