972496">

Debian Bug report logs - #972496
softether-vpn: please make the build reproducible

version graph

Package: src:softether-vpn; Maintainer for src:softether-vpn is Andrej Shadura <andrewsh@debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Mon, 19 Oct 2020 10:51:01 UTC

Severity: wishlist

Tags: patch

Found in version softether-vpn/5.01.9674+git20200806+8181039+dfsg-1

Fixed in version softether-vpn/5.01.9674+git20200806+8181039+dfsg-2

Done: Andrej Shadura <andrewsh@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Andrej Shadura <andrewsh@debian.org>:
Bug#972496; Package src:softether-vpn. (Mon, 19 Oct 2020 10:51:03 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Andrej Shadura <andrewsh@debian.org>. (Mon, 19 Oct 2020 10:51:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, wrote: > Source: softether-vpn > Version: 5.01.9674+git20200806+8181039+dfsg-1 > Severity: wishlist > Tags: patch > User: reproducible-builds@lists.alioth.debian.org > Usertags: hostname > X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org > > Hi, > > Whilst working on the Reproducible Builds effort [0] we noticed that > softether-vpn could not be built reproducibly. > > This is because it embeds the build username and build hostname into > the final binary. > > Patch attached that doesn't set these variables (by editing the CMake > build configuration). The build does not fail when we do not define > these because of #ifdef preprocessor macros in upstream's header > files that has fallbacks. > > The build is not fully reproducible with this change though, but it > will be once we enable fixfilepath dpkg-buildflags feature area toggle > archive-wide. (There's a thread unfolding on dpkg-dev now; no need to > set this here for now.) > > [0] https://reproducible-builds.org/ > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org / chris-lamb.co.uk > `- &References=<160310418725.17269.14232621466562758993@09b89f3bd117>&subject=Re: softether-vpn: please make the build reproducible">reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: softether-vpn: please make the build reproducible
Date: Mon, 19 Oct 2020 11:47:36 +0100
[Message part 1 (text/plain, inline)]
Source: softether-vpn
Version: 5.01.9674+git20200806+8181039+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: hostname
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
softether-vpn could not be built reproducibly.

This is because it embeds the build username and build hostname into
the final binary.

Patch attached that doesn't set these variables (by editing the CMake
build configuration). The build does not fail when we do not define
these because of #ifdef preprocessor macros in upstream's header
files that has fallbacks.

The build is not fully reproducible with this change though, but it
will be once we enable fixfilepath dpkg-buildflags feature area toggle
archive-wide. (There's a thread unfolding on dpkg-dev now; no need to
set this here for now.)

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[softether-vpn.diff.txt (text/plain, attachment)]

Reply sent to Andrej Shadura <andrewsh@debian.org>:
You have taken responsibility. (Mon, 19 Oct 2020 13:27:02 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Mon, 19 Oct 2020 13:27:03 GMT) (full text, mbox, link).


Message #10 received at 972496-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 972496-close@bugs.debian.org
Subject: Bug#972496: fixed in softether-vpn 5.01.9674+git20200806+8181039+dfsg-2
Date: Mon, 19 Oct 2020 13:22:52 +0000
Source: softether-vpn
Source-Version: 5.01.9674+git20200806+8181039+dfsg-2
Done: Andrej Shadura <andrewsh@debian.org>

We believe that the bug you reported is fixed in the latest version of
softether-vpn, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 972496@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrej Shadura <andrewsh@debian.org> (supplier of updated softether-vpn package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 19 Oct 2020 14:14:55 +0200
Source: softether-vpn
Architecture: source
Version: 5.01.9674+git20200806+8181039+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Andrej Shadura <andrewsh@debian.org>
Changed-By: Andrej Shadura <andrewsh@debian.org>
Closes: 972496
Changes:
 softether-vpn (5.01.9674+git20200806+8181039+dfsg-2) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Make the build reproducible (Closes: #972496).
Checksums-Sha1:
 b5679bf9309eb22ddff4695000f9b372350917be 2216 softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
 3df293a3afd8e493d4111940060d21ba71300c31 4720 softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz
Checksums-Sha256:
 137f9290425d1a6570ad1e0957b93057e65729cde6562f8f3f84e7e4c6622579 2216 softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
 ff5d3206ee28b04553a24c13770e14c06aeaa833a34470a8e26a8fb04339cf21 4720 softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz
Files:
 175234bb09e3ae4288d4e1aff99aea04 2216 net optional softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.dsc
 db67f82019b7a07cf34c1dad88fd2eb5 4720 net optional softether-vpn_5.01.9674+git20200806+8181039+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEeuS9ZL8A0js0NGiOXkCM2RzYOdIFAl+Ng2AACgkQXkCM2RzY
OdKkSQgAg+GEdLZl1DsO++s2XoFh2fZakQQfZ2EAAhQLQaBp5tcerNox69LXjIY1
F/T9FM3de/cduaVcPNb0qbUixxKg5Wvce7Sz61njnArwr9zJ0NU1XhBy9uWRk7+3
BoJ28SEt7nHxU3tvx3yImiu/c7irdou9b9vv5oADz/XDvbccd+8QCc/Zb/qKGLvh
ipsJiCI6fMgw3Roe/RwPHQDUuUrcuEHeutda0LsVHmMcgmzRxvGga9vSEg9w3idr
qwz28N3qkSTmS2+EOgplX82PfdgsNHSjanmRVelmQqKUa5XxlWhivnKQHM6o13Jc
JSYYjg6G9/lOonvIvprKBX/bcS4lhQ==
=g60M
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 05 Jan 2021 07:32:22 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 06:15:41 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.