972336">

Debian Bug report logs - #972336
ora2pg: please make the build reproducible

version graph

Package: src:ora2pg; Maintainer for src:ora2pg is Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>;

Reported by: "Chris Lamb" <lamby@debian.org>

Date: Fri, 16 Oct 2020 10:42:01 UTC

Severity: wishlist

Tags: fixed-upstream, patch

Found in version ora2pg/21.0-1

Done: Christoph Berg <myon@debian.org>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/darold/ora2pg/pull/1009

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>:
Bug#972336; Package src:ora2pg. (Fri, 16 Oct 2020 10:42:03 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>. (Fri, 16 Oct 2020 10:42:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, wrote: > Source: ora2pg > Version: 21.0-1 > Severity: wishlist > Tags: patch > User: reproducible-builds@lists.alioth.debian.org > Usertags: randomness > X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org > > Hi, > > Whilst working on the Reproducible Builds effort [0] we noticed that > ora2pg could not be built reproducibly. > > This is because it generates a comment in a config file using '$$' in > an attempt to get a literal '$' character. But '$$' inserts the > process PID (!) of the build process into the file instead. > > This PID is, of course, non-deterministic, resulting in a reproducible > build. > > Patch attached that uses '\$' instead. > > [0] https://reproducible-builds.org/ > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org / chris-lamb.co.uk > `- ">reply):

From: "Chris Lamb" <lamby@debian.org>
To: submit@bugs.debian.org
Subject: ora2pg: please make the build reproducible
Date: Fri, 16 Oct 2020 11:37:39 +0100
[Message part 1 (text/plain, inline)]
Source: ora2pg
Version: 21.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
ora2pg could not be built reproducibly.

This is because it generates a comment in a config file using '$$' in
an attempt to get a literal '$' character. But '$$' inserts the
process PID (!) of the build process into the file instead.

This PID is, of course, non-deterministic, resulting in a reproducible
build.

Patch attached that uses '\$' instead.

 [0] https://reproducible-builds.org/


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[ora2pg.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>:
Bug#972336; Package src:ora2pg. (Fri, 16 Oct 2020 11:03:02 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>. (Fri, 16 Oct 2020 11:03:02 GMT) (full text, mbox, link).


Message #10 received at 972336@bugs.debian.org (full text, mbox, wrote: > forwarded 972336 https://github.com/darold/ora2pg/pull/1009 > thanks > > I've forwarded this upstream here: > > https://github.com/darold/ora2pg/pull/1009 > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org / chris-lamb.co.uk > `- > > &References=<160284550322.1891681.15078722997086085262@tinycat.chris-lamb.co.uk>&subject=Re: ora2pg: please make the build reproducible">reply):

From: "Chris Lamb" <lamby@debian.org>
To: 972336@bugs.debian.org
Subject: Re: ora2pg: please make the build reproducible
Date: Fri, 16 Oct 2020 06:52:35 -0400 (EDT)
forwarded 972336 https://github.com/darold/ora2pg/pull/1009
thanks

I've forwarded this upstream here:

  https://github.com/darold/ora2pg/pull/1009


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Set Bug forwarded-to-address to 'https://github.com/darold/ora2pg/pull/1009'. Request was from "Chris Lamb" <lamby@debian.org> to control@bugs.debian.org. (Fri, 16 Oct 2020 11:03:03 GMT) (full text, mbox, link).


Added tag(s) fixed-upstream. Request was from debian-bts-link@lists.debian.org to control@bugs.debian.org. (Thu, 22 Oct 2020 17:21:06 GMT) (full text, mbox, link).


Reply sent to Christoph Berg <myon@debian.org>:
You have taken responsibility. (Thu, 08 Jul 2021 08:12:19 GMT) (full text, mbox, link).


Notification sent to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer. (Thu, 08 Jul 2021 08:12:20 GMT) (full text, mbox, link).


Message #19 received at 972336-done@bugs.debian.org (full text, mbox, reply):

From: Christoph Berg <myon@debian.org>
To: Chris Lamb <lamby@debian.org>, 972336-done@bugs.debian.org
Subject: Re: Bug#972336: ora2pg: please make the build reproducible
Date: Thu, 8 Jul 2021 10:08:20 +0200
Version 21.1-1

Re: Chris Lamb
> forwarded 972336 https://github.com/darold/ora2pg/pull/1009
> thanks
> 
> I've forwarded this upstream here:
> 
>   https://github.com/darold/ora2pg/pull/1009

This has been applied upstream in the meantime.

Christoph



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 06 Aug 2021 07:25:06 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 06:10:18 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.