Acknowledgement sent
to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>.
(Mon, 12 Oct 2020 10:06:03 GMT) (full text, mbox, link).
Source: sound-juicer
Version: 3.38.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
sound-juicer could not be built reproducibly.
This is because the binary embeds an absolute path to the
data/rhythmbox.gep file, presumably so that the file can be located
from a development/git checkout or similar.
As this is not necessary (and won't ever resolve) in a regular Debian
context, the attached patch replaces the reference to the absolute
build directory to ".", i.e. the current directory.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>: Bug#972078; Package src:sound-juicer.
(Wed, 26 Oct 2022 19:12:05 GMT) (full text, mbox, link).
Acknowledgement sent
to Philip Rinn <rinni@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>.
(Wed, 26 Oct 2022 19:12:05 GMT) (full text, mbox, link).
Cc: Philip Rinn <rinni@debian.org>, reproducible-builds@lists.alioth.debian.org
Subject: sound-juicer: diff for NMU version 3.38.0-2.1
Date: Wed, 26 Oct 2022 21:05:51 +0200
Control: tags 972078 + pending
Dear maintainer,
I've prepared an NMU for sound-juicer (versioned as 3.38.0-2.1) and
uploaded it to DELAYED/14. Please feel free to tell me if I
should delay it longer.
(The change in Uploaders somehow happened automatically during the gbp buildpackage run, not sure why.)
Best,
Philip
diff -Nru sound-juicer-3.38.0/debian/changelog sound-juicer-3.38.0/debian/changelog
--- sound-juicer-3.38.0/debian/changelog 2022-02-18 22:16:14.000000000 +0100
+++ sound-juicer-3.38.0/debian/changelog 2022-10-26 20:58:46.000000000 +0200
@@ -1,3 +1,12 @@
+sound-juicer (3.38.0-2.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Make build reproducible: Replace absolute path to source location of
+ data/rhythmbox.gep embedded in binary with relative path. It would never
+ resolve and is not necassary in an end-user installation (Closes: #972078)
+
+ -- Philip Rinn <rinni@debian.org> Wed, 26 Oct 2022 20:58:46 +0200
+
sound-juicer (3.38.0-2) unstable; urgency=medium
* Drop unneeded -Wl,--as-needed and -Wno-unused-parameter
diff -Nru sound-juicer-3.38.0/debian/control sound-juicer-3.38.0/debian/control
--- sound-juicer-3.38.0/debian/control 2022-02-18 22:16:14.000000000 +0100
+++ sound-juicer-3.38.0/debian/control 2022-10-26 20:58:46.000000000 +0200
@@ -6,7 +6,7 @@
Section: sound
Priority: optional
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
-Uploaders: Jeremy Bicha <jbicha@debian.org>, Laurent Bigonville <bigon@debian.org>, Michael Biebl <biebl@debian.org>
+Uploaders: Laurent Bigonville <bigon@debian.org>, Michael Biebl <biebl@debian.org>
Build-Depends: debhelper-compat (= 13),
appstream,
appstream-util <!nocheck>,
diff -Nru sound-juicer-3.38.0/debian/patches/reproducible-build.patch sound-juicer-3.38.0/debian/patches/reproducible-build.patch
--- sound-juicer-3.38.0/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000 +0100
+++ sound-juicer-3.38.0/debian/patches/reproducible-build.patch 2022-10-26 18:01:17.000000000 +0200
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2020-10-12
+
+--- sound-juicer-3.38.0.orig/libjuicer/rb-gst-media-types.c
++++ sound-juicer-3.38.0/libjuicer/rb-gst-media-types.c
+@@ -34,7 +34,7 @@
+
+ #include "rb-gst-media-types.h"
+
+-#define SOURCE_ENCODING_TARGET_FILE TOPSRCDIR"/data/rhythmbox.gep"
++#define SOURCE_ENCODING_TARGET_FILE "./data/rhythmbox.gep"
+ #define INSTALLED_ENCODING_TARGET_FILE DATADIR"/sound-juicer/rhythmbox.gep"
+ static GstEncodingTarget *default_target = NULL;
+
diff -Nru sound-juicer-3.38.0/debian/patches/series sound-juicer-3.38.0/debian/patches/series
--- sound-juicer-3.38.0/debian/patches/series 2022-02-18 22:16:14.000000000 +0100
+++ sound-juicer-3.38.0/debian/patches/series 2022-10-26 18:01:37.000000000 +0200
@@ -2,3 +2,4 @@
Fix-showing-icon-in-the-about-dialog.patch
build-fix-doc-directory.patch
meson-drop-unused-argument-for-i18n.merge_file.patch
+reproducible-build.patch
Added tag(s) pending.
Request was from Philip Rinn <rinni@debian.org>
to 972078-submit@bugs.debian.org.
(Wed, 26 Oct 2022 19:12:05 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>: Bug#972078; Package src:sound-juicer.
(Wed, 26 Oct 2022 19:21:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Jeremy Bicha <jeremy.bicha@canonical.com>:
Extra info received and forwarded to list. Copy sent to Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>.
(Wed, 26 Oct 2022 19:21:04 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>: Bug#972078; Package src:sound-juicer.
(Wed, 26 Oct 2022 19:42:07 GMT) (full text, mbox, link).
Acknowledgement sent
to Philip Rinn <rinni@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>.
(Wed, 26 Oct 2022 19:42:07 GMT) (full text, mbox, link).
Subject: Bug#972078: fixed in sound-juicer 3.38.0-2.1
Date: Thu, 27 Oct 2022 16:23:02 +0000
Source: sound-juicer
Source-Version: 3.38.0-2.1
Done: Philip Rinn <rinni@debian.org>
We believe that the bug you reported is fixed in the latest version of
sound-juicer, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 972078@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Philip Rinn <rinni@debian.org> (supplier of updated sound-juicer package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 26 Oct 2022 20:58:46 +0200
Source: sound-juicer
Architecture: source
Version: 3.38.0-2.1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
Changed-By: Philip Rinn <rinni@debian.org>
Closes: 972078
Changes:
sound-juicer (3.38.0-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Make build reproducible: Replace absolute path to source location of
data/rhythmbox.gep embedded in binary with relative path. It would never
resolve and is not necassary in an end-user installation (Closes: #972078)
Checksums-Sha1:
78cec2c602b0f70ec5f5b6a934617a9ddf43bb2b 2415 sound-juicer_3.38.0-2.1.dsc
60287c47ae936518dd56aca145e3d45ecbad8bef 9872 sound-juicer_3.38.0-2.1.debian.tar.xz
6fcac65af326d831e87c13bb078f28aa6bba824d 17841 sound-juicer_3.38.0-2.1_amd64.buildinfo
Checksums-Sha256:
6f6bc9974fa710e8eac121baf9585a03e251ba990979128558c9356c107fefa4 2415 sound-juicer_3.38.0-2.1.dsc
a97e0f9e40f8cf6d093d074d928c4c61a8b3e4632fa0ca94a2d1ea2c807a5089 9872 sound-juicer_3.38.0-2.1.debian.tar.xz
7836fc70733be85a1502917714db459b3e262328705a1bda8ec1f936ca681921 17841 sound-juicer_3.38.0-2.1_amd64.buildinfo
Files:
1d12efd98c323c0e3de90c04e8663db6 2415 sound optional sound-juicer_3.38.0-2.1.dsc
778feb10bc7264697918632e1115a4c7 9872 sound optional sound-juicer_3.38.0-2.1.debian.tar.xz
eb0d05db5d8215a1ae21a04ab32eb959 17841 sound optional sound-juicer_3.38.0-2.1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEK9jU45eVX3dG2zuJrWkWlnOTmCsFAmNZheYACgkQrWkWlnOT
mCsYMBAAjMhQA6OKeIIRrtqlYR7Kmdw0e5sl8dl4S0D7fvean8+FQ1yPfTkLHRDN
3gc7uLfNDRO4WO28nRpbG0W7R0yp6rk1ksEYbYFhzo88r1gP3O4cwIs+6pi5FcoA
25kMe2sLIaVWnIZdNcSnEmKwS2eJXmsJpcreBaAmq2vLUf7p/7as2QK0D6tizaLq
ky5/TRFHUqYOQJbFbXkgWWnczil+D9PzGTTqoqMi9zYy1AHCy+97SomQCpEXQ8+J
94kGSOMA4ugO/q4gFt/j+uc7wixgulzF5QNxt7BX7mnO2Xn1wRi9JsuK3fz2EIqR
t5FtB06zbzFJn0tu8wTQJiNZRUncqx/JNLlU9pEZd+oNpGWsyxPMfRbV5ja+oXHA
5vbXE5+quOCDqqaD3fiGkKntncriuaA5fnaUbz3r+Q7AclX74JYOcX8f+DLm26dh
Ed1+bSCDt4/uYvhDB4WnHCs4kKd4qWBvWtDRZqif1ogd99YYa3bp1atUsbw9eCTA
w1WRbIK7uRMtjhzafphnge6qoE0uDE0oBNS1lB5j/8XFSuP2Mp3Uhan6p75MUTix
l1tfn/+0natTAxbOSh1Zt67YVmD1qgBLHyD0BDOeOuJkW3IYMWJXaA+JhwDbqUg3
7i0TwFuAocQTOPaU8NcSTjS3w8AGBZjnpDIGMeK2m8wItY8oZmU=
=ZhDu
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Wed, 30 Nov 2022 07:27:47 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.