968652">

Debian Bug report logs - #968652
glusterfs: systemd scripts only installed when built on usrmerge system

version graph

Package: src:glusterfs; Maintainer for src:glusterfs is Patrick Matthäi <pmatthaei@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Wed, 19 Aug 2020 05:18:02 UTC

Severity: normal

Tags: patch

Found in version glusterfs/8.0-2

Fixed in version glusterfs/8.0-3

Done: =?utf-8?q?Patrick_Matth=C3=A4i?= <pmatthaei@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, unknown-package@qa.debian.org:
Bug#968652; Package src:glusterfs-common. (Wed, 19 Aug 2020 05:18:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, unknown-package@qa.debian.org. (Wed, 19 Aug 2020 05:18:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: glusterfs: systemd scripts only installed when built on usrmerge system
Date: Tue, 18 Aug 2020 22:15:23 -0700
[Message part 1 (text/plain, inline)]
Source: glusterfs-common
Severity: normal
Version: 8.0-2
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Some files (control-cpu-load.sh, control-mem.sh,
mount-shared-storage.sh) only get installed when systemd support is
detected on the build machine and usrmerge is enabled, resulting in
different builds based on when usrmerge and/or systemd is installed.

The attached patch removes the build-time detection of systemd for these
files so that they are always installed, resulting in a reproducible
build.


Thanks for maintaining glusterfs!


live well,
  vagrant

[remove-use_systemd-guards-around-several.patch (text/x-diff, inline)]
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 19 Aug 2020 04:42:53 +0000
X-Dgit-Generated: 8.0-3~0~20200819~1 5b649367b94d7c2e60e36e29b18019169a9a75e6
Subject: Remove USE_SYSTEMD guards around several scripts that should always

get installed.

The build-time detection of systemd support only appears to work when
usrmerge is enabled, resulting in different packages on usrmerge
vs. non-usrmerge systems, breaking reproducible builds.

---

--- glusterfs-8.0.orig/extras/Makefile.am
+++ glusterfs-8.0/extras/Makefile.am
@@ -2,10 +2,8 @@ addonexecdir = $(GLUSTERFS_LIBEXECDIR)
 addonexec_SCRIPTS =
 if WITH_SERVER
 addonexec_SCRIPTS += peer_add_secret_pub
-if USE_SYSTEMD
 addonexec_SCRIPTS += mount-shared-storage.sh
 endif
-endif
 
 EditorModedir = $(docdir)
 EditorMode_DATA = glusterfs-mode.el glusterfs.vim
@@ -33,11 +31,9 @@ scripts_SCRIPTS = thin-arbiter/setup-thi
 if WITH_SERVER
 scripts_SCRIPTS += post-upgrade-script-for-quota.sh \
 	pre-upgrade-script-for-quota.sh stop-all-gluster-processes.sh
-if USE_SYSTEMD
 scripts_SCRIPTS += control-cpu-load.sh
 scripts_SCRIPTS += control-mem.sh
 endif
-endif
 
 EXTRA_DIST = glusterfs-logrotate gluster-rsyslog-7.2.conf gluster-rsyslog-5.8.conf \
 	logger.conf.example glusterfs-georep-logrotate group-virt.example \
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, unknown-package@qa.debian.org:
Bug#968652; Package src:glusterfs-common. (Sat, 22 Aug 2020 13:21:03 GMT) (full text, mbox, link).


Message #8 received at 968652@bugs.debian.org (full text, mbox, reply):

From: Andrei POPESCU <andreimpopescu@gmail.com>
To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 968652@bugs.debian.org
Cc: glusterfs-common@packages.debian.org
Subject: Re: Bug#968652: glusterfs: systemd scripts only installed when built on usrmerge system
Date: Sat, 22 Aug 2020 16:18:21 +0300
[Message part 1 (text/plain, inline)]
Control: reassign -1 src:glusterfs 8.0-2

On Ma, 18 aug 20, 22:15:23, Vagrant Cascadian wrote:
> Source: glusterfs-common
> Severity: normal
> Version: 8.0-2
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: usrmerge
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Some files (control-cpu-load.sh, control-mem.sh,
> mount-shared-storage.sh) only get installed when systemd support is
> detected on the build machine and usrmerge is enabled, resulting in
> different builds based on when usrmerge and/or systemd is installed.
> 
> The attached patch removes the build-time detection of systemd for these
> files so that they are always installed, resulting in a reproducible
> build.
> 
> 
> Thanks for maintaining glusterfs!
> 
> 
> live well,
>   vagrant
> 





-- 
Looking after bugs assigned against unknown packages
[signature.asc (application/pgp-signature, inline)]

Bug reassigned from package 'src:glusterfs-common' to 'src:glusterfs'. Request was from Andrei POPESCU <andreimpopescu@gmail.com> to 968652-submit@bugs.debian.org. (Sat, 22 Aug 2020 13:21:03 GMT) (full text, mbox, link).


No longer marked as found in versions glusterfs-common/8.0-2. Request was from Andrei POPESCU <andreimpopescu@gmail.com> to 968652-submit@bugs.debian.org. (Sat, 22 Aug 2020 13:21:03 GMT) (full text, mbox, link).


Marked as found in versions glusterfs/8.0-2. Request was from Andrei POPESCU <andreimpopescu@gmail.com> to 968652-submit@bugs.debian.org. (Sat, 22 Aug 2020 13:21:04 GMT) (full text, mbox, link).


Reply sent to Patrick Matthäi <pmatthaei@debian.org>:
You have taken responsibility. (Tue, 25 Aug 2020 08:51:09 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Tue, 25 Aug 2020 08:51:09 GMT) (full text, mbox, link).


Message #19 received at 968652-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 968652-close@bugs.debian.org
Subject: Bug#968652: fixed in glusterfs 8.0-3
Date: Tue, 25 Aug 2020 08:49:22 +0000
Source: glusterfs
Source-Version: 8.0-3
Done: =?utf-8?q?Patrick_Matth=C3=A4i?= <pmatthaei@debian.org>

We believe that the bug you reported is fixed in the latest version of
glusterfs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 968652@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <pmatthaei@debian.org> (supplier of updated glusterfs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 25 Aug 2020 10:24:46 +0200
Source: glusterfs
Architecture: source
Version: 8.0-3
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <pmatthaei@debian.org>
Changed-By: Patrick Matthäi <pmatthaei@debian.org>
Closes: 968652
Changes:
 glusterfs (8.0-3) unstable; urgency=medium
 .
   * Add patch 01-remove-use-systemd-guards-around-several from Andrei Popescu.
     Closes: #968652
Checksums-Sha1:
 05558be412aa2b232cf8154d09d01502be82cb31 2525 glusterfs_8.0-3.dsc
 8b9c5d1abcec207b716bd4d6b05957872c3a0f6d 7800370 glusterfs_8.0.orig.tar.gz
 eaef023e9e6bf976f0145d045b49954434b64a6a 20316 glusterfs_8.0-3.debian.tar.xz
 87a0205952a54a3dfaf7dd96369ffa49a2d96298 6815 glusterfs_8.0-3_source.buildinfo
Checksums-Sha256:
 e7bedfbcd031272cf472a1c3e5eeef7213428b7f0c923fafd7d8b57004fd9db4 2525 glusterfs_8.0-3.dsc
 bc0215380175a7d94c9ea90e3a7e0ca92a3ac691336e8b43da8a560f8e3c0169 7800370 glusterfs_8.0.orig.tar.gz
 8fd58270eca1211cdc2075ec785fbaf8d458363da9e980463fecbc0667625bbf 20316 glusterfs_8.0-3.debian.tar.xz
 4a1649eae052a60f640729f7a91bb5e5814f97b171db058b07fc30afdb5af70d 6815 glusterfs_8.0-3_source.buildinfo
Files:
 3aa14c228b9d90711ca8e1eb0a8ab8ea 2525 admin optional glusterfs_8.0-3.dsc
 b36c86014bf6c38b027e291ff6300ab8 7800370 admin optional glusterfs_8.0.orig.tar.gz
 7c89bf8713fb0365eaa2761c6ab31ec7 20316 admin optional glusterfs_8.0-3.debian.tar.xz
 87557bee346c15fa262a3d0199442c9e 6815 admin optional glusterfs_8.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAl9Ey1sACgkQEtmwSpDL
2OTE0A//XLpdTqeKffcxUo71v0wpZLMxvPjIooDfpyf1OVFAkLs64OBcgkHiRPml
AGQzYSoEQOKF8dZNZ5wlQMLLVi8m7U+eqswDnSuadsypEY+nEDYsiArDQ1WKO8aP
AGmMdca/ZsRnKppVJpZf5/M0DojwplGeLM9ZRTjCrD9bk2jQ0CFvKoM4aDeHbYcf
7sy2Vo+xYNaqn/Lvo6yrJOjYKIy48h5hTIBWv6WyMm7BBb4D03vI6bLsI3mBd0sB
lO4S0DX3Du+2HU4j89k/wlon0igoRNlqJdsgya3nioYUiVb3SOjQlfgxAunIxkmm
GoW5FGEeEUToCwqVBLNiFyQzQrx2I5SJVGs/iDWRK0wT+PnMmvAkYzALhz0l2mTo
H92WahDsHGzRKGksXvRLSNyM7QMNxPBaeYVnwRS+S3snAaxf0O8BzRaG0CsZ1OeL
WPeOuwLtWo1ltw69jMaNv1vyUYYoDcTlyaQhuXbrSRAa0+R0BgbOZXrv3i6hpzr7
N0I77yEqPKxdCGOSphyMmzkbUd/pWR4WE1H/cx566Y3TiDNIBlLMbPxowE2vq/4a
91roLR5sl422bk5jd1+le3wbqVN19wfAvuDGstW3NKMSsMpMAA66g8fAIlEAscfF
wo8hvWs5aQsuNnvldmot7dtCZaTm1rOYVn0wWoz5wWim1mH4GRQ=
=SR/c
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 23 Sep 2020 07:27:29 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:56:55 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.