Acknowledgement sent
to "Chris Lamb" <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Mattia Rizzolo <mattia@debian.org>.
(Thu, 13 Aug 2020 11:06:06 GMT) (full text, mbox, link).
Source: pencil2d
Version: 0.6.4-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
pencil2d could not be built reproducibly.
While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit
the --utc flag to date(1) so the generated date will depend on the
build system's current timezone.
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Mattia Rizzolo <mattia@debian.org>: Bug#968344; Package src:pencil2d.
(Thu, 13 Aug 2020 15:15:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Mattia Rizzolo <mattia@debian.org>.
(Thu, 13 Aug 2020 15:15:02 GMT) (full text, mbox, link).
On 2020-08-13, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> pencil2d could not be built reproducibly.
>
> While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit
> the --utc flag to date(1) so the generated date will depend on the
> build system's current timezone.
...
> --- a/debian/rules 2020-08-13 11:34:56.164335215 +0100
> --- b/debian/rules 2020-08-13 11:59:46.372680920 +0100
> @@ -6,7 +6,7 @@
>
> # export information for the "About" screen
> include /usr/share/dpkg/pkg-info.mk
> -timestamp=$(shell date +%Y-%m-%d -d "@$(SOURCE_DATE_EPOCH)")
> +timestamp=$(shell date +%Y-%m-%d -d -u "@$(SOURCE_DATE_EPOCH)")
I think that should be:
+timestamp=$(shell date +%Y-%m-%d -u -d "@$(SOURCE_DATE_EPOCH)")
Since @SOURCE_DATE_EPOCH is be passed to the "-d" argument.
live well,
vagrant
Information forwarded
to debian-bugs-dist@lists.debian.org, Mattia Rizzolo <mattia@debian.org>: Bug#968344; Package src:pencil2d.
(Thu, 13 Aug 2020 16:03:03 GMT) (full text, mbox, link).
Acknowledgement sent
to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Mattia Rizzolo <mattia@debian.org>.
(Thu, 13 Aug 2020 16:03:03 GMT) (full text, mbox, link).
Subject: Re: Bug#968344: pencil2d: please make the build reproducible
Date: Thu, 13 Aug 2020 16:58:17 +0100
Hi Vagrant,
> I think that should be:
>
> +timestamp=$(shell date +%Y-%m-%d -u -d "@$(SOURCE_DATE_EPOCH)")
>
> Since @SOURCE_DATE_EPOCH is be passed to the "-d" argument.
ACK - thank you for the correction.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org 🍥 chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org: Bug#968344; Package src:pencil2d.
(Sun, 16 Aug 2020 12:24:05 GMT) (full text, mbox, link).
On Thu, Aug 13, 2020 at 12:02:43PM +0100, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> pencil2d could not be built reproducibly.
>
> While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit
> the --utc flag to date(1) so the generated date will depend on the
> build system's current timezone.
Ahah, of course!
I wonder how this haven't come up earlier on but only in the last
upload, but well, thank you for saving me from invastigating this myself
:)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Control: tag -1 pending
Hello,
Bug #968344 in pencil2d reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:
https://salsa.debian.org/debian/pencil2d/-/commit/017f2cdf15ec05228e6f562b8ecaf828bc842238
------------------------------------------------------------------------
d/rules: Fix a reproducibily issue in case of building in different time zones. Thanks to Chris Lamb for debugging the issue. Closes: #968344
Signed-off-by: Mattia Rizzolo <mattia@debian.org>
------------------------------------------------------------------------
(this message was generated automatically)
--
Greetings
https://bugs.debian.org/968344
Added tag(s) pending.
Request was from Mattia Rizzolo <mattia@debian.org>
to 968344-submitter@bugs.debian.org.
(Sun, 16 Aug 2020 12:36:05 GMT) (full text, mbox, link).
Reply sent
to Mattia Rizzolo <mattia@debian.org>:
You have taken responsibility.
(Sun, 16 Aug 2020 12:51:09 GMT) (full text, mbox, link).
Notification sent
to "Chris Lamb" <lamby@debian.org>:
Bug acknowledged by developer.
(Sun, 16 Aug 2020 12:51:09 GMT) (full text, mbox, link).
Source: pencil2d
Source-Version: 0.6.5-2
Done: Mattia Rizzolo <mattia@debian.org>
We believe that the bug you reported is fixed in the latest version of
pencil2d, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 968344@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated pencil2d package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 16 Aug 2020 14:21:56 +0200
Source: pencil2d
Architecture: source
Version: 0.6.5-2
Distribution: unstable
Urgency: medium
Maintainer: Mattia Rizzolo <mattia@debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Closes: 968344
Changes:
pencil2d (0.6.5-2) unstable; urgency=medium
.
* d/rules: Fix a reproducibily issue in case of building in different time
zones. Thanks to Chris Lamb for debugging the issue. Closes: #968344
Checksums-Sha1:
386b9c776373bc25cee5406a7c7f0c7e1b4b0f26 1903 pencil2d_0.6.5-2.dsc
a597cdee603766dedb44560e0c4bade0789998a7 9576 pencil2d_0.6.5-2.debian.tar.xz
5aa05b38082f75c8ae644b89a3f331fbd596f2da 11278 pencil2d_0.6.5-2_amd64.buildinfo
Checksums-Sha256:
2a32f9ba5d058e76b6cf05af79ef2dd7396741ad53b9de863a22119d56a4a3d2 1903 pencil2d_0.6.5-2.dsc
302800392afa25f17309363211c6d0a7b375930c4e4f688cfb12b5cc9ac2cda1 9576 pencil2d_0.6.5-2.debian.tar.xz
a5ce823a6732294ea637e6fcb16956c0c2dfecd88846ec872a13080b313264c5 11278 pencil2d_0.6.5-2_amd64.buildinfo
Files:
e5714b7589b3beaa431807d4b7e182d5 1903 graphics optional pencil2d_0.6.5-2.dsc
c3bec38772dfcb511edf75e64cadac38 9576 graphics optional pencil2d_0.6.5-2.debian.tar.xz
03fd9691b3a7946e36f26402645a8611 11278 graphics optional pencil2d_0.6.5-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAl85J5gACgkQCBa54Yx2
K61G/A//W968D4pQ0nl2l086lABJM+etDU1zBpibh9Sf7wNDhVpqJeuMEiwcq6pS
JYoYTIwgvgkPyWVHfjhXRORCJ1F2+E50ofGkpzT0LXnHd0lRr88T8dBSBXSR2jJm
9SqqKfKpMw2+he2EFFX6lQJxPT41yLYOn5jjO104pjngbOdVrghvRZgC4Pedq4x4
kmtqFbJutqS/LhZXX8BuwQ5RWNPAGybrElnDwmDKiatrv63wRYJrlE0f6Mtlg3Qp
n4F6+NalUfGwXfZ1G9h+G5V31V8e2roQACfn+1f4219M/u3WWxggNTTkOYnG2e3+
9xv6mYWsglAqvG+oMPSahZeRcX4OPRMpYoTU3lbQTlHYhhQi7kEjQo13DiPMLGDy
XlRX0DvsTUFWnmZthxBs90+DtZau+do5OBhTnIX+RoHJ7gg6HU7wCyjHkdWtiiEc
sKYMEDxzKypdP7qz9+vMejPO9GWC1UK2oj0DybxeyQT3iOyK4HNzeLJ1XjqDwMyI
GRJ4EBEHLgpsLEa9TQiugh+tN9VdyazOT6xGAuESL3E7WJYws6Fk9z6kBq2mWMAE
xakBbITilDiyDiUlPtuKGjGIBzlhGUDYGpgiFK7k29QOLVHk2lb4om/BCUhZwZi0
40e2SWTELR2tSh9mH48l+VOVQ7WWhh1AU+k46E8iNL+bBxBVBCE=
=uDCX
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Mon, 14 Sep 2020 07:26:10 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.