968124">

Debian Bug report logs - #968124
diffoscope: FTBFS with fpc 3.2.0

version graph

Package: src:diffoscope; Maintainer for src:diffoscope is Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>;

Reported by: Graham Inggs <ginggs@debian.org>

Date: Sun, 9 Aug 2020 12:06:01 UTC

Severity: serious

Tags: ftbfs, sid

Found in version diffoscope/155

Fixed in version diffoscope/156

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, pkg-pascal-devel@alioth-lists.debian.net, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#968124; Package src:diffoscope. (Sun, 09 Aug 2020 12:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Graham Inggs <ginggs@debian.org>:
New Bug report received and forwarded. Copy sent to pkg-pascal-devel@alioth-lists.debian.net, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Sun, 09 Aug 2020 12:06:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, def test_identification(file1): > > assert isinstance(file1, PpuFile) > E AssertionError: assert False > E + where False = isinstance(< 'diffoscope.comparators.binary.FilesystemFile'> > /build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>, > PpuFile) > > file1 = < > /build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu> > > tests/comparators/test_ppu.py:51: AssertionError > __________________________________ test_diff ___________________________________ > > differences = [] > > @skip_unless_tool_is_at_least("ppudump", ppudump_version, "3.0.0") > def test_diff(differences): > expected_diff = get_data("ppu_expected_diff") > > assert differences[0].unified_diff == expected_diff > E IndexError: list index out of range > > differences = [] > expected_diff = ('@@ -15,15 +15,15 @@\n' > ' Definitions stored : 121\n' > ' Symbols stored : 398\n' > ' \n' > ' Interface section\n' > ' ------------------\n' > ' Module Name: CastleGenericLists\n' > ' \n' > '-Source file 1 : castlegenericlists.pas 2016/02/17 15:03:46\n' > '+Source file 1 : castlegenericlists.pas 2016/02/17 15:04:53\n' ">reply):

From: Graham Inggs <ginggs@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: diffoscope: FTBFS with fpc 3.2.0
Date: Sun, 9 Aug 2020 14:02:32 +0200
Source: diffoscope
Version: 155
Severity: serious
Tags: ftbfs sid
X-Debbugs-CC: pkg-pascal-devel@alioth-lists.debian.net

Hi Maintainer

As can be seen on reproducible builds [1], this package FTBFS since
the upload of fpc 3.2.0+dfsg-5 to unstable.

I've copied what I hope is the relevant part of the log below.

Regards
Graham


[1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope.html


=================================== FAILURES ===================================
_____________________________ test_identification ______________________________

file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

    @skip_unless_tools_exist("ppudump")
    def test_identification(file1):
>       assert isinstance(file1, PpuFile)
E       AssertionError: assert False
E        +  where False = isinstance(<<class
'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>,
PpuFile)

file1      = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

tests/comparators/test_ppu.py:51: AssertionError
__________________________________ test_diff ___________________________________

differences = []

    @skip_unless_tool_is_at_least("ppudump", ppudump_version, "3.0.0")
    def test_diff(differences):
        expected_diff = get_data("ppu_expected_diff")
>       assert differences[0].unified_diff == expected_diff
E       IndexError: list index out of range

differences = []
expected_diff = ('@@ -15,15 +15,15 @@\n'
 ' Definitions stored      : 121\n'
 ' Symbols stored          : 398\n'
 ' \n'
 ' Interface section\n'
 ' ------------------\n'
 ' Module Name: CastleGenericLists\n'
 ' \n'
 '-Source file 1 : castlegenericlists.pas 2016/02/17 15:03:46\n'
 '+Source file 1 : castlegenericlists.pas 2016/02/17 15:04:53\n'
 ' Uses unit: System (Crc: 09C1FD4E, IntfcCrc: 3A093E2F, IndCrc: FEDD6E0A)\n'
 ' Uses unit: objpas (Crc: 663BC437, IntfcCrc: CA7886A2, IndCrc: 64D020AC)\n'
 ' Uses unit: fgl (Crc: C38E0A5A, IntfcCrc: 470D2834, IndCrc: 0764D076)\n'
 ' Link unit object file: castlegenericlists.o (static )\n'
 ' DerefMapsize: 2\n'
 ' DerefMap[0] = FGL\n'
 ' DerefMap[1] = SYSTEM\n')

tests/comparators/test_ppu.py:67: IndexError
__________________________ test_compare_non_existing ___________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>
file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

    @skip_unless_tool_is_at_least("ppudump", ppudump_version, "3.0.0")
    def test_compare_non_existing(monkeypatch, file1):
>       assert_non_existing(monkeypatch, file1, has_null_source=False)

file1      = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>

tests/comparators/test_ppu.py:72:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>
fixture = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
has_null_source = False, has_details = True

    def assert_non_existing(
        monkeypatch, fixture, has_null_source=True, has_details=True
    ):
        monkeypatch.setattr(Config(), "new_file", True)
        assert Config().new_file, "Did not get patched"

        difference = fixture.compare(MissingFile("/nonexisting", fixture))

        assert difference.source2 == "/nonexisting"
>       assert not has_details or len(difference.details) > 0
E       AssertionError

difference = <Difference
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu
-- /nonexisting []>
fixture    = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
has_details = True
has_null_source = False
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>

tests/utils/nonexisting.py:35: AssertionError



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#968124; Package src:diffoscope. (Tue, 11 Aug 2020 11:03:03 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 11 Aug 2020 11:03:03 GMT) (full text, mbox, link).


Message #10 received at 968124@bugs.debian.org (full text, mbox, wrote: > tags 968124 + pending > thanks > > Hi Graham, > > > As can be seen on reproducible builds [1], this package FTBFS since > > the upload of fpc 3.2.0+dfsg-5 to unstable. > > Thanks, very useful bug report. I've fixed this in: > > https://salsa.debian.org/reproducible-builds/diffoscope/commit/d0f0b21559ab162164c25c4b76dcfdeac92b8487 > > … but also made a few related changes while I was in this rather > unloved part of the code (eg. 8ce4515f1). > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org 🍥 chris-lamb.co.uk > `- > > ">reply):

From: "Chris Lamb" <lamby@debian.org>
To: "Graham Inggs" <ginggs@debian.org>, 968124@bugs.debian.org
Subject: Re: Bug#968124: diffoscope: FTBFS with fpc 3.2.0
Date: Tue, 11 Aug 2020 12:01:31 +0100
tags 968124 + pending
thanks

Hi Graham,

> As can be seen on reproducible builds [1], this package FTBFS since
> the upload of fpc 3.2.0+dfsg-5 to unstable.

Thanks, very useful bug report. I've fixed this in:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/d0f0b21559ab162164c25c4b76dcfdeac92b8487

 … but also made a few related changes while I was in this rather
unloved part of the code (eg. 8ce4515f1).


Regards,

--
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-



Added tag(s) pending. Request was from "Chris Lamb" <lamby@debian.org> to control@bugs.debian.org. (Tue, 11 Aug 2020 11:03:05 GMT) (full text, mbox, link).


Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Fri, 14 Aug 2020 09:21:03 GMT) (full text, mbox, link).


Notification sent to Graham Inggs <ginggs@debian.org>:
Bug acknowledged by developer. (Fri, 14 Aug 2020 09:21:03 GMT) (full text, mbox, link).


Message #17 received at 968124-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 968124-close@bugs.debian.org
Subject: Bug#968124: fixed in diffoscope 156
Date: Fri, 14 Aug 2020 09:18:55 +0000
Source: diffoscope
Source-Version: 156
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 968124@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 14 Aug 2020 10:04:26 +0100
Source: diffoscope
Built-For-Profiles: nocheck
Architecture: source
Version: 156
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 968124
Changes:
 diffoscope (156) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Update PPU tests for compatibility with Free Pascal versions 3.2.0 or
     greater. (Closes: #968124)
   * Emit a debug-level logging message when our ppudump(1) version does not
     match file header.
   * Add and use an assert_diff helper that loads and compares a fixture output
     to avoid a bunch of test boilerplate.
 .
   [ Frazer Clews ]
   * Apply some pylint suggestions to the codebase.
Checksums-Sha1:
 0fa7997dfb12330fd4c8b4991e3309a631bc98d2 4828 diffoscope_156.dsc
 faa32f8670e213b9f2eaaa3b69a5b7ac62e816c6 978996 diffoscope_156.tar.xz
 b6343b9ffbcbf83bc2c10f37422fd86f7c346d95 6182 diffoscope_156_amd64.buildinfo
Checksums-Sha256:
 340a3b722ed74709890ebefcc3ba08025a365779f2e2b3831b30d041a689cfe2 4828 diffoscope_156.dsc
 1e3ced9e0682047b1b57d8bf2a93934bc7e036b1b880be5d134b1f121e68420f 978996 diffoscope_156.tar.xz
 03b3df8b1635d9e8f6bb218a46582f1548aa3375069cd74e49173758fb9c7f81 6182 diffoscope_156_amd64.buildinfo
Files:
 c63139f00f2128ecd04f15083b001c72 4828 devel optional diffoscope_156.dsc
 ba1efcbcbfbe0628379d374f4fe10c6f 978996 devel optional diffoscope_156.tar.xz
 65add9eb01423586702dadfde0e67d0c 6182 devel optional diffoscope_156_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl82VLgACgkQHpU+J9Qx
HljAwg//bZl1XSVQ3cXs265+3oPXH1agAva0kaQuxkBcyMbal9R4xc1nLwmoPEbc
DZtpOdB5xE6s2pJIdRFUbUypsdBw/W9AgBfSOQFbVMZn/MGY9sWO4OlD47UWoFs2
wvY+CkLj3wRo0Xd5ro99BuGdYBjk9VFWfRByX3jXj/qQdOd9/VBoCBidx57Eo8kF
QNqZpYla9kJ9PUn/o/GuvBRKXKpvjBjC6nzNR6dBjpBP2KaDn3D/OPUywg0cjdp6
HhOZb++/3+3QWMQbc6VLhaxGRCNp1ESvqeOMfySU9lBPKppI25hoUrZDyPU2C2xc
0eRKN5Q4kkFzW5YG1f/z7ddKJV9laBoDHZqjjRRSAfpMXKfHBgfXBGog9OcHloc1
VBUF90ugDoGweOeJELHxuc5UBlfy3CxR3qvoHmy6cIvBNSMCqyRl2qA6Rw/JyyXW
Aic8ADXf1eRLLOpBGhaPW8WEfOj8A1qYrfAYiTvl9GVHX2892PNlJLIMhGpuQQbu
D3NVPj3Vx2UKOafLCFbMHwBEVYYCTlAtwER9dx0/BP2zdNX41DHUAXfc+LGGbSQQ
LK4pbRmc3wwtk5Fq2lieFX7436YoNVx9ZaHVJxLHiRcZqAHXQcphT//7uQGrFe4O
MFI4kYI/J8+SujeBg5Va7rS3gkhFliW0ayLcbd+cbz0e9+/9cxQ=
=6ncy
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 10 Oct 2020 07:25:03 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 06:44:10 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.