961830">

Debian Bug report logs - #961830
systemtap: embeds build date in generated PDF files

version graph

Package: src:systemtap; Maintainer for src:systemtap is Emanuele Rocca <ema@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Fri, 29 May 2020 23:30:02 UTC

Severity: normal

Tags: patch

Fixed in version systemtap/4.3-3

Done: Emanuele Rocca <ema@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Emanuele Rocca <ema@debian.org>:
Bug#961830; Package src:systemtap. (Fri, 29 May 2020 23:30:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Emanuele Rocca <ema@debian.org>. (Fri, 29 May 2020 23:30:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: systemtap: embeds build date in generated PDF files
Date: Fri, 29 May 2020 16:27:11 -0700
[Message part 1 (text/plain, inline)]
Source: systemtap
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The generated PDF files included in the systemtap-doc package include
dates based on the build time, which breaks reproducible builds.

The attached patch enables use of SOURCE_DATE_EPOCH, by setting
FORCE_SOURCE_DATE=1, which texlive requires in order to respect
SOURCE_DATE_EPOCH.

  https://reproducible-builds.org/docs/source-date-epoch/

live well,
  vagrant

[0001-Build-.pdf-files-with-reproducible-date.patch (text/x-diff, inline)]
From d69d87a871443123bd9431e83ec2b9b35472dea3 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 29 May 2020 22:51:16 +0000
Subject: [PATCH] Build .pdf files with reproducible date.

Add "export FORCE_SOURCE_DATE=1" from debian/rules to make texlive
respect the SOURCE_DATE_EPOCH variable when generating .pdf files.

  https://reproducible-builds.org/docs/source-date-epoch/
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index f9a71f62f..38fcfad8e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -24,6 +24,8 @@ ifeq (,$(filter systemtap-runtime,$(shell dh_listpackages -a)))
   sdt_only := yes
 endif
 
+export FORCE_SOURCE_DATE=1
+
 %:
 	dh $@ --with autoreconf
 
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#961830; Package src:systemtap. (Sat, 15 Aug 2020 12:51:03 GMT) (full text, mbox, link).


Acknowledgement sent to Emanuele Rocca <ema@debian.org>:
Extra info received and forwarded to list. (Sat, 15 Aug 2020 12:51:03 GMT) (full text, mbox, link).


Message #10 received at 961830@bugs.debian.org (full text, mbox, reply):

From: Emanuele Rocca <ema@debian.org>
To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 961830@bugs.debian.org
Subject: Re: Bug#961830: systemtap: embeds build date in generated PDF files
Date: Sat, 15 Aug 2020 14:48:19 +0200
Hi,

On 29/05 04:27, Vagrant Cascadian wrote:
> The generated PDF files included in the systemtap-doc package include
> dates based on the build time, which breaks reproducible builds.
> 
> The attached patch enables use of SOURCE_DATE_EPOCH, by setting
> FORCE_SOURCE_DATE=1, which texlive requires in order to respect
> SOURCE_DATE_EPOCH.
> 
>   https://reproducible-builds.org/docs/source-date-epoch/

Thanks for sending this patch! I've applied it and tried running a
reprotest, but unfortunately the build still does not seem to be
reproducible. How have you tested the change?

Thanks,
  Emanuele



Information forwarded to debian-bugs-dist@lists.debian.org, Emanuele Rocca <ema@debian.org>:
Bug#961830; Package src:systemtap. (Sat, 15 Aug 2020 20:33:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Emanuele Rocca <ema@debian.org>. (Sat, 15 Aug 2020 20:33:03 GMT) (full text, mbox, link).


Message #15 received at 961830@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Emanuele Rocca <ema@debian.org>, 961830@bugs.debian.org
Subject: Re: Bug#961830: systemtap: embeds build date in generated PDF files
Date: Sat, 15 Aug 2020 13:29:56 -0700
[Message part 1 (text/plain, inline)]
On 2020-08-15, Emanuele Rocca wrote:
> On 29/05 04:27, Vagrant Cascadian wrote:
>> The generated PDF files included in the systemtap-doc package include
>> dates based on the build time, which breaks reproducible builds.
>> 
>> The attached patch enables use of SOURCE_DATE_EPOCH, by setting
>> FORCE_SOURCE_DATE=1, which texlive requires in order to respect
>> SOURCE_DATE_EPOCH.
>> 
>>   https://reproducible-builds.org/docs/source-date-epoch/
>
> Thanks for sending this patch! I've applied it and tried running a
> reprotest, but unfortunately the build still does not seem to be
> reproducible. How have you tested the change?

I did test the change, and just tested again both with and without the
patch to confirm against the newer version. The change did fix the dates
embedded in PDFs for me.

Unfortunately there are additional issues that affect the
reproducibility of the built .html files, so fixing the PDF issue alone
will not make the package fully reproducible; I should have mentioned
that in my initial bug report.


Fixing this issue does reduce the reproducibility diffoscope output a
bit, making it easier to debug remaining issues, so would still be nice
to apply the patch to debian/rules to fix the dates in .pdf files.


Thanks for maintaining systemtap and sorry for the confusion!


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Reply sent to Emanuele Rocca <ema@debian.org>:
You have taken responsibility. (Thu, 15 Oct 2020 13:39:06 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Thu, 15 Oct 2020 13:39:06 GMT) (full text, mbox, link).


Message #20 received at 961830-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 961830-close@bugs.debian.org
Subject: Bug#961830: fixed in systemtap 4.3-3
Date: Thu, 15 Oct 2020 13:36:53 +0000
Source: systemtap
Source-Version: 4.3-3
Done: Emanuele Rocca <ema@debian.org>

We believe that the bug you reported is fixed in the latest version of
systemtap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 961830@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emanuele Rocca <ema@debian.org> (supplier of updated systemtap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 15 Oct 2020 11:06:19 +0200
Source: systemtap
Architecture: source
Version: 4.3-3
Distribution: unstable
Urgency: high
Maintainer: Emanuele Rocca <ema@debian.org>
Changed-By: Emanuele Rocca <ema@debian.org>
Closes: 961830 969968 972247
Changes:
 systemtap (4.3-3) unstable; urgency=high
 .
   * Add debian/patches/mmap_sem-transition.patch to fix stap error: ‘struct
     mm_struct’ has no member named ‘mmap_sem’. (Closes: #972247)
   * Add debian/patches/vermagic-hiding.patch to fix stap error: 'This header
     can be included from kernel/module.c or *.mod.c only'
   * Set architecture of binary packages to linux-any. (Closes: #969968)
   * Add FORCE_SOURCE_DATE to debian/rules. (Closes: #961830)
   * Use salsa-ci-team/pipeline/raw/master/recipes/debian.yml instead of
     salsa-ci-team/pipeline/raw/master/salsa-ci.yml in our own salsa-ci.yml
     configuration to fix CI pipeline error: undefined dependency:
     extract-source.
Checksums-Sha1:
 94e5c7657420aa826318d330208e7675521b9f02 3010 systemtap_4.3-3.dsc
 2068415290a2a759e1f57a4bd54d604e2c5a53d9 31612 systemtap_4.3-3.debian.tar.xz
 d77a522e334b89a9ba3b28575fa31adcc4d785bd 12176 systemtap_4.3-3_amd64.buildinfo
Checksums-Sha256:
 c24ee69fecb6b6fe3fe5a526ca09213d1ff76718303fcc50e3c29974f19f5e19 3010 systemtap_4.3-3.dsc
 cb768fe0dc61e44d5c76a6e6069952b3037915f4a6ffbb82aa2a729ef40ab34f 31612 systemtap_4.3-3.debian.tar.xz
 50ede593cf2399ce1f06158dee39c331312128875f6d72655ebe8100639278ee 12176 systemtap_4.3-3_amd64.buildinfo
Files:
 2a69030d66618359adc6b1924e434cab 3010 devel optional systemtap_4.3-3.dsc
 7949de3d38dd5f0ac240d00e005cde34 31612 devel optional systemtap_4.3-3.debian.tar.xz
 297be8eb548aa11397e190a115e12884 12176 devel optional systemtap_4.3-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElUWWlhkoHBf/rFiR1QhaB1D9t6MFAl+ITNoACgkQ1QhaB1D9
t6NMwg//YzYvXUuHi5Aq6G+EMV8tmiebq2JpAPmVG+QeAJe2U4+xVeXY0dKzvfx/
YB6/ixpl6OcCfE9Zxini18vp9WvH7ZCqYJ9xiEZRkE2i+KSb6ld/PoRGAQQesXcN
n8MK3V5/eJ46DgmzQU+1OMJZ6txgNW6ji8afhri7L/3+7ufyeINynbevfVqatO9F
Mzlx5K1XMw9mA6MVfTHIpUV87zlTEdG7x4V2WxsOVVe/EYqb+zlUeEslpUaX48G5
WBxbpWrq/qCOPvFVEGJiOsjZDluvGEdWF/S8xaidqXGVoSiwTrBe+Ot3EHnVXsIC
5jJoBLDHA48zHscViMZcjdbzR9q7ZpKO/7/wTiTc65dibXHetkhsBdYeGcD7FN6m
GbfXN+UU5FZ8B4MSKAN6wCslCSWjovLwBuwAEKOzhAg6M7H6czTT9lZybFAxB8M4
z6WVxeNXwInrqM0BgjQlhMe2/pmr5DPcqBpJ4JIw/FDhH8+nfU/gMOelUHa1rs+R
LKBadopqGCse1JdLtGD/iC8JBRKXApPIpoh/05JF7qwocBKn4hjrgNWWjBF2shdu
DZQbkRSjMu//l8gZ1AnuoyhiftikMw5HOwnQV+p/OMt2F8ZsiIwQY2kVgGw87bdz
M3iDTLsmeK/1zFYGKC8UzMqe8E4UrKnbGaRg4/or4Ck6ORDRBv0=
=subH
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 13 Jan 2021 07:26:18 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 11:57:13 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.