944694">

Debian Bug report logs - #944694
resource-agents: Fix typo in heartbeat/MailTo

version graph

Package: src:resource-agents; Maintainer for src:resource-agents is Debian HA Maintainers <debian-ha-maintainers@alioth-lists.debian.net>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Thu, 14 Nov 2019 00:12:02 UTC

Severity: normal

Tags: patch

Found in version resource-agents/1:4.4.0-1

Fixed in version resource-agents/1:4.4.0-2

Done: Valentin Vidic <vvidic@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, vagrant@reproducible-builds.org, Debian HA Maintainers <debian-ha-maintainers@lists.alioth.debian.org>:
Bug#944694; Package src:resource-agents. (Thu, 14 Nov 2019 00:12:05 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to vagrant@reproducible-builds.org, Debian HA Maintainers <debian-ha-maintainers@lists.alioth.debian.org>. (Thu, 14 Nov 2019 00:12:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, in the ocf_heartbeat_MailTo.7 manpage depending on the shell, neither > of which are probably the intended value. > > This impacts the reproducibility of the build: > > https://reproducible-builds.org/docs/ > > There is also a merge request submitted if that's easier for you: > > https://salsa.debian.org/ha-team/resource-agents/merge_requests/1 > > > live well, > vagrant > &In-Reply-To=<87eeybjpau.fsf@yucca>">reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: resource-agents: Fix typo in heartbeat/MailTo
Date: Wed, 13 Nov 2019 16:04:57 -0800
[Message part 1 (text/plain, inline)]
Source: resource-agents
Version: 1:4.4.0-1
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Attached is a patch to fix a typo in heartbeat/MailTo that behaves
differently when /bin/sh is bash vs. dash by using curly-braces instead
of square brackets to define the variable.

Without this either "0" or "$[OCF_RESKEY_email_default]" is embedded
in the ocf_heartbeat_MailTo.7 manpage depending on the shell, neither
of which are probably the intended value.

This impacts the reproducibility of the build:

  https://reproducible-builds.org/docs/

There is also a merge request submitted if that's easier for you:

  https://salsa.debian.org/ha-team/resource-agents/merge_requests/1


live well,
  vagrant

[0001-Fix-typo-in-heartbeat-MailTo-that-behaves-differentl.patch (text/x-diff, inline)]
From 2b003a7b5f0a0194adaeee04604dafa05a0132fc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 13 Nov 2019 15:49:29 -0800
Subject: [PATCH] Fix typo in heartbeat/MailTo that behaves differently when
 /bin/sh is bash vs. dash by using curly-braces instead of square brackets to
 define the variable.

Without this either "0" or "$[OCF_RESKEY_email_default]" is embedded
in the ocf_heartbeat_MailTo.7 manpage depending on the shell, neither
of which are probably the intended value.

This impacts the reproducibility of the build:

  https://reproducible-builds.org/docs/
---
 debian/patches/series         |  1 +
 debian/patches/typo-in-mailto | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 debian/patches/typo-in-mailto

diff --git a/debian/patches/series b/debian/patches/series
index f58907b..fc8054b 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -7,3 +7,4 @@ gitignore.patch
 reproducible.patch
 var-run.patch
 mysql-exit-code.patch
+typo-in-mailto
diff --git a/debian/patches/typo-in-mailto b/debian/patches/typo-in-mailto
new file mode 100644
index 0000000..44c07e5
--- /dev/null
+++ b/debian/patches/typo-in-mailto
@@ -0,0 +1,26 @@
+From: Vagrant Cascadian <vagrant@reproducible-builds.org>
+
+Fix typo that behaves differently when /bin/sh is bash vs. dash by
+using curly-braces instead of square brackets to define the variable.
+
+Without this either "0" or "$[OCF_RESKEY_email_default]" is embedded
+in the ocf_heartbeat_MailTo.7 manpage depending on the shell, neither
+of which are probably the intended value.
+
+This impacts the reproducibility of the build:
+
+  https://reproducible-builds.org/docs/
+
+Index: resource-agents/heartbeat/MailTo
+===================================================================
+--- resource-agents.orig/heartbeat/MailTo
++++ resource-agents/heartbeat/MailTo
+@@ -67,7 +67,7 @@ a takeover occurs.
+ The email address of sysadmin.
+ </longdesc>
+ <shortdesc lang="en">Email address</shortdesc>
+-<content type="string" default="$[OCF_RESKEY_email_default]" />
++<content type="string" default="${OCF_RESKEY_email_default}" />
+ </parameter>
+ 
+ <parameter name="subject" unique="0">
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Reply sent to Valentin Vidic <vvidic@debian.org>:
You have taken responsibility. (Sat, 16 Nov 2019 11:15:04 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sat, 16 Nov 2019 11:15:04 GMT) (full text, mbox, link).


Message #10 received at 944694-close@bugs.debian.org (full text, mbox, reply):

From: Valentin Vidic <vvidic@debian.org>
To: 944694-close@bugs.debian.org
Subject: Bug#944694: fixed in resource-agents 1:4.4.0-2
Date: Sat, 16 Nov 2019 11:13:11 +0000
Source: resource-agents
Source-Version: 1:4.4.0-2

We believe that the bug you reported is fixed in the latest version of
resource-agents, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 944694@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Valentin Vidic <vvidic@debian.org> (supplier of updated resource-agents package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 16 Nov 2019 10:47:46 +0100
Source: resource-agents
Architecture: source
Version: 1:4.4.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian HA Maintainers <debian-ha-maintainers@lists.alioth.debian.org>
Changed-By: Valentin Vidic <vvidic@debian.org>
Closes: 944694
Changes:
 resource-agents (1:4.4.0-2) unstable; urgency=medium
 .
   * debian/patches: fix shell expansion in MailTo (Closes: #944694)
   * debian/resource-agents.lintian-overrides: cleanup
Checksums-Sha1:
 4ed12881dd7d2d863f5fd4475c4977b13aa6bf67 2720 resource-agents_4.4.0-2.dsc
 b81e3da3b0a9d15dec849f4ba41306e846da36a5 21024 resource-agents_4.4.0-2.debian.tar.xz
 148c3821fb0467a9f23cd9fb86fa9afb5e44900a 7121 resource-agents_4.4.0-2_source.buildinfo
Checksums-Sha256:
 1978843631e5141aef22f20c22f20d91c97c7ed46e8d89fb24e207637e4ad0a6 2720 resource-agents_4.4.0-2.dsc
 6d0d171aa33a7b27f931799c5a45c76505a2090ec78ebc9fb7abf7dbd5031a3a 21024 resource-agents_4.4.0-2.debian.tar.xz
 f24c9c8b52d1fa9e4253207d89dbe9027d0db507430d59be8b757e30d8b46bda 7121 resource-agents_4.4.0-2_source.buildinfo
Files:
 797ba5a797c7d462c2d62679792614b7 2720 admin optional resource-agents_4.4.0-2.dsc
 500ada4c7a3d297fc2ec3608702f4f5c 21024 admin optional resource-agents_4.4.0-2.debian.tar.xz
 0569f606b483b2f630455a124856ccb2 7121 admin optional resource-agents_4.4.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEExaW53cM9k/u2PWfIMofYmpfNqHsFAl3Py8gSHHZ2aWRpY0Bk
ZWJpYW4ub3JnAAoJEDKH2JqXzah76vwQALose0AjlCh1/fgRfQLHuxNzd5Y7SLMZ
MCo85/NcvASCJigDRZbj3wcZso+RokG40cvljLTtQ4CEnD8v0qoJ1hKgdohBiDY8
4P+HRBQZu1I7Fmeu0v1m3gFY54ZwcmRx5/KU9VDYfcNSovpikibS7h0mb+z2sGsn
APsToF7CmxACKkwyc4HyWPzwMzydnQm4wBbvIBGiDTnC9tfqA0dAyk83uCf3d7Kv
PY0qHU1YXvw2ca5hO+nZqouwI5fZykUGck7ff2sSPTw3WjkOPBJHGj2WFYSReuxa
2f7NfhFRzJTJJjqKRkYpKIu3/E76EMFy1l3Ala+l2gzHE8r+flunT/suvCBF80m0
1o9tFuFRnPRUxgy5Ac7G9bgCjY4w2NhawoeQylNhul2BdfeEoj0fw1viUN3B54Py
ytkWzmchMSaYMlU5aN7HInzjGBq20abvwyIx0Q6lUxXRytFtPmTWovi82W10xQOR
eI7JqXh7gQZXYfnchiPYNJ3sxvVoTEsakhmspHAi5kIKjj0FWjtDb0xhx0Yto0lw
OGs/nrKBz4JR61vk2CvT2tPere6Szt40fhpoos/P9iw6pBdsLGqkVNNlR+VhUfyL
zN4/tJYITk28fTDAdTPIdFLExGcqXjEe5pbUtLFqNy9eIgyT3FBdhy8J4Xd2sTVj
jw7DW/z1BDcz
=XMhu
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 16 Dec 2019 07:30:43 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 12:38:14 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.