944691">

Debian Bug report logs - #944691
dh: set umask 022 for all operations

version graph

Package: debhelper; Maintainer for debhelper is Debhelper Maintainers <debhelper@packages.debian.org>; Source for debhelper is src:debhelper (PTS, buildd, popcon).

Reported by: Thorsten Glaser <tg@mirbsd.de>

Date: Wed, 13 Nov 2019 21:15:02 UTC

Severity: wishlist

Found in version debhelper/12.7.1

Fixed in version debhelper/12.8

Done: Niels Thykier <niels@thykier.net>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, t.glaser@tarent.de, Debhelper Maintainers <debhelper@packages.debian.org>:
Bug#944691; Package debhelper. (Wed, 13 Nov 2019 21:15:07 GMT) (full text, mbox, link).


Acknowledgement sent to Thorsten Glaser <tg@mirbsd.de>:
New Bug report received and forwarded. Copy sent to t.glaser@tarent.de, Debhelper Maintainers <debhelper@packages.debian.org>. (Wed, 13 Nov 2019 21:15:07 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, > For some reason the desired effect is not observed, although > I had some debugging echos in debian/rwrap earlier whose output > was seen during a local build. > > As there’s a general recommendation of using the dh wrapper > nowadays anyway, please (feature request, wishlist severity) > make it reset umask. > > debian/rules has: > > %: > dh $@ --buildsystem=cmake > > I could probably change that to… > > %: > umask 022 && exec dh $@ --buildsystem=cmake > > … but everyone needs to do that then, and this is a good example > of harmonisation potential. > > -- System Information: > Debian Release: bullseye/sid > APT prefers buildd-unstable > APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental') > Architecture: amd64 (x86_64) > Foreign Architectures: i386 > > Kernel: Linux 5.3.0-1-amd64 (SMP w/2 CPU cores) > Kernel taint flags: TAINT_CRAP > Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8) > Shell: /bin/sh linked to /bin/lksh > Init: sysvinit (via /sbin/init) > > Versions of packages debhelper depends on: > ii autotools-dev 20180224.1 > ii dh-autoreconf 19 > ii dh-strip-nondeterminism 1.6.2-1 > ii dpkg 1.19.7 &subject=Re: dh: set umask 022 for all operations">reply):

From: Thorsten Glaser <tg@mirbsd.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: dh: set umask 022 for all operations
Date: Wed, 13 Nov 2019 22:13:23 +0100
Package: debhelper
Version: 12.7.1
Severity: wishlist

I’ve recently gained a build reproducibility error in src:musescore where
cmake is used to first copy a few files around, generate some, and then
create a PKZIP archive from them using its built-in archiver. The files
in that archive were different in permissions.

I’ve tried setting the umask globally by doing this:

• add “SHELL:=$(abspath debian/rwrap)” to debian/rules
• create debian/rwrap (executable) with the following content:

	tglase@tglase:~/Projekte/musescore $ cat debian/rwrap 
	#!/bin/lksh
	# ${SHELL} wrapper to fix the umask
	
	umask 022
	eval "$2"

For some reason the desired effect is not observed, although
I had some debugging echos in debian/rwrap earlier whose output
was seen during a local build.

As there’s a general recommendation of using the dh wrapper
nowadays anyway, please (feature request, wishlist severity)
make it reset umask.

debian/rules has:

	%:
		dh $@ --buildsystem=cmake

I could probably change that to…

	%:
		umask 022 && exec dh $@ --buildsystem=cmake

… but everyone needs to do that then, and this is a good example
of harmonisation potential.

-- System Information:
Debian Release: bullseye/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_CRAP
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)

Versions of packages debhelper depends on:
ii  autotools-dev            20180224.1
ii  dh-autoreconf            19
ii  dh-strip-nondeterminism  1.6.2-1
ii  dpkg                     1.19.7
ii  dpkg-dev                 1.19.7
ii  dwz                      0.13-2
ii  file                     1:5.37-6
ii  libdebhelper-perl        12.7.1
ii  libdpkg-perl             1.19.7
ii  man-db                   2.9.0-1
ii  perl                     5.30.0-9
ii  po-debconf               1.0.21

debhelper recommends no packages.

Versions of packages debhelper suggests:
pn  dh-make  <none>

-- no debconf information

Added indication that bug 944691 blocks 935846 Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Wed, 13 Nov 2019 21:24:04 GMT) (full text, mbox, link).


Added tag(s) pending. Request was from Niels Thykier <niels@thykier.net> to control@bugs.debian.org. (Fri, 17 Jan 2020 21:00:06 GMT) (full text, mbox, link).


Reply sent to Niels Thykier <niels@thykier.net>:
You have taken responsibility. (Sun, 19 Jan 2020 10:21:14 GMT) (full text, mbox, link).


Notification sent to Thorsten Glaser <tg@mirbsd.de>:
Bug acknowledged by developer. (Sun, 19 Jan 2020 10:21:14 GMT) (full text, mbox, link).


Message #14 received at 944691-close@bugs.debian.org (full text, mbox, targets in debian/rules. This is useful for injecting > commands before or after the command "X" that dh runs. > Note this feature requires compat 10 or later due to > internal limitations in debhelper. Attempts to use > it in compat 9 will trigger an error. Thanks to > Christoph Berg for the suggestion. (Closes: #885994) > * dh: Detect and warn about override and hook targets > for known obsolete commands. In compat 13, this will > be an error instead of a warning. > * dh: Reset umask to 0022 as a consistent default value. > Thanks to Thorsten Glaser for the suggestion. > (Closes: #944691) > * dh_missing: The --fail-missing parameter is now default > in compat 13. Thanks to Mattia Rizzolo for the > suggestion. (Closes: #917368) > * dh_installtmpfiles: New command extracted from > dh_installsystem that will handle tmpfiles.d &References=&In-Reply-To=">reply):

From: Niels Thykier <niels@thykier.net>
To: 944691-close@bugs.debian.org
Subject: Bug#944691: fixed in debhelper 12.8
Date: Sun, 19 Jan 2020 10:19:22 +0000
Source: debhelper
Source-Version: 12.8

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 944691@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 19 Jan 2020 10:02:16 +0000
Source: debhelper
Architecture: source
Version: 12.8
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper@packages.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Closes: 198507 885994 906723 917368 944478 944691
Changes:
 debhelper (12.8) unstable; urgency=medium
 .
   [ Niels Thykier ]
   * Dh_Lib.pm: Simplify internal loggning of which commands
     have been run.  We are no longer interested in whether
     it was an override target or not.
   * dh: Support "execute_before_X" and "execute_after_X"
     targets in debian/rules.  This is useful for injecting
     commands before or after the command "X" that dh runs.
     Note this feature requires compat 10 or later due to
     internal limitations in debhelper.  Attempts to use
     it in compat 9 will trigger an error.  Thanks to
     Christoph Berg for the suggestion.  (Closes: #885994)
   * dh: Detect and warn about override and hook targets
     for known obsolete commands.  In compat 13, this will
     be an error instead of a warning.
   * dh: Reset umask to 0022 as a consistent default value.
     Thanks to Thorsten Glaser for the suggestion.
     (Closes: #944691)
   * dh_missing: The --fail-missing parameter is now default
     in compat 13.  Thanks to Mattia Rizzolo for the
     suggestion.  (Closes: #917368)
   * dh_installtmpfiles: New command extracted from
     dh_installsystem that will handle tmpfiles.d
     configuration.  Thanks to Michael Biebl for the
     suggestion.  (Closes: #944478)
   * dh_installsystemd: In compat 13, this command will no
     longer manage tmpfiles.d configuration.
   * dh: Run dh_installtmpfiles by default in compat 13.
   * Dh_Lib.pm: Emit "error" and "warning" with error and
     warning messages.  Thanks to Paul Wise for the
     suggestion.  (Closes: #906723)
   * Dh_Lib.pm: Support colored output for warnings and
     errors (enabled by default).  The colors can be
     controlled by setting DH_COLORS or DPKG_COLORS.  The
     latter will also affect dpkg-related tools.
     Note: NO_COLOR is respected in the absence of
     DH_COLORS and DPKG_COLORS.
   * Dh_Lib.pm: Support substitution variables in files
     handled by filearray and filedoublearray in compat 13.
     This also applies to executable configuration files.
     As the substitution occurs after splitting the files
     into tokens, it can be used to include spaces in the
     tokens (often file names).  (Closes: #198507)
   * dh_install: Support substitution configuration files.
   * dh_clean: Ditto.
   * dh_installcatalogs: Ditto.
   * dh_installdeb: Ditto (maintscripts only).
   * dh_installdirs: Ditto.
   * dh_installdocs: Ditto.
   * dh_installexamples: Ditto.
   * dh_installinfo: Ditto.
   * dh_installman: Ditto.
   * dh_installwm: Ditto.
   * dh_link: Ditto.
   * dh_missing: Ditto.
   * dh_ucf: Ditto.
   * debian/rules: Remove override for dh_missing as the
     --fail-missing parameter is default now.
 .
   [ Helmut Grohne ]
   * Warn about missing perl-xs-dev for perl_* buildsystems.
Checksums-Sha1:
 d7d6166a4b0adef3ff1fd09d0b8ca162c1c928c0 1835 debhelper_12.8.dsc
 fa9331630bc7414d2af3251c61b7d6bf47758714 517508 debhelper_12.8.tar.xz
 bab5a3ecb0ff79835ce8b8e6bce3c3e42c81cf0b 4578 debhelper_12.8_source.buildinfo
Checksums-Sha256:
 5e586386833e5bc5a8307ba36c4fdb5a3e965756e92ac7a91ca9752a18416fdf 1835 debhelper_12.8.dsc
 8ef5c8eae677b98d826405d0c323df7f74eba7fe4716545abf507235a86e8b5d 517508 debhelper_12.8.tar.xz
 5d07a89fe4f4629dafd22bdd67c678dd40a3551133092975273613ec762d0a7a 4578 debhelper_12.8_source.buildinfo
Files:
 dc997eef9382e8828617e150498b38f4 1835 devel optional debhelper_12.8.dsc
 eafc304b3c69848e204e5eadf41e1f2a 517508 devel optional debhelper_12.8.tar.xz
 25a631399bb0b3d12be2e8a23b663c8b 4578 devel optional debhelper_12.8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAl4kKasSHG5pZWxzQHRo
eWtpZXIubmV0AAoJEKZbeNvmfHqstaUQAJmzBdm6FOaYneMYYIQFEuUWQEk0cSv+
0X72ik2pM8jCLHCJMvfa0fKMAc3KHsIqkeXaPbouuD/StdJCO4dIQI3GL7RNp03A
7z7e2IFi3FKg+9ExYU57JO8faSPWrnn4MVzmS6WlqYvce6A9hL5evqELoK+I8akn
RtWQnu03dzH/xBEdvvA5zVRa65A5uuvNfKy+pODqj6J1mrrz4cO93iqVgN6X7L64
9aGKE3MhkHqNxEoggqwDW2y9bVJCVJAlD4ctrxgmmn3lnOnA8aC4EMsSb3CwAOMb
d76VFpbW7eadxTTlti7HF2apJaP9iXqYUvw58s90ueVYKa18BNC894p/TUKn2LCE
/UsOGai3TZlvFfFlqwssXim3Mmi0kgjF1RAWROhO1/MxwnbjwHsln9R1s6QDwXLN
d+xTKGnBBqtFaKh6ryf18MSQDn/OU5Kuo73jbW4MzWN3IfC5dOIKiV54vWo6u/Hs
iTzeVsd8e5Mi0OPpTuFWuvMVsq4BOmYyyCZcS1k0pohJ9wcZe4387av5JKc7S0Cp
zi3rb/Ydu+8UCIgWFfnRYyKc58NJQPkhEMPIaMlVoRMPPTWCKXGcnlngkx9eHSxR
V66vOKwSDc033KtZuZJSlz1XOdgHPohEkaDb3/V08HaEx+uUCREjYvWV+zVSU6mA
P9MQsz4sOsV0
=cOIK
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 24 Feb 2020 07:32:12 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 11:32:20 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.