918361">

Debian Bug report logs - #918361
node-browserify-lite: unreproducible output order

version graph

Package: node-browserify-lite; Maintainer for node-browserify-lite is Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>; Source for node-browserify-lite is src:node-browserify-lite (PTS, buildd, popcon).

Reported by: "Rebecca N. Palmer" <rebecca_palmer@zoho.com>

Date: Sat, 5 Jan 2019 14:18:02 UTC

Severity: normal

Tags: patch, upstream

Found in version node-browserify-lite/0.5.0-1

Fixed in version node-browserify-lite/0.5.0-2

Done: Bastien Roucariès <rouca@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-builds@alioth-lists.debian.net, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>:
Bug#918361; Package node-browserify-lite. (Sat, 05 Jan 2019 14:18:04 GMT) (full text, mbox, link).


Acknowledgement sent to "Rebecca N. Palmer" <rebecca_palmer@zoho.com>:
New Bug report received and forwarded. Copy sent to reproducible-builds@alioth-lists.debian.net, Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>. (Sat, 05 Jan 2019 14:18:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, wrote: > Package: node-browserify-lite > Version: 0.5.0-1 > Control: tags -1 upstream patch > User: reproducible-builds@lists.alioth.debian.org > Usertags: toolchain randomness > X-Debbugs-Cc: reproducible-builds@alioth-lists.debian.net > > browserify-lite produces its output in a (pseudo)random order: see e.g. > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/theano.html > > This is known to the reproducible builds team as > randomness_in_browserify_lite_output (and I suspect > nondeterminstic_output_from_uglifyjs is actually the same issue). > > It appears to be trivially fixable: > > --- a/index.js > +++ b/index.js > @@ -79,6 +79,7 @@ function renderBundle(options, cb) { > > function render(entrySourcePath, cb) { > var modules = Object.keys(sources); > + modules.sort(); > var aliases = {}; > modules.forEach(function(canonicalSourcePath, index) { > aliases[canonicalSourcePath] = index; > > This has had only limited testing: on graphlib-dot and dagre-d3 (in > theano's debian/missing-sources), it's reproducible between 2 runs on > the same source tree, and its output runs in Firefox without obvious error. > > The bug appears to exist upstream (with the same fix), but I have not > tested this. > > > &References=<54110cef-5c3d-36f7-c083-f2c344dbf18d@zoho.com>&In-Reply-To=<54110cef-5c3d-36f7-c083-f2c344dbf18d@zoho.com>">reply):

From: "Rebecca N. Palmer" <rebecca_palmer@zoho.com>
To: submit@bugs.debian.org
Subject: node-browserify-lite: unreproducible output order
Date: Sat, 5 Jan 2019 14:15:24 +0000
Package: node-browserify-lite
Version: 0.5.0-1
Control: tags -1 upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain randomness
X-Debbugs-Cc: reproducible-builds@alioth-lists.debian.net

browserify-lite produces its output in a (pseudo)random order: see e.g. 
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/theano.html

This is known to the reproducible builds team as 
randomness_in_browserify_lite_output (and I suspect 
nondeterminstic_output_from_uglifyjs is actually the same issue).

It appears to be trivially fixable:

--- a/index.js
+++ b/index.js
@@ -79,6 +79,7 @@ function renderBundle(options, cb) {

   function render(entrySourcePath, cb) {
     var modules = Object.keys(sources);
+    modules.sort();
     var aliases = {};
     modules.forEach(function(canonicalSourcePath, index) {
       aliases[canonicalSourcePath] = index;

This has had only limited testing: on graphlib-dot and dagre-d3 (in 
theano's debian/missing-sources), it's reproducible between 2 runs on 
the same source tree, and its output runs in Firefox without obvious error.

The bug appears to exist upstream (with the same fix), but I have not 
tested this.




Added tag(s) patch and upstream. Request was from "Rebecca N. Palmer" <rebecca_palmer@zoho.com> to submit@bugs.debian.org. (Sat, 05 Jan 2019 14:18:04 GMT) (full text, mbox, link).


Reply sent to Bastien Roucariès <rouca@debian.org>:
You have taken responsibility. (Mon, 07 Jan 2019 23:21:12 GMT) (full text, mbox, link).


Notification sent to "Rebecca N. Palmer" <rebecca_palmer@zoho.com>:
Bug acknowledged by developer. (Mon, 07 Jan 2019 23:21:12 GMT) (full text, mbox, link).


Message #12 received at 918361-close@bugs.debian.org (full text, mbox, Tobias Frost (Closes: #909874). > * Bug fix: "Quoting fixed in autopkgtest 5.2", thanks to Graham Inggs > (Closes: #894929). > * Add running test suite as debci > * Bug fix: "unreproducible output order", thanks to Rebecca N. Palmer > (Closes: #918361). > * Generate example under debci > Checksums-Sha1: > effb389b200546def68910b96423e3fcd2b78cc6 2233 node-browserify-lite_0.5.0-2.dsc > 8ae5c3715b4bc175a53e50c00319347f3d43b51b 5072 node-browserify-lite_0.5.0-2.debian.tar.xz > 543961b9714089c6e8b4ac9cfdc843e8f4ec0762 6953 node-browserify-lite_0.5.0-2_source.buildinfo > Checksums-Sha256: > 32badbe3ba83b94bed9cf95d641e2197eba0033ec07b9566d290f196d866f875 2233 node-browserify-lite_0.5.0-2.dsc > d67c7a0c07973561549ad5ca42857f8b44514f860580056aa7e8b797923f55c4 5072 node-browserify-lite_0.5.0-2.debian.tar.xz &In-Reply-To=">reply):

From: Bastien Roucariès <rouca@debian.org>
To: 918361-close@bugs.debian.org
Subject: Bug#918361: fixed in node-browserify-lite 0.5.0-2
Date: Mon, 07 Jan 2019 23:20:05 +0000
Source: node-browserify-lite
Source-Version: 0.5.0-2

We believe that the bug you reported is fixed in the latest version of
node-browserify-lite, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 918361@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastien Roucariès <rouca@debian.org> (supplier of updated node-browserify-lite package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 07 Jan 2019 15:03:54 +0100
Source: node-browserify-lite
Binary: node-browserify-lite
Architecture: source
Version: 0.5.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Bastien Roucariès <rouca@debian.org>
Description:
 node-browserify-lite - bundle client-side JavaScript using Node.js-style module syntax
Closes: 894929 909874 918361
Changes:
 node-browserify-lite (0.5.0-2) unstable; urgency=medium
 .
   * Move to section javascript
   * Bump compat and policy
   * Add myself as uploader
   * Depends on nodejs >=6. Thus drop nodejs patch.
   * Bug fix: "Updating the node-browserify-lite Uploaders list", thanks to
     Tobias Frost (Closes: #909874).
   * Bug fix: "Quoting fixed in autopkgtest 5.2", thanks to Graham Inggs
     (Closes: #894929).
   * Add running test suite as debci
   * Bug fix: "unreproducible output order", thanks to Rebecca N. Palmer
     (Closes: #918361).
   * Generate example under debci
Checksums-Sha1:
 effb389b200546def68910b96423e3fcd2b78cc6 2233 node-browserify-lite_0.5.0-2.dsc
 8ae5c3715b4bc175a53e50c00319347f3d43b51b 5072 node-browserify-lite_0.5.0-2.debian.tar.xz
 543961b9714089c6e8b4ac9cfdc843e8f4ec0762 6953 node-browserify-lite_0.5.0-2_source.buildinfo
Checksums-Sha256:
 32badbe3ba83b94bed9cf95d641e2197eba0033ec07b9566d290f196d866f875 2233 node-browserify-lite_0.5.0-2.dsc
 d67c7a0c07973561549ad5ca42857f8b44514f860580056aa7e8b797923f55c4 5072 node-browserify-lite_0.5.0-2.debian.tar.xz
 7d84d7df331ff44ecbcb12e536c72d2e3ac2e2e4923db8fafe1e331051cbd282 6953 node-browserify-lite_0.5.0-2_source.buildinfo
Files:
 caae56959c4a45a97ef08acc17979a99 2233 javascript optional node-browserify-lite_0.5.0-2.dsc
 f346b8f5c4c429d87ee5b6d6529c93eb 5072 javascript optional node-browserify-lite_0.5.0-2.debian.tar.xz
 0201b998817b6ea16a8174ae0330c542 6953 javascript optional node-browserify-lite_0.5.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXQGHuUCiRbrXsPVqADoaLapBCF8FAlwz2ikACgkQADoaLapB
CF9rJA/+NC52N+4oYfMEMocvwtDQ9XdAU/44A+4pXn/lfP9KKZNk0sainl1MmJzo
rnGXY9ZYOt+qIreDv6tZfnchtMhQml4OpggeXnvDXyYGMS6h1IX+fp8Z1LGxvpRY
mopTiuBmmW53LoNtgw+syKek1ia0XDhCsBX/2leRbEnOq2l+svyi7dahB+VpYDqi
7ltbPdEFhnWveOYfHBtErxEoMrk38alBhGKTpPtUmFKZZHeFlU16mzCZeskEqb/S
GDWBpLKxtIZ3MWWcjx/iXKwhsl0pOPbejI1PF5mN9orHqehbaySVse7wrMZfN1+m
yN4KoX7eRihqVLgFzFRGZvZDid9chX83upgln8TtqBYuFpGeGnIq+dEyADw/XFfj
rTabDbP1yZiBYgdkx449qg5MfEDnZw3ScnJoIFlhF1ZfN57pdfP6pmjAT3i73xR8
B7JRgPDaVroym/XlHUEVyzkzjOr3toY8qYqcgo/ij/TRXxejdNdzcvmvOSs/hBhU
I3u1WF67uSgQ/WvajKlRMmU0nhgqfw4mEDtVxUfdBNFmZWaBr7sGC0coPpgciqlE
bt4RWn8q0lYK7e8wA23TOL+3QPVYPswZwSyafaDVIBAxIU0OtVn4+EpgSK1I+sdD
QPHscN+qXGUX97AOGAMJAOLlaslth5IRdBirZ/IK+9vQu+5mC6o=
=6ARh
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 05 Feb 2019 07:32:03 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 06:47:12 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.