917773">

Debian Bug report logs - #917773
shadow: doesn't respect SOURCE_DATE_EPOCH

version graph

Package: src:shadow; Maintainer for src:shadow is Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>;

Reported by: Johannes 'josch' Schauer <josch@debian.org>

Date: Sun, 30 Dec 2018 01:03:02 UTC

Severity: normal

Tags: fixed-upstream, patch

Fixed in version shadow/1:4.7-1

Done: Bálint Réczey <balint@balintreczey.hu>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/shadow-maint/shadow/pull/146

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, josch@debian.org, reproducible-bugs@lists.alioth.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#917773; Package src:shadow. (Sun, 30 Dec 2018 01:03:04 GMT) (full text, mbox, link).


Acknowledgement sent to Johannes 'josch' Schauer <josch@debian.org>:
New Bug report received and forwarded. Copy sent to josch@debian.org, reproducible-bugs@lists.alioth.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>. (Sun, 30 Dec 2018 01:03:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Johannes 'josch' Schauer <josch@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: shadow: doesn't respect SOURCE_DATE_EPOCH
Date: Sun, 30 Dec 2018 01:58:46 +0100
Source: shadow
Severity: normal
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps

Hi,

the /etc/shadow as created by debootstrap does not respect the
SOURCE_DATE_EPOCH environment variable anymore. This bug was formerly
fixed in #857803. Steps to reproduce:

$ sudo SOURCE_DATE_EPOCH=0 debootstrap --variant=minbase unstable debian-unstable
$ sudo cat debian-unstable/etc/shadow
root:*:17895:0:99999:7:::
daemon:*:17895:0:99999:7:::
bin:*:17895:0:99999:7:::
sys:*:17895:0:99999:7:::
sync:*:17895:0:99999:7:::
games:*:17895:0:99999:7:::
man:*:17895:0:99999:7:::
lp:*:17895:0:99999:7:::
mail:*:17895:0:99999:7:::
news:*:17895:0:99999:7:::
uucp:*:17895:0:99999:7:::
proxy:*:17895:0:99999:7:::
www-data:*:17895:0:99999:7:::
backup:*:17895:0:99999:7:::
list:*:17895:0:99999:7:::
irc:*:17895:0:99999:7:::
gnats:*:17895:0:99999:7:::
nobody:*:17895:0:99999:7:::
_apt:*::0:99999:7:::

So some parts of shadow respect SOURCE_DATE_EPOCH (the user _apt is
created with a lastchange field of zero) but other parts do not (the
remaining users).

Unfortunately I don't have time to debug this problem right now but my
hunch is, that the culprit is a line like this:

https://sources.debian.org/src/shadow/1:4.5-1.1/src/pwconv.c/?hl=268#L268

Instead, spent.sp_lstchg should be set to the return value of the
gettime() function.

Thanks!

cheers, josch



Information forwarded to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#917773; Package src:shadow. (Sun, 30 Dec 2018 12:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Johannes Schauer <josch@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>. (Sun, 30 Dec 2018 12:57:03 GMT) (full text, mbox, link).


Message #10 received at 917773@bugs.debian.org (full text, mbox, reply):

From: Johannes Schauer <josch@debian.org>
To: 917773@bugs.debian.org
Subject: Re: shadow: doesn't respect SOURCE_DATE_EPOCH
Date: Sun, 30 Dec 2018 13:55:04 +0100
[Message part 1 (text/plain, inline)]
Control: tag -1 + patch

On Sun, 30 Dec 2018 01:58:46 +0100 Johannes 'josch' Schauer <josch@debian.org> wrote:
> the /etc/shadow as created by debootstrap does not respect the
> SOURCE_DATE_EPOCH environment variable anymore. This bug was formerly
> fixed in #857803. Steps to reproduce:
> 
> $ sudo SOURCE_DATE_EPOCH=0 debootstrap --variant=minbase unstable debian-unstable
> $ sudo cat debian-unstable/etc/shadow
> root:*:17895:0:99999:7:::
> daemon:*:17895:0:99999:7:::
> bin:*:17895:0:99999:7:::
> sys:*:17895:0:99999:7:::
> sync:*:17895:0:99999:7:::
> games:*:17895:0:99999:7:::
> man:*:17895:0:99999:7:::
> lp:*:17895:0:99999:7:::
> mail:*:17895:0:99999:7:::
> news:*:17895:0:99999:7:::
> uucp:*:17895:0:99999:7:::
> proxy:*:17895:0:99999:7:::
> www-data:*:17895:0:99999:7:::
> backup:*:17895:0:99999:7:::
> list:*:17895:0:99999:7:::
> irc:*:17895:0:99999:7:::
> gnats:*:17895:0:99999:7:::
> nobody:*:17895:0:99999:7:::
> _apt:*::0:99999:7:::
> 
> So some parts of shadow respect SOURCE_DATE_EPOCH (the user _apt is
> created with a lastchange field of zero) but other parts do not (the
> remaining users).

I now have a patch (attached) which fixes the problem.

Thanks!

cheers, josch
[wip.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]

Added tag(s) patch. Request was from Johannes Schauer <josch@debian.org> to 917773-submit@bugs.debian.org. (Sun, 30 Dec 2018 12:57:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#917773; Package src:shadow. (Wed, 02 Jan 2019 18:21:08 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>. (Wed, 02 Jan 2019 18:21:08 GMT) (full text, mbox, link).


Message #17 received at 917773@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: Johannes josch Schauer <josch@debian.org>, 917773@bugs.debian.org
Cc: rb-general@lists.reproducible-builds.org
Subject: Re: Bug#917773: shadow: doesn't respect SOURCE_DATE_EPOCH
Date: Wed, 02 Jan 2019 18:18:07 +0000
forwarded 917773 https://github.com/shadow-maint/shadow/pull/146
thanks

Hi josch,

> the /etc/shadow as created by debootstrap does not respect the
> SOURCE_DATE_EPOCH environment variable anymore. This bug was formerly
> fixed in #857803.

I have attempted to fix this upstream here:

  https://github.com/shadow-maint/shadow/pull/146


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Set Bug forwarded-to-address to 'https://github.com/shadow-maint/shadow/pull/146'. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Wed, 02 Jan 2019 18:21:10 GMT) (full text, mbox, link).


Added tag(s) fixed-upstream. Request was from debian-bts-link@lists.debian.org to control@bugs.debian.org. (Mon, 22 Apr 2019 19:30:05 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#917773; Package src:shadow. (Mon, 15 Jul 2019 21:21:04 GMT) (full text, mbox, link).


Acknowledgement sent to balint@balintreczey.hu:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>. (Mon, 15 Jul 2019 21:21:04 GMT) (full text, mbox, link).


Message #26 received at 917773@bugs.debian.org (full text, mbox, reply):

From: Bálint Réczey <balint@balintreczey.hu>
To: Chris Lamb <lamby@debian.org>, 917773@bugs.debian.org, 917773-done@bugs.debian.org
Cc: Johannes josch Schauer <josch@debian.org>, rb-general@lists.reproducible-builds.org
Subject: Re: [Pkg-shadow-devel] Bug#917773: shadow: doesn't respect SOURCE_DATE_EPOCH
Date: Mon, 15 Jul 2019 23:17:41 +0200
Control: fixed -1 1:4.7-1

Chris Lamb <lamby@debian.org> ezt írta (időpont: 2019. jan. 2., Sze, 19:21):
>
> forwarded 917773 https://github.com/shadow-maint/shadow/pull/146
> thanks
>
> Hi josch,
>
> > the /etc/shadow as created by debootstrap does not respect the
> > SOURCE_DATE_EPOCH environment variable anymore. This bug was formerly
> > fixed in #857803.
>
> I have attempted to fix this upstream here:
>
>   https://github.com/shadow-maint/shadow/pull/146

Thanks!

Cheers,
Balint

>
>
> Best wishes,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org / chris-lamb.co.uk
>        `-
>
> _______________________________________________
> Pkg-shadow-devel mailing list
> Pkg-shadow-devel@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel



Marked as fixed in versions shadow/1:4.7-1. Request was from Bálint Réczey <balint@balintreczey.hu> to 917773-submit@bugs.debian.org. (Mon, 15 Jul 2019 21:21:04 GMT) (full text, mbox, link).


Reply sent to balint@balintreczey.hu:
You have taken responsibility. (Mon, 15 Jul 2019 21:21:07 GMT) (full text, mbox, link).


Notification sent to Johannes 'josch' Schauer <josch@debian.org>:
Bug acknowledged by developer. (Mon, 15 Jul 2019 21:21:08 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 19 Aug 2019 07:30:52 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Mon Feb 3 06:13:27 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.