916226">

Debian Bug report logs - #916226
diffoscope pytest warnings

version graph

Package: diffoscope; Maintainer for diffoscope is Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>; Source for diffoscope is src:diffoscope (PTS, buildd, popcon).

Reported by: Jelle van der Waa <jelle@vdwaa.nl>

Date: Tue, 11 Dec 2018 16:57:02 UTC

Severity: normal

Found in version diffoscope/107

Fixed in version diffoscope/108

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

Forwarded to https://salsa.debian.org/reproducible-builds/diffoscope/issues/1

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#916226; Package diffoscope. (Tue, 11 Dec 2018 16:57:05 GMT) (full text, mbox, link).


Acknowledgement sent to Jelle van der Waa <jelle@vdwaa.nl>:
New Bug report received and forwarded. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 11 Dec 2018 16:57:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, " called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information. > =============================== warnings summary =============================== > > -- > Jelle van der Waa > > &subject=Re: diffoscope pytest warnings&References=<20181211165155.br7lgnnsocxp7klz@gmail.com>">reply):

From: Jelle van der Waa <jelle@vdwaa.nl>
To: submit@bugs.debian.org
Subject: diffoscope pytest warnings
Date: Tue, 11 Dec 2018 17:51:58 +0100
Package: diffoscope
Version: 107

Running the tests with 4.0.1 produces the following error:

tests/comparators/test_icc.py:53: in cd_iccdump_version
    val = subprocess.check_output(('cd-iccdump', icc1().path)).decode('utf-8')
E   _pytest.warning_types.RemovedInPytest4Warning: Fixture "<lambda>" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.
=============================== warnings summary ===============================

-- 
Jelle van der Waa



Message sent on to Jelle van der Waa <jelle@vdwaa.nl>:
Bug#916226. (Wed, 12 Dec 2018 14:09:04 GMT) (full text, mbox, link).


Message #8 received at 916226-submitter@bugs.debian.org (full text, mbox, ------------------------------------------------------------------------ > > (this message was generated automatically) > -- > Greetings > > https://bugs.debian.org/916226 > > ">reply):

From: Chris Lamb <lamby@debian.org>
To: 916226-submitter@bugs.debian.org
Subject: Bug #916226 in diffoscope marked as pending
Date: Wed, 12 Dec 2018 14:08:30 +0000
Control: tag -1 pending

Hello,

Bug #916226 in diffoscope reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/reproducible-builds/diffoscope/commit/a4c38a60fe505de772f0d9ced5cca1ca5df540ba

------------------------------------------------------------------------
test_icc: Calculate the path to a test .icc file using data() rather than using the pytest fixture to avoid a "Fixtures are not meant to be called directly" warning/error. (Closes: #916226)
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/916226



Added tag(s) pending. Request was from Chris Lamb <lamby@debian.org> to 916226-submitter@bugs.debian.org. (Wed, 12 Dec 2018 14:09:04 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#916226; Package diffoscope. (Wed, 12 Dec 2018 16:51:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Wed, 12 Dec 2018 16:51:04 GMT) (full text, mbox, link).


Message #15 received at 916226@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 916226@bugs.debian.org
Cc: Jelle van der Waa <jelle@vdwaa.nl>
Subject: Re: diffoscope pytest warnings
Date: Wed, 12 Dec 2018 17:49:34 +0100
tags 916226 + pending
thanks

Fixed in Git, pending upload:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/a4c38a60fe505de772f0d9ced5cca1ca5df540ba

  tests/comparators/test_icc.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#916226; Package diffoscope. (Sat, 15 Dec 2018 09:54:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Sat, 15 Dec 2018 09:54:02 GMT) (full text, mbox, link).


Message #20 received at 916226@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 916226@bugs.debian.org
Cc: Jelle van der Waa <jelle@vdwaa.nl>
Subject: Re: diffoscope pytest warnings
Date: Sat, 15 Dec 2018 10:50:58 +0100
forwarded 916226 https://salsa.debian.org/reproducible-builds/diffoscope/issues/1
thanks

I've forwarded this upstream here:

  https://salsa.debian.org/reproducible-builds/diffoscope/issues/1


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Set Bug forwarded-to-address to 'https://salsa.debian.org/reproducible-builds/diffoscope/issues/1'. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Sat, 15 Dec 2018 09:54:04 GMT) (full text, mbox, link).


Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Sun, 13 Jan 2019 19:51:07 GMT) (full text, mbox, link).


Notification sent to Jelle van der Waa <jelle@vdwaa.nl>:
Bug acknowledged by developer. (Sun, 13 Jan 2019 19:51:07 GMT) (full text, mbox, link).


Message #27 received at 916226-close@bugs.debian.org (full text, mbox, called directly" warning/error. (Closes: #916226) > * Fix a test_mozzip_compressed_files test failure under Alpine Linux. > (Closes: #916353, MR: !8) > * Output improvements: > * Prefer to comment that files are identical rather than having a > "fuzziness score" of zero. > * Expand the padding/spacing for "N calls" in the profiling output; having > 99,999+ calls to cmp(1) is not uncommon for ISOs. > * Add a note to the "Files similar despite different names" comment to > clarify that a lower score is more similar. > * Use File.file_header to tidy JSON matching in the json, ppu and wasm > comparators. > * Drop debbindiff Breaks/Replaces; was removed in 2015, never part of a > stable release, etc. > * Correct a "positives" typo. > . &In-Reply-To=">reply):

From: Chris Lamb <lamby@debian.org>
To: 916226-close@bugs.debian.org
Subject: Bug#916226: fixed in diffoscope 108
Date: Sun, 13 Jan 2019 19:50:09 +0000
Source: diffoscope
Source-Version: 108

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 916226@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 13 Jan 2019 19:21:05 +0000
Source: diffoscope
Binary: diffoscope
Architecture: source all
Version: 108
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 916226 916353
Changes:
 diffoscope (108) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * test_icc: Calculate the path to a test .icc file using data() rather than
     using the pytest fixture itself to avoid a "Fixtures are not meant to be
     called directly" warning/error. (Closes: #916226)
   * Fix a test_mozzip_compressed_files test failure under Alpine Linux.
     (Closes: #916353, MR: !8)
   * Output improvements:
     * Prefer to comment that files are identical rather than having a
       "fuzziness score" of zero.
     * Expand the padding/spacing for "N calls" in the profiling output; having
       99,999+ calls to cmp(1) is not uncommon for ISOs.
     * Add a note to the "Files similar despite different names" comment to
       clarify that a lower score is more similar.
   * Use File.file_header to tidy JSON matching in the json, ppu and wasm
     comparators.
   * Drop debbindiff Breaks/Replaces; was removed in 2015, never part of a
     stable release, etc.
   * Correct a "positives" typo.
 .
   [ Joachim Breitner ]
   * Add support for comparing WebAssembly modules. (MR: !17)
 .
   [ Holger Levsen ]
   * Bump Standards-Version to 4.3.0
   * Clarify that (upstream) issues should be reported via the
     issue tracker on salsa.debian.org.
 .
   [ Mattia Rizzolo ]
   * Try matching for MozillaZipFile before ZipFile.
Checksums-Sha1:
 598ed1472de5b70b03682bb3246b2f9351373e17 4419 diffoscope_108.dsc
 ac1c4834fe123de4ba1529a445988058fb7afc08 9276748 diffoscope_108.tar.xz
 8b0551c49e52570b79223926acf7de306470ca44 126152 diffoscope_108_all.deb
 e69d236cfe7208e159a1648637948a03c48c7a9e 20830 diffoscope_108_amd64.buildinfo
Checksums-Sha256:
 fa7b83efb69f29f50db677eb1fee27449545ecea4d959321d7933496bc8e7046 4419 diffoscope_108.dsc
 7b22c545925cdd5073264fdd9333cd78a67dcf5ccb29e363c0cc3d05ab9a02d5 9276748 diffoscope_108.tar.xz
 f130ef05c08e99c234ff6797c160aa62adab5650b39b131aca6abe948372a672 126152 diffoscope_108_all.deb
 9756855d164c746da5ff9c5025ed746cd64942e23862eeca087146626601d084 20830 diffoscope_108_amd64.buildinfo
Files:
 bd7ea0b5810f154542e1ad7e7c0d5d33 4419 devel optional diffoscope_108.dsc
 c91c2b988e7757a8cbc91ec8da29d158 9276748 devel optional diffoscope_108.tar.xz
 edf99b108c3c200cc389c894927ce9f5 126152 devel optional diffoscope_108_all.deb
 e7ba978902bbed39526588e55631689a 20830 devel optional diffoscope_108_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlw7kxcACgkQHpU+J9Qx
HlggxxAAgtq/PSxnIQCirrChfXeeeKsQuqejT78pjiaaIfN0aYrwEOj0mlLn3KBL
qJRHEEDwQRzVtwFboeuNYvKbU+fQiKiP9VD2ANW7hXA7P1zzZUaW0P3R433AVY/0
iwiIdAyx9RcvOZEshpU8ZjYOtlCrGnjK6gvADqKGzZw+zzARHAT5dlYzuAI1sGfu
ygN8Jkl7V0rQ3ZkK3dkHL1aQ3jzWbaT5j8WvXCarCYtjbuoOv6GoQbtuuYB2qFBe
YQxFpU0E9r99UZv6L1CoX/fV/LAXLSNupwzTzCq7n+XNgyJZopNDqEZwBvpSQfkn
Lvo0vgnSc6CNJO0hhhblpQB7jLrFw66WWxNnZ1mA5EwnuOxEsM023Gpi8qEqnruP
ad6clML413WOrKmnUtiefZwvJwQ5D/k0LExbEcCcQZe93+hsDhxe0Jx2FcsBZq8U
soE/ZsVr6dWlJWTnhH0a1QeWN4dIW8+2yVkXpZIUKZ5qbq6dheQlElk3WTSraPV6
fNUkAOv1asK/ln7OFY03vNzAB58NDUMbWC2/eTq9hdSrww5XaeDVV+XIrm7HJcNx
+8R6PfbjP5ZtFB9u5I+S8IQ49+d2/kXkVwJulj5tBCeK29KHF/K3c/FyckT3npJY
coiLiFIV+M2imB49OBvNInjxGXZBX7Qr4zOXJnYl4GhMOd9YNwU=
=uvfN
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 13 Feb 2019 07:27:49 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:52:12 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.