818230">

Debian Bug report logs - #818230
aircrack-ng: please make the build reproducible

version graph

Package: src:aircrack-ng; Maintainer for src:aircrack-ng is Debian Security Tools <team+pkg-security@tracker.debian.org>;

Reported by: Reiner Herrmann <reiner@reiner-h.de>

Date: Mon, 14 Mar 2016 20:39:01 UTC

Severity: wishlist

Tags: fixed-upstream, patch

Found in version aircrack-ng/1:1.2-0~beta3-4

Fixed in version aircrack-ng/1:1.2-0~rc4-2

Done: Samuel Henrique <samueloph@gmail.com>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/aircrack-ng/aircrack-ng/pull/91

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-builds@lists.alioth.debian.org, Carlos Alberto Lopez Perez <clopez@igalia.com>:
Bug#818230; Package src:aircrack-ng. (Mon, 14 Mar 2016 20:39:05 GMT) (full text, mbox, link).


Acknowledgement sent to Reiner Herrmann <reiner@reiner-h.de>:
New Bug report received and forwarded. Copy sent to reproducible-builds@lists.alioth.debian.org, Carlos Alberto Lopez Perez <clopez@igalia.com>. (Mon, 14 Mar 2016 20:39:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, that aircrack-ng could not be built reproducibly. > The command linking all object files together also contains an assembly > file. gcc compiles it into a temporary object file /tmp/cc??????.o. > This path is embedded into debug information, which causes also a > difference in the build id of the aircrack-ng binary. > > The attached patch fixes this by letting make compile the assembly file > before all object files are linked. > > Regards, > Reiner > > [1]: https://wiki.debian.org/ReproducibleBuilds ">reply):

From: Reiner Herrmann <reiner@reiner-h.de>
To: submit@bugs.debian.org
Subject: aircrack-ng: please make the build reproducible
Date: Mon, 14 Mar 2016 21:37:40 +0100
[Message part 1 (text/plain, inline)]
Source: aircrack-ng
Version: 1:1.2-0~beta3-4
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that aircrack-ng could not be built reproducibly.
The command linking all object files together also contains an assembly
file. gcc compiles it into a temporary object file /tmp/cc??????.o.
This path is embedded into debug information, which causes also a
difference in the build id of the aircrack-ng binary.

The attached patch fixes this by letting make compile the assembly file
before all object files are linked.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
[aircrack-ng.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>:
Bug#818230; Package src:aircrack-ng. (Sat, 24 Dec 2016 18:27:09 GMT) (full text, mbox, link).


Acknowledgement sent to Samuel Henrique <samueloph@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>. (Sat, 24 Dec 2016 18:27:09 GMT) (full text, mbox, link).


Message #10 received at 818230@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>
To: 818230@bugs.debian.org
Subject: aircrack-ng: please make the build reproducible
Date: Sat, 24 Dec 2016 16:23:58 -0200
[Message part 1 (text/plain, inline)]
Control: tags 818230 - patch

Hi Reiner,

Thanks a lot for the work, but aircrack has made considerable amount of
changes on its build system since 1.2-0~beta3-4, i understand that rc4
still doesn't builds reproducibly.

Could you please update the patch to rc4? I would be infinitely grateful :)

Also, i believe you can also send this upstream, but if you don't, i can do
that for you.

Samuel Henrique <samueloph>
[Message part 2 (text/html, inline)]

Removed tag(s) patch. Request was from Samuel Henrique <samueloph@gmail.com> to 818230-submit@bugs.debian.org. (Sat, 24 Dec 2016 18:27:09 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>:
Bug#818230; Package src:aircrack-ng. (Sun, 25 Dec 2016 20:15:03 GMT) (full text, mbox, link).


Acknowledgement sent to Reiner Herrmann <reiner@reiner-h.de>:
Extra info received and forwarded to list. Copy sent to Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>. (Sun, 25 Dec 2016 20:15:03 GMT) (full text, mbox, link).


Message #17 received at 818230@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>
To: Samuel Henrique <samueloph@gmail.com>
Cc: 818230@bugs.debian.org
Subject: Re: Fwd: aircrack-ng: please make the build reproducible
Date: Sun, 25 Dec 2016 21:13:27 +0100
[Message part 1 (text/plain, inline)]
Control: tags -1 + patch

On Sun, Dec 25, 2016 at 11:05:56AM -0200, Samuel Henrique wrote:
> Could you please update the patch to rc4? I would be infinitely grateful :)

Updated patch attached. :)

> Also, i believe you can also send this upstream, but if you don't, i can do
> that for you.

Please send it upstream, thanks!

Regards,
  Reiner
[aircrack-ng.patch (text/x-diff, attachment)]

Added tag(s) patch. Request was from Reiner Herrmann <reiner@reiner-h.de> to 818230-submit@bugs.debian.org. (Sun, 25 Dec 2016 20:15:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>:
Bug#818230; Package src:aircrack-ng. (Sun, 25 Dec 2016 22:54:02 GMT) (full text, mbox, link).


Acknowledgement sent to Samuel Henrique <samueloph@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>. (Sun, 25 Dec 2016 22:54:02 GMT) (full text, mbox, link).


Message #24 received at 818230@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>
To: 818230@bugs.debian.org
Subject: aircrack-ng: please make the build reproducible
Date: Sun, 25 Dec 2016 20:50:42 -0200
[Message part 1 (text/plain, inline)]
Control: tags -1 + pending
Control: forwarded -1 https://github.com/aircrack-ng/aircrack-ng/pull/91

Fix commited and sent upstream, thanks a lot Reiner

Samuel Henrique <samueloph>
[Message part 2 (text/html, inline)]

Added tag(s) pending. Request was from Samuel Henrique <samueloph@gmail.com> to 818230-submit@bugs.debian.org. (Sun, 25 Dec 2016 22:54:03 GMT) (full text, mbox, link).


Set Bug forwarded-to-address to 'https://github.com/aircrack-ng/aircrack-ng/pull/91'. Request was from Samuel Henrique <samueloph@gmail.com> to 818230-submit@bugs.debian.org. (Sun, 25 Dec 2016 22:54:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>:
Bug#818230; Package src:aircrack-ng. (Thu, 29 Dec 2016 23:24:02 GMT) (full text, mbox, link).


Acknowledgement sent to Samuel Henrique <samueloph@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>. (Thu, 29 Dec 2016 23:24:02 GMT) (full text, mbox, link).


Message #33 received at 818230@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>
To: Reiner Herrmann <reiner@reiner-h.de>, 818230@bugs.debian.org
Subject: Re: Bug#818230: Fwd: aircrack-ng: please make the build reproducible
Date: Thu, 29 Dec 2016 21:20:20 -0200
[Message part 1 (text/plain, inline)]
Hi Reiner,

Could you please follow up the discussion at[1]?

I added you as a collaborator on my fork, so what you push there will
update on the PR (check your email for a github collab. invite)

[1]https://github.com/aircrack-ng/aircrack-ng/pull/91

Samuel Henrique <samueloph>

2016-12-25 18:13 GMT-02:00 Reiner Herrmann <reiner@reiner-h.de>:

> Control: tags -1 + patch
>
> On Sun, Dec 25, 2016 at 11:05:56AM -0200, Samuel Henrique wrote:
> > Could you please update the patch to rc4? I would be infinitely grateful
> :)
>
> Updated patch attached. :)
>
> > Also, i believe you can also send this upstream, but if you don't, i can
> do
> > that for you.
>
> Please send it upstream, thanks!
>
> Regards,
>   Reiner
>
>
>
>
[Message part 2 (text/html, inline)]

Added tag(s) fixed-upstream. Request was from bts-link-upstream@lists.alioth.debian.org to control@bugs.debian.org. (Mon, 02 Jan 2017 17:33:19 GMT) (full text, mbox, link).


Message sent on to Reiner Herrmann <reiner@reiner-h.de>:
Bug#818230. (Thu, 05 Jan 2017 01:57:08 GMT) (full text, mbox, link).


Message #38 received at 818230-submitter@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>
To: 818230-submitter@bugs.debian.org
Subject: Bug#818230 marked as pending
Date: Thu, 05 Jan 2017 01:56:02 +0000
tag 818230 pending
thanks

Hello,

Bug #818230 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=pkg-security/aircrack-ng.git;a=commitdiff;h=6b5d294

---
commit 6b5d2949d60d44e2685f2277be2a68e2a6474750
Author: Samuel Henrique <samueloph@gmail.com>
Date:   Wed Jan 4 23:52:04 2017 -0200

    Prepare changelog

diff --git a/debian/changelog b/debian/changelog
index 64d5f2c..20fbab2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+aircrack-ng (1:1.2-0~rc4-2) unstable; urgency=medium
+
+  * debian/patches:
+    - 01_reproducible_build.patch: New patch to allow reproducible builds,
+      thanks a lot to Reiner Herrmann (closes: #818230).
+    - 01_remove_check.patch: Remove no-more-needed patch, see below.
+    - 04_memory_access.patch: New patch from upstream to fix memory access
+      issues.
+
+ -- Samuel Henrique <samueloph@gmail.com>  Wed, 04 Jan 2017 23:53:28 -0200
+
 aircrack-ng (1:1.2-0~rc4-1) unstable; urgency=medium
 
   * New upstream release.



Reply sent to Samuel Henrique <samueloph@gmail.com>:
You have taken responsibility. (Sat, 07 Jan 2017 17:06:07 GMT) (full text, mbox, link).


Notification sent to Reiner Herrmann <reiner@reiner-h.de>:
Bug acknowledged by developer. (Sat, 07 Jan 2017 17:06:07 GMT) (full text, mbox, link).


Message #43 received at 818230-close@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>
To: 818230-close@bugs.debian.org
Subject: Bug#818230: fixed in aircrack-ng 1:1.2-0~rc4-2
Date: Sat, 07 Jan 2017 17:03:24 +0000
Source: aircrack-ng
Source-Version: 1:1.2-0~rc4-2

We believe that the bug you reported is fixed in the latest version of
aircrack-ng, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 818230@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Henrique <samueloph@gmail.com> (supplier of updated aircrack-ng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 04 Jan 2017 23:53:28 -0200
Source: aircrack-ng
Binary: aircrack-ng
Architecture: source
Version: 1:1.2-0~rc4-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>
Changed-By: Samuel Henrique <samueloph@gmail.com>
Description:
 aircrack-ng - wireless WEP/WPA cracking utilities
Closes: 818230
Changes:
 aircrack-ng (1:1.2-0~rc4-2) unstable; urgency=medium
 .
   * d/copyright: Update debian/* entry.
   * debian/patches:
     - 01_reproducible_build.patch: New patch to allow reproducible builds,
       thanks a lot to Reiner Herrmann (closes: #818230).
     - 01_remove_check.patch: Remove no-more-needed patch, see below.
     - 04_memory_access.patch: New patch from upstream to fix memory access
       issues.
Checksums-Sha1:
 0b74aa31299b36e79fa95675dd24a4f7220b0975 2185 aircrack-ng_1.2-0~rc4-2.dsc
 4a4034eb8deacdcd0fa96a2bbd866f9aca15c8db 15300 aircrack-ng_1.2-0~rc4-2.debian.tar.xz
Checksums-Sha256:
 78a5efb4c3356bb647bb142194fb34e731b1f32bc66b67a6aeb8cc2e378fe077 2185 aircrack-ng_1.2-0~rc4-2.dsc
 32a27dce0df1b61f64b5269fd7a24fdc12fd36760ea86c1a64e002ba25ee2502 15300 aircrack-ng_1.2-0~rc4-2.debian.tar.xz
Files:
 0ceefd593ed7d8436d4abf885171eb3c 2185 net optional aircrack-ng_1.2-0~rc4-2.dsc
 24bad20334769085fe294c6634d3f81f 15300 net optional aircrack-ng_1.2-0~rc4-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYcRxTAAoJEPNPCXROn13ZQ4wQAI3el1s4I8jPVIy/Rrq7tEd0
BRwNKk+Jbre4tRtDRQaDDKZdjO2ELbEWwGMwyinZCRrcVZYJ0iuH4/Txbbwuiy8r
ex2CR6kPH9Mb5p95svA2up5WLaQapcrfE+7KUerhlsIfXWfglIHF2CDWcOkywXsE
OOw7OnYzCEIWOVUImoaPVxWC4b2m3iBKsKBrw/Ux9ZZG75Ol7E+E0B6c4w5ot198
5tTjg8kKjTEqlz9/0thIy2m7/oJZzQG9tOs6DoQ71eytLztoH9uo6JXDcs2Tlcer
zbcRKa5fXvpsUkyNhLfy5vnKEgzRd3ClktG5ZJ8Qz3+b8lGVR1tNoW2W7XvG+gEG
2OM4FqOKOHcQudO/2rdJMo2+8G05xRAa+j0Im2axE6LLszgvC1dbHXxSLVD8KG3x
inHOI1Q5ZlOHg6iro6jbXXSN+Ig+SYWwdFCQI+IVBZRUB0EkBoGpAVX4ZFqZAOXS
fBzOREBxbap34hzNCzg5r36c5QbopxRkMcKdtRxw1VRfoGjVlJ5olKz5Dflwpchv
9LczhwCj43Dp/+S/YTketTNU9lfcOL2Lp78fPQyd7XqnrclQlXUvj3MDfxPTHmFy
KUw25K+FIyCDz8viTShS/6KUL+/j1ZB8vjbwD6QiFi8Wm2IbkbbZKUJ/tFtE7ZNf
F2SxFpTLP6OL2HcdIzKZ
=+x+x
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 15 Feb 2017 07:27:00 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:52:29 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.