Report forwarded
to debian-bugs-dist@lists.debian.org, reproducible-builds@lists.alioth.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sun, 13 Mar 2016 09:57:05 GMT) (full text, mbox, link).
Acknowledgement sent
to Niels Thykier <niels@thykier.net>:
New Bug report received and forwarded. Copy sent to reproducible-builds@lists.alioth.debian.org, Craig Small <csmall@debian.org>.
(Sun, 13 Mar 2016 09:57:06 GMT) (full text, mbox, link).
Source: ncurses
Severity: wishlist
Tags: patch
Hi,
While working on the “reproducible builds” effort [1], we have noticed
that ncurses could not be built reproducibly.
We have found that MKterminfo.sh included a trailing space in one
build test but not in the other. It is not quite clear to me what
triggers this behaviour, but there is a note claiming it to be the
locale difference (one build is in C and the other in a French UTF-8
locale).
The attached patch makes MKterminfo.sh strip trailing spaces from the
CAP file, which removes a source of non-determinism. Once applied,
ncurses can be built reproducibly in our current experimental
framework.
[1]: https://wiki.debian.org/ReproducibleBuilds
Thanks,
~Niels
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sun, 13 Mar 2016 10:51:05 GMT) (full text, mbox, link).
Acknowledgement sent
to dickey@his.com:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Sun, 13 Mar 2016 10:51:05 GMT) (full text, mbox, link).
On Sun, Mar 13, 2016 at 10:38:26AM +0100, Niels Thykier wrote:
> Source: ncurses
> Severity: wishlist
> Tags: patch
>
> Hi,
>
> While working on the “reproducible builds” effort [1], we have noticed
> that ncurses could not be built reproducibly.
>
> We have found that MKterminfo.sh included a trailing space in one
> build test but not in the other. It is not quite clear to me what
> triggers this behaviour, but there is a note claiming it to be the
> locale difference (one build is in C and the other in a French UTF-8
> locale).
If it is a locale issue, then ensuring that the script uses
POSIX locale will fix that. The script does that already.
Perhaps the bug is not in ncurses, but in one of the tools used --
some clarification would be helpful.
--
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.netftp://invisible-island.net
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sun, 13 Mar 2016 11:00:07 GMT) (full text, mbox, link).
Acknowledgement sent
to dickey@his.com:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Sun, 13 Mar 2016 11:00:07 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sun, 13 Mar 2016 11:24:08 GMT) (full text, mbox, link).
Acknowledgement sent
to Niels Thykier <niels@thykier.net>:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Sun, 13 Mar 2016 11:24:08 GMT) (full text, mbox, link).
Thomas Dickey:
> On Sun, Mar 13, 2016 at 10:38:26AM +0100, Niels Thykier wrote:
>> Source: ncurses
>> Severity: wishlist
>> Tags: patch
>>
>> Hi,
>>
>> While working on the “reproducible builds” effort [1], we have noticed
>> that ncurses could not be built reproducibly.
>>
>> We have found that MKterminfo.sh included a trailing space in one
>> build test but not in the other. It is not quite clear to me what
>> triggers this behaviour, but there is a note claiming it to be the
>> locale difference (one build is in C and the other in a French UTF-8
>> locale).
>
> If it is a locale issue, then ensuring that the script uses
> POSIX locale will fix that. The script does that already.
>
> Perhaps the bug is not in ncurses, but in one of the tools used --
> some clarification would be helpful.
>
Hi,
After digging a bit, it turns out that the difference is due to "dash vs
bash". In one run /bin/sh is dash and the other it is bash (I think
$SHELL changes accordingly).
However, I am not any wiser on why dash and bash disagrees on this.
Bash strips the whitespace and dash keeps it.
Thanks,
~Niels
[1] https://tests.reproducible-builds.org/reproducible.html
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Mon, 14 Mar 2016 17:30:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Sven Joachim <svenjoac@gmx.de>:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Mon, 14 Mar 2016 17:30:03 GMT) (full text, mbox, link).
Subject: Re: Bug#818067: ncurses: Please make ncurses reproducible
Date: Mon, 14 Mar 2016 18:27:20 +0100
On 2016-03-13 11:21 +0000, Niels Thykier wrote:
> Thomas Dickey:
>> On Sun, Mar 13, 2016 at 10:38:26AM +0100, Niels Thykier wrote:
>>> Source: ncurses
>>> Severity: wishlist
>>> Tags: patch
>>>
>>> Hi,
>>>
>>> While working on the “reproducible builds” effort [1], we have noticed
>>> that ncurses could not be built reproducibly.
>>>
>>> We have found that MKterminfo.sh included a trailing space in one
>>> build test but not in the other. It is not quite clear to me what
>>> triggers this behaviour, but there is a note claiming it to be the
>>> locale difference (one build is in C and the other in a French UTF-8
>>> locale).
>>
>> If it is a locale issue, then ensuring that the script uses
>> POSIX locale will fix that. The script does that already.
>>
>> Perhaps the bug is not in ncurses, but in one of the tools used --
>> some clarification would be helpful.
>>
>
> Hi,
>
> After digging a bit, it turns out that the difference is due to "dash vs
> bash". In one run /bin/sh is dash and the other it is bash (I think
> $SHELL changes accordingly).
>
> However, I am not any wiser on why dash and bash disagrees on this.
> Bash strips the whitespace and dash keeps it.
That would be https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794965,
it seems. I'd rather see it fixed than paper over it in ncurses.
Cheers,
Sven
Added blocking bug(s) of 818067: 794965
Request was from Jérémy Bobbio <lunar@debian.org>
to control@bugs.debian.org.
(Sun, 20 Mar 2016 22:57:14 GMT) (full text, mbox, link).
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Mon, 11 Jul 2016 08:30:10 GMT) (full text, mbox, link).
Acknowledgement sent
to Sven Joachim <svenjoac@gmx.de>:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Mon, 11 Jul 2016 08:30:10 GMT) (full text, mbox, link).
Subject: Re: Bug#818067: ncurses: Please make ncurses reproducible
Date: Mon, 11 Jul 2016 10:25:43 +0200
On 2016-03-14 17:27 +0100, Sven Joachim wrote:
> On 2016-03-13 11:21 +0000, Niels Thykier wrote:
>
>> Thomas Dickey:
>>> On Sun, Mar 13, 2016 at 10:38:26AM +0100, Niels Thykier wrote:
>>>> Source: ncurses
>>>> Severity: wishlist
>>>> Tags: patch
>>>>
>>>> Hi,
>>>>
>>>> While working on the “reproducible builds” effort [1], we have noticed
>>>> that ncurses could not be built reproducibly.
>>>>
>>>> We have found that MKterminfo.sh included a trailing space in one
>>>> build test but not in the other. It is not quite clear to me what
>>>> triggers this behaviour, but there is a note claiming it to be the
>>>> locale difference (one build is in C and the other in a French UTF-8
>>>> locale).
>>>
>>> If it is a locale issue, then ensuring that the script uses
>>> POSIX locale will fix that. The script does that already.
>>>
>>> Perhaps the bug is not in ncurses, but in one of the tools used --
>>> some clarification would be helpful.
>>>
>>
>> Hi,
>>
>> After digging a bit, it turns out that the difference is due to "dash vs
>> bash". In one run /bin/sh is dash and the other it is bash (I think
>> $SHELL changes accordingly).
>>
>> However, I am not any wiser on why dash and bash disagrees on this.
>> Bash strips the whitespace and dash keeps it.
>
> That would be https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794965,
> it seems. I'd rather see it fixed than paper over it in ncurses.
Looking at it again, there _is_ a small bug in ncurses, the trailing
space should not have been there in the first place. It is in the
include/Caps* files and has been there forever (at least since ncurses
1.9.9g):
,---- [ include/Caps* ]
| #%Whenever possible, capnames are chosen to be the same as or similar to
| #%the ANSI X3.64-1979 standard (now superseded by ECMA-48, which uses
`---- ^^ note trailing space here
Running "sed -i -e 's/which uses $/which uses/' include/Caps*" fixes that.
Cheers,
Sven
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sat, 13 Aug 2016 17:45:23 GMT) (full text, mbox, link).
Acknowledgement sent
to Sven Joachim <svenjoac@gmx.de>:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Sat, 13 Aug 2016 17:45:24 GMT) (full text, mbox, link).
Subject: Re: Bug#818067: ncurses: Please make ncurses reproducible
Date: Sat, 13 Aug 2016 19:42:31 +0200
On 2016-07-11 10:25 +0200, Sven Joachim wrote:
> On 2016-03-14 17:27 +0100, Sven Joachim wrote:
>
> Looking at it again, there _is_ a small bug in ncurses, the trailing
> space should not have been there in the first place. It is in the
> include/Caps* files and has been there forever (at least since ncurses
> 1.9.9g):
>
> ,---- [ include/Caps* ]
> | #%Whenever possible, capnames are chosen to be the same as or similar to
> | #%the ANSI X3.64-1979 standard (now superseded by ECMA-48, which uses
> `---- ^^ note trailing space here
>
> Running "sed -i -e 's/which uses $/which uses/' include/Caps*" fixes that.
Thomas, could you please do that upstream?
Cheers,
Sven
Information forwarded
to debian-bugs-dist@lists.debian.org, Craig Small <csmall@debian.org>: Bug#818067; Package src:ncurses.
(Sat, 13 Aug 2016 18:03:03 GMT) (full text, mbox, link).
Acknowledgement sent
to dickey@his.com:
Extra info received and forwarded to list. Copy sent to Craig Small <csmall@debian.org>.
(Sat, 13 Aug 2016 18:03:03 GMT) (full text, mbox, link).
On Sat, Aug 13, 2016 at 07:42:31PM +0200, Sven Joachim wrote:
> On 2016-07-11 10:25 +0200, Sven Joachim wrote:
>
> > On 2016-03-14 17:27 +0100, Sven Joachim wrote:
> >
> > Looking at it again, there _is_ a small bug in ncurses, the trailing
> > space should not have been there in the first place. It is in the
> > include/Caps* files and has been there forever (at least since ncurses
> > 1.9.9g):
> >
> > ,---- [ include/Caps* ]
> > | #%Whenever possible, capnames are chosen to be the same as or similar to
> > | #%the ANSI X3.64-1979 standard (now superseded by ECMA-48, which uses
> > `---- ^^ note trailing space here
> >
> > Running "sed -i -e 's/which uses $/which uses/' include/Caps*" fixes that.
>
> Thomas, could you please do that upstream?
done (thanks for the reminder)
--
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.netftp://invisible-island.net
Removed blocking bug(s) of 818067: 794965
Request was from Sven Joachim <svenjoac@gmx.de>
to control@bugs.debian.org.
(Sun, 11 Sep 2016 09:30:04 GMT) (full text, mbox, link).
Added tag(s) pending.
Request was from Sven Joachim <svenjoac@gmx.de>
to control@bugs.debian.org.
(Sun, 11 Sep 2016 10:12:16 GMT) (full text, mbox, link).
Message sent on
to Niels Thykier <niels@thykier.net>:
Bug#818067.
(Sun, 11 Sep 2016 10:12:23 GMT) (full text, mbox, link).
tag 818067 pending
thanks
Hello,
Bug #818067 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:
http://git.debian.org/?p=collab-maint/ncurses.git;a=commitdiff;h=7197f15
---
commit 7197f1553b2d5c64aa7c95bcd77c483cc496fac5
Author: Sven Joachim <svenjoac@gmx.de>
Date: Sun Sep 11 11:24:14 2016 +0200
Close bug #818067
In the 20160813 patchlevel trailing spaces were removed from the input
files, so the result should no longer depend on which shell is
providing /bin/sh.
diff --git a/debian/changelog b/debian/changelog
index c062ed3..d3a12ec 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,8 @@
ncurses (6.0+20160910-1) UNRELEASED; urgency=low
* New upstream patchlevel.
+ - Trim trailing blanks from include/Caps*, to work around a problem
+ in sed (Closes: #818067).
-- Sven Joachim <svenjoac@gmx.de> Sun, 11 Sep 2016 11:17:47 +0200
Reply sent
to Sven Joachim <svenjoac@gmx.de>:
You have taken responsibility.
(Wed, 14 Sep 2016 19:09:04 GMT) (full text, mbox, link).
Notification sent
to Niels Thykier <niels@thykier.net>:
Bug acknowledged by developer.
(Wed, 14 Sep 2016 19:09:04 GMT) (full text, mbox, link).
Subject: Bug#818067: fixed in ncurses 6.0+20160910-1
Date: Wed, 14 Sep 2016 19:06:07 +0000
Source: ncurses
Source-Version: 6.0+20160910-1
We believe that the bug you reported is fixed in the latest version of
ncurses, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 818067@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sven Joachim <svenjoac@gmx.de> (supplier of updated ncurses package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 14 Sep 2016 20:09:34 +0200
Source: ncurses
Binary: libtinfo5 libtinfo5-udeb libncurses5 libtinfo-dev libtinfo5-dbg libncurses5-dev libncurses5-dbg libncursesw5 libncursesw5-dev libncursesw5-dbg lib64ncurses5 lib64ncurses5-dev lib32ncurses5 lib32ncurses5-dev lib32ncursesw5 lib32ncursesw5-dev lib64tinfo5 lib32tinfo5 lib32tinfo-dev ncurses-bin ncurses-base ncurses-term ncurses-examples ncurses-doc
Architecture: source
Version: 6.0+20160910-1
Distribution: unstable
Urgency: low
Maintainer: Craig Small <csmall@debian.org>
Changed-By: Sven Joachim <svenjoac@gmx.de>
Description:
lib32ncurses5 - shared libraries for terminal handling (32-bit)
lib32ncurses5-dev - developer's libraries for ncurses (32-bit)
lib32ncursesw5 - shared libraries for terminal handling (wide character support) (
lib32ncursesw5-dev - developer's libraries for ncursesw (32-bit)
lib32tinfo-dev - developer's library for the low-level terminfo library (32-bit)
lib32tinfo5 - shared low-level terminfo library for terminal handling (32-bit)
lib64ncurses5 - shared libraries for terminal handling (64-bit)
lib64ncurses5-dev - developer's libraries for ncurses (64-bit)
lib64tinfo5 - shared low-level terminfo library for terminal handling (64-bit)
libncurses5 - shared libraries for terminal handling
libncurses5-dbg - debugging/profiling libraries for ncurses
libncurses5-dev - developer's libraries for ncurses
libncursesw5 - shared libraries for terminal handling (wide character support)
libncursesw5-dbg - debugging/profiling libraries for ncursesw
libncursesw5-dev - developer's libraries for ncursesw
libtinfo-dev - developer's library for the low-level terminfo library
libtinfo5 - shared low-level terminfo library for terminal handling
libtinfo5-dbg - debugging/profiling library for the low-level terminfo library
libtinfo5-udeb - shared low-level terminfo library for terminal handling - udeb (udeb)
ncurses-base - basic terminal type definitions
ncurses-bin - terminal-related programs and man pages
ncurses-doc - developer's guide and documentation for ncurses
ncurses-examples - test programs and examples for ncurses
ncurses-term - additional terminal type definitions
Closes: 818067
Changes:
ncurses (6.0+20160910-1) unstable; urgency=low
.
* New upstream patchlevel.
- Trim trailing blanks from include/Caps*, to work around a problem
in sed (Closes: #818067).
* Invoke configure via relative paths to prevent the build path from
showing up in binaries.
* Enable parallel builds.
Checksums-Sha1:
625d6a66ea22b624e3ecc4246d2f95f337888372 3748 ncurses_6.0+20160910-1.dsc
51f25ab5cde592ebe82b122ec40c53d4ba5ec88b 3178246 ncurses_6.0+20160910.orig.tar.gz
43f54fc765ccdff1ced7f4a1a6a0e5d40c0bc934 52644 ncurses_6.0+20160910-1.debian.tar.xz
Checksums-Sha256:
8dcac2c54f47b1f1034408e6f24a5d0b661ca0244913925b2c6bbe0fd311e0df 3748 ncurses_6.0+20160910-1.dsc
c965297dfd4941da8ff677780c49fe161d6a9177eef3d2b8c2e54aae510b2be3 3178246 ncurses_6.0+20160910.orig.tar.gz
4b88a0f47c1c28e68f6c077b4a9c1ae96a4ad19e777faca3008ca6426906dc7a 52644 ncurses_6.0+20160910-1.debian.tar.xz
Files:
b52241aaab2378b6f7cb0aa768c231b9 3748 libs required ncurses_6.0+20160910-1.dsc
69c391833610de5621986468e697e470 3178246 libs required ncurses_6.0+20160910.orig.tar.gz
da57f0f1c51ad1d5a5b46b638b349c06 52644 libs required ncurses_6.0+20160910-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQItBAEBCgAXBQJX2ZMbEBxzdmVuam9hY0BnbXguZGUACgkQOxBucY1rMaxg+w/+
KDU3GER3n89z6ZRtR6RzqpC0vjgNXiy9266nt38lHMc0XJjs/krtUcLiiui/WTX6
NVTRmtq7zBbpAwfCgHrEvaPzPhuQ3NhGll88Bxo28B05c1Glu5y9H8ZrFFHggS3c
ctaEmHBAkPWNrSdSG6k22uKokRqX8lF7xyR7Q8DOKbepfAM8pvbvYw25frYMeFGb
Ja+8dCMN0acp10mMH4DGQSF5/O0s4DGPcI1u5519pw3PshK+T7EbGhFvYRi/rpa7
7JBSHQIwk1FcjJBAhhMVOkJaf4lNfURgCCk1YELCAKB15RkVwClL95l6UMybGHXt
ND+3WkUicDkuAb1ugY6qCKKshsQtiCCpTD4HNyDxF+2AeO0yNXImbBdWzo7omlrw
0aMdJcyKyxzDeeC1fDJBCZbiMAyhZtJnD+NcclRoNtlJzuZek4Wn6ieG4cscqca2
WOAwlQI9GiFy09VvOdBvwm/ravNNHpd5Y1zZbyJ4OAVMGjIi4JhblrIe9dd0wqZG
qUD53OZ+XjSKuOhVhpzKiLffpDE9JuOjh1Wi3Ol7BVhfJJSxz69DWWnOSZmpnA4p
isHJ7CXl1CPOaji2LX4iJXbRG/EefocafWc97A+eUE36VRzuE1tAwB+Y8k/bieeO
RV/IG+YFpOcwINNdeeU1Fi6yyOYINbq7ASXkcn6VhCc=
=TPo8
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Sat, 29 Oct 2016 07:30:41 GMT) (full text, mbox, link).
Debbugs is free software and licensed under the terms of the GNU General
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.