1020887">

Debian Bug report logs - #1020887
checkpw: reproducible-builds: buildid differences in /usr/bin/checkpw

version graph

Package: src:checkpw; Maintainer for src:checkpw is Debian QA Group <packages@qa.debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Tue, 27 Sep 2022 22:57:01 UTC

Severity: normal

Tags: patch

Fixed in version checkpw/1.02-1.2

Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Gerrit Pape <pape@smarden.org>:
Bug#1020887; Package src:checkpw. (Tue, 27 Sep 2022 22:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Gerrit Pape <pape@smarden.org>. (Tue, 27 Sep 2022 22:57:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: checkpw: reproducible-builds: buildid differences in /usr/bin/checkpw
Date: Tue, 27 Sep 2022 15:53:13 -0700
[Message part 1 (text/plain, inline)]
Source: checkpw
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The buildid varies when built from a different path for
/usr/bin/checkpw:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/checkpw.html

The attached patch to debian/rules fixes this by adding
-ffile-prefix-map to CFLAGS.

Alternately, updating to a newer debhelper compat level might fix this.

According to my local tests, with this patch applied, and the patch
submitted in 2015 for bug #777299, checkpw should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining checkpw!

live well,
  vagrant
[0002-debian-rules-Add-ffile-prefix-map-to-CFLAGS-to-avoid.patch (text/x-diff, inline)]
From d8bc459cbc3076dec093f7bd5b3db31a27999fdf Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 27 Sep 2022 22:47:32 +0000
Subject: [PATCH 2/2] debian/rules: Add -ffile-prefix-map to CFLAGS to avoid
 embedding build paths.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index f5b7c42..13274a9 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,8 @@
 
 CC =gcc
 CFLAGS =-g -O2 -Wall
+# Avoid embedding build paths for reproducible builds
+CFLAGS += -ffile-prefix-map=$(CURDIR)=.
 LDFLAGS =
 STRIP =strip
 
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Gerrit Pape <pape@smarden.org>:
Bug#1020887; Package src:checkpw. (Thu, 20 Oct 2022 18:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Gerrit Pape <pape@smarden.org>. (Thu, 20 Oct 2022 18:57:03 GMT) (full text, mbox, link).


Message #10 received at 1020887@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: 1020887@bugs.debian.org, 777299@bugs.debian.org
Subject: Re: checkpw: NMU for reproducible-builds patches
Date: Thu, 20 Oct 2022 11:55:49 -0700
[Message part 1 (text/plain, inline)]
Control: tags 1020887 pending
Control: tags 777299 pending

I've submitted an NMU to DELAYED/10 fixing the timestamp and build path
issues:

diff -u checkpw-1.02/debian/changelog checkpw-1.02/debian/changelog
--- checkpw-1.02/debian/changelog
+++ checkpw-1.02/debian/changelog
@@ -1,3 +1,16 @@
+checkpw (1.02-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * Remove timestamps from the build system (Closes: #777299)
+
+  [ Vagrant Cascadian ]
+  * debian/rules: Add -ffile-prefix-map to CFLAGS to avoid embedding build
+    paths. (Closes: #1020887)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 20 Oct 2022 11:41:55 -0700
+
 checkpw (1.02-1.1) unstable; urgency=high
 
   * Non-maintainer upload.
diff -u checkpw-1.02/debian/implicit checkpw-1.02/debian/implicit
--- checkpw-1.02/debian/implicit
+++ checkpw-1.02/debian/implicit
@@ -35,7 +35,7 @@
 	    debian/$*/usr/share/doc/$*/changelog'
 	@test -s debian/$*/usr/share/doc/$*/changelog || \
 	  sh -cx 'rm -f debian/$*/usr/share/doc/$*/changelog'
-	@gzip -9 debian/$*/usr/share/doc/$*/changelog*
+	@gzip -9n debian/$*/usr/share/doc/$*/changelog*
 %.deb-docs-docs: %.deb-docs-base
 	@for i in `cat debian/$*.docs 2>/dev/null || :`; do \
 	  if test -d $$i; then \
@@ -54,7 +54,7 @@
 	@if test -r debian/$*.NEWS.Debian; then \
 	  sh -cx 'install -m0644 debian/$*.NEWS.Debian \
 	    debian/$*/usr/share/doc/$*/NEWS.Debian && \
-	      gzip -9 debian/$*/usr/share/doc/$*/NEWS.Debian'; \
+	      gzip -9n debian/$*/usr/share/doc/$*/NEWS.Debian'; \
 	fi
 %.deb-docs-examples: %.deb-docs-docs
 	@rm -rf debian/$*/usr/share/doc/$*/examples
diff -u checkpw-1.02/debian/rules checkpw-1.02/debian/rules
--- checkpw-1.02/debian/rules
+++ checkpw-1.02/debian/rules
@@ -2,6 +2,8 @@
 
 CC =gcc
 CFLAGS =-g -O2 -Wall
+# Avoid embedding build paths for reproducible builds
+CFLAGS += -ffile-prefix-map=$(CURDIR)=.
 LDFLAGS =
 STRIP =strip
 
@@ -62,7 +64,7 @@
 	install -d -m0755 '$(DIR)'/usr/share/man/man8
 	install -m0644 debian/checkpw.8 debian/checkapoppw.8 \
 	  '$(DIR)'/usr/share/man/man8/
-	gzip -9 '$(DIR)'/usr/share/man/man8/*.8
+	gzip -9n '$(DIR)'/usr/share/man/man8/*.8
 	# service directories
 	for i in pop apop; do \
 	  install -d -m0755 '$(DIR)'/usr/share/doc/checkpw/etc/$$i/log && \


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Added tag(s) pending. Request was from Vagrant Cascadian <vagrant@reproducible-builds.org> to 1020887-submit@bugs.debian.org. (Thu, 20 Oct 2022 18:57:03 GMT) (full text, mbox, link).


Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Sun, 30 Oct 2022 19:51:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sun, 30 Oct 2022 19:51:03 GMT) (full text, mbox, link).


Message #17 received at 1020887-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1020887-close@bugs.debian.org
Subject: Bug#1020887: fixed in checkpw 1.02-1.2
Date: Sun, 30 Oct 2022 19:50:08 +0000
Source: checkpw
Source-Version: 1.02-1.2
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
checkpw, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020887@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated checkpw package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 20 Oct 2022 11:41:55 -0700
Source: checkpw
Architecture: source
Version: 1.02-1.2
Distribution: unstable
Urgency: medium
Maintainer: Gerrit Pape <pape@smarden.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 777299 1020887
Changes:
 checkpw (1.02-1.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * Remove timestamps from the build system (Closes: #777299)
 .
   [ Vagrant Cascadian ]
   * debian/rules: Add -ffile-prefix-map to CFLAGS to avoid embedding build
     paths. (Closes: #1020887)
Checksums-Sha1:
 ea5ec561f45e198363b2835ffcebcf2c256a46f5 1145 checkpw_1.02-1.2.dsc
 afd0abc09f2a47b75978620384855a2a136b1d2f 7064 checkpw_1.02-1.2.diff.gz
Checksums-Sha256:
 9bc402713ac02a09bfafaa3f14bac8203c2b2874cd69e0cfc8df1837ee1e4e58 1145 checkpw_1.02-1.2.dsc
 7daa6f42cb3934c30f2f0d4fccc2a86f082300c7d8df991a5f7cbd324ace154d 7064 checkpw_1.02-1.2.diff.gz
Files:
 4df28d5ad5c9f8ca635d6119fae05712 1145 mail optional checkpw_1.02-1.2.dsc
 e40b7d0f06fbbb958c2bb41d75301275 7064 mail optional checkpw_1.02-1.2.diff.gz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY1GYdSAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqmgdAQD+QIhbpY2DxPy/
jvi42kw2dVI8zceNumN51MYlStOlbgEAyMijZ8ioos6OmbMipPLeeZUZN+e9EzHh
skEFQM7FFgs=
=4vV4
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 27 Dec 2022 07:28:47 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:39:46 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.