1020814">

Debian Bug report logs - #1020814
dradio: reproducible-builds: build path embedded in /usr/bin/dradio

version graph

Package: src:dradio; Maintainer for src:dradio is Alejandro Garrido Mota <garridomota@gmail.com>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Tue, 27 Sep 2022 01:30:02 UTC

Severity: normal

Tags: patch

Fixed in version dradio/3.8-2.1

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Alejandro Garrido Mota <garridomota@gmail.com>:
Bug#1020814; Package src:dradio. (Tue, 27 Sep 2022 01:30:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Alejandro Garrido Mota <garridomota@gmail.com>. (Tue, 27 Sep 2022 01:30:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: dradio: reproducible-builds: build path embedded in /usr/bin/dradio
Date: Mon, 26 Sep 2022 18:26:34 -0700
[Message part 1 (text/plain, inline)]
Source: dradio
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/dradio:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/dradio.html

  /build/1st/dradio-3.8/src/dradio.c:49
  vs.
  /build/2/dradio-3.8/2nd/src/dradio.c:49

The attached patch to debian/rules fixes this by adding a
dh_auto_configure override passing -ffile-prefix-map via CFLAGS.

According to my local tests, with this patch applied dradio should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining dradio!

live well,
  vagrant
[0001-debian-rules-Add-dh_auto_configure-override-to-pass-.patch (text/x-diff, inline)]
From 9d7f10a02be23b49b8e423dc91d89a3e320c7aa8 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 27 Sep 2022 01:23:38 +0000
Subject: [PATCH] debian/rules: Add dh_auto_configure override to pass
 -ffile-prefix-map to avoid embedding build paths.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 2d33f6a..fce6baf 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,3 +2,6 @@
 
 %:
 	dh $@
+
+override_dh_auto_configure:
+	dh_auto_configure -- CFLAGS="$(CFLAGS) -ffile-prefix-map=$(CURDIR)=."
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Alejandro Garrido Mota <garridomota@gmail.com>:
Bug#1020814; Package src:dradio. (Thu, 06 Oct 2022 17:42:04 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Alejandro Garrido Mota <garridomota@gmail.com>. (Thu, 06 Oct 2022 17:42:04 GMT) (full text, mbox, link).


Message #10 received at 1020814@bugs.debian.org (full text, mbox, wrote: > tags 1020814 + pending patch > thanks > > I've just uploaded dradio 3.8-2.1 to DELAYED/10: > > dradio (3.8-2.1) unstable; urgency=medium > . > * Non-maintainer upload. > * Pass dpkg-buildflags(1) to upstream's build system to ensure that > reproducibility-related CFLAGS are used; this was based on a patch by > Vagrant Cascadian. This required the disabling of -Werror=format-security > via DEB_BUILD_MAINT_OPTIONS due to suspicious calls to snprintf(3). > (Closes: #1020814) > > The full debdiff is attached. > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org / chris-lamb.co.uk > `- &subject=Re: dradio: reproducible-builds: build path embedded in /usr/bin/dradio&In-Reply-To=<6669aacb-0696-406f-8017-3fec78f0c538@app.fastmail.com>&References=<6669aacb-0696-406f-8017-3fec78f0c538@app.fastmail.com>">reply):

From: "Chris Lamb" <lamby@debian.org>
To: 1020814@bugs.debian.org, 1020814-submitter@bugs.debian.org
Subject: Re: dradio: reproducible-builds: build path embedded in /usr/bin/dradio
Date: Thu, 06 Oct 2022 10:38:03 -0700
[Message part 1 (text/plain, inline)]
tags 1020814 + pending patch
thanks

I've just uploaded dradio 3.8-2.1 to DELAYED/10:
  
  dradio (3.8-2.1) unstable; urgency=medium
  .
    * Non-maintainer upload.
    * Pass dpkg-buildflags(1) to upstream's build system to ensure that
      reproducibility-related CFLAGS are used; this was based on a patch by
      Vagrant Cascadian. This required the disabling of -Werror=format-security
      via DEB_BUILD_MAINT_OPTIONS due to suspicious calls to snprintf(3).
      (Closes: #1020814)

The full debdiff is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[dradio_3.8-2.1_amd64.debdiff.txt (text/plain, attachment)]

Added tag(s) pending. Request was from "Chris Lamb" <lamby@debian.org> to control@bugs.debian.org. (Thu, 06 Oct 2022 17:42:05 GMT) (full text, mbox, link).


Message sent on to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug#1020814. (Thu, 06 Oct 2022 17:42:07 GMT) (full text, mbox, link).


Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Sun, 16 Oct 2022 18:39:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sun, 16 Oct 2022 18:39:03 GMT) (full text, mbox, link).


Message #20 received at 1020814-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1020814-close@bugs.debian.org
Subject: Bug#1020814: fixed in dradio 3.8-2.1
Date: Sun, 16 Oct 2022 18:34:39 +0000
Source: dradio
Source-Version: 3.8-2.1
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
dradio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020814@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated dradio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 06 Oct 2022 10:32:46 -0700
Source: dradio
Binary: dradio dradio-dbgsym
Architecture: source amd64
Version: 3.8-2.1
Distribution: unstable
Urgency: medium
Maintainer: Alejandro Garrido Mota <garridomota@gmail.com>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 dradio     - danmarks Radio netradio, podcast, and TV player
Closes: 1020814
Changes:
 dradio (3.8-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Pass dpkg-buildflags(1) to upstream's build system to ensure that
     reproducibility-related CFLAGS are used; this was based on a patch by
     Vagrant Cascadian. This required the disabling of -Werror=format-security
     via DEB_BUILD_MAINT_OPTIONS due to suspicious calls to snprintf(3).
     (Closes: #1020814)
Checksums-Sha1:
 cb6c1125842b7f90e8f3d20bbefd5db0a6459b4a 1739 dradio_3.8-2.1.dsc
 1b3544191c6859defd2d04fa2d35735076adc7c5 119703 dradio_3.8.orig.tar.gz
 483962ff739b7817a4acc90493c6608b7b96a045 2096 dradio_3.8-2.1.debian.tar.xz
 aa2c614db6e9f3a1c47e3248c1793b6d9c65659d 56400 dradio-dbgsym_3.8-2.1_amd64.deb
 05cc6a926645f5f29138eeedafed8e7de5a40f9c 6863 dradio_3.8-2.1_amd64.buildinfo
 abeee787f5bbf0af17114504970523291b057c27 25580 dradio_3.8-2.1_amd64.deb
Checksums-Sha256:
 310e45e85ecde12e519e1362644ef54e97eabb97276981f4da7f5e76222f880a 1739 dradio_3.8-2.1.dsc
 74c51e693dfcab8656c1dc3c2ce7c8e92c6677db3003d62c335c1a095c682bf7 119703 dradio_3.8.orig.tar.gz
 501c1821c36d4dcbacfc8e8b8d829f15d1f76e4e992546960229e3fae9cd9088 2096 dradio_3.8-2.1.debian.tar.xz
 cc9c3d0b024f414575496b00ee7020dc7bc71726d2a0967717f18be0b159a49b 56400 dradio-dbgsym_3.8-2.1_amd64.deb
 f7f85da597a64ad6a4b9abc2d7e3674718e4cd5ea4dbf84399e90106a0f2bc4f 6863 dradio_3.8-2.1_amd64.buildinfo
 a7c177640aca7269ac597a5d385f0827da1f2b8df9efe32c41e070e2c0d59da2 25580 dradio_3.8-2.1_amd64.deb
Files:
 38ee3e81dc3fccc09796ead83ed882db 1739 sound extra dradio_3.8-2.1.dsc
 2532cee6b77f00c15a484fde4851d722 119703 sound extra dradio_3.8.orig.tar.gz
 b1e045409ca0f653ddbb78024b252942 2096 sound extra dradio_3.8-2.1.debian.tar.xz
 01703ea1194b819e32e88fdd85bc96a8 56400 debug optional dradio-dbgsym_3.8-2.1_amd64.deb
 8a6caceef061b21b753954a9992c2ef9 6863 sound extra dradio_3.8-2.1_amd64.buildinfo
 a51ff780de59c84172ac15a46afcef5c 25580 sound extra dradio_3.8-2.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmM/EbkACgkQHpU+J9Qx
Hligfw//ZWiN35dXgcXIL/Be3kXnaKuzdWNHMXYuigRgJignHvaMXLqJZdKU4GIf
u1HkvMWcAq896flPRp13RHIwBAnOf9PuB27hYDH02fyfWBm3mIuktv/4rJbd4lsh
0gexwASefG7xYDCmlTGvdTcYAism4dv4VgtSniUO7h8+/gF2NnUtiy9SAKZXR1A5
u1H4jN9iL8T6Pjsb8zHXYTSXcyYrPhA1848ER8CLvU41Zw5WRwWC0EWTgde+AoY9
1DlOPxEP6Dmr7x4wx3lqHNP1ns8m1qt5EH+emcnRTYtbVkdqxabx5YGF+HQhXvPS
ArW+p6ay1BPdjuvDEW+5Lu43e1UYbiDCEKAck+LgjmPJt3voarWpPoByKk7G6nLJ
upG9MGJ6zZ0sr+Lzo+awhhe4b+hO22ZlHbqFvR8fv85N0DgRalPDL1MHFt+33nZA
3N4O8HlqbJB/t20njim72VTL9Oy3JCbiZKsOLYgw2lz2I/LVsah450Wymw0RvpA1
SflCuvpMnbhjm+LPqtqq94cKhl0cDvfo/VNtSBZ2JFgeT8GmUldzs4oIc+2oepu1
5/J+7cDiRZj+rdUeS5426ju0t5tD6eKBZReuq5BhFgx0NLeB317xDA05CKRKx4QA
YH3j4X3uzR+7p+FffxpNcHygfIDv2fs4q3Ky2X88luaKfbODFQs=
=pWbZ
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 14 Nov 2022 07:26:53 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:20:01 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.