1020754">

Debian Bug report logs - #1020754
shapetools: reproducible-builds: Embedded build path in sttk.h

version graph

Package: src:shapetools; Maintainer for src:shapetools is Matthias Klose <doko@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Mon, 26 Sep 2022 00:30:01 UTC

Severity: normal

Tags: patch

Fixed in version shapetools/1.4pl6-16

Done: Matthias Klose <doko@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Matthias Klose <doko@debian.org>:
Bug#1020754; Package src:shapetools. (Mon, 26 Sep 2022 00:30:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Matthias Klose <doko@debian.org>. (Mon, 26 Sep 2022 00:30:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, vs. > #define·ST_ENV_DEFAULT» "/build/2/shapetools-1.4pl6/2nd/debian/tmp/usr" > > The attached patch fixes this in debian/rules by removing the build path > and debian/tmp from sttk.h. It is unclear to me if it would be better to > replace it with a placeholder value, or to leave the debian/tmp part; it > really depends how this define is used. > > With this patch applied shapetools should build reproducibly on > tests.reproducible-builds.org! > > Thanks for maintaining shapetools! > > live well, > vagrant &In-Reply-To=<875yhb9dzm.fsf@contorta>">reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: shapetools: reproducible-builds: Embedded build path in sttk.h
Date: Sun, 25 Sep 2022 17:27:25 -0700
[Message part 1 (text/plain, inline)]
Source: shapetools
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/include/sttk.h:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/shapetools.html

  #define·ST_ENV_DEFAULT»  "/build/1st/shapetools-1.4pl6/debian/tmp/usr"
  vs.
  #define·ST_ENV_DEFAULT»  "/build/2/shapetools-1.4pl6/2nd/debian/tmp/usr"

The attached patch fixes this in debian/rules by removing the build path
and debian/tmp from sttk.h. It is unclear to me if it would be better to
replace it with a placeholder value, or to leave the debian/tmp part; it
really depends how this define is used.

With this patch applied shapetools should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining shapetools!

live well,
  vagrant
[0001-debian-rules-Remove-build-path-from-sttk.h.patch (text/x-diff, inline)]
From 57526fa7f4a3f45661247021c4cceb6a919de4b7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 26 Sep 2022 00:11:40 +0000
Subject: [PATCH 1/2] debian/rules: Remove build path from sttk.h.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index f7df25f..268b2e1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -363,6 +363,8 @@ binary-arch: build install
 	dh_installchangelogs -p$(p_atfs) CHANGES-1.4
 	dh_strip -a -X.a
 	dh_compress -a
+	# Remove build path for reproducible builds
+	sed -i -e "s,$(CURDIR)/debian/tmp,,g" debian/atfs-dev/usr/include/sttk.h
 	dh_fixperms -a
 	LD_LIBRARY_PATH=$(d_atfslib)/usr/lib:$$LD_LIBRARY_PATH \
 		dh_makeshlibs -V -p$(p_atfslib)
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Reply sent to Matthias Klose <doko@debian.org>:
You have taken responsibility. (Wed, 23 Aug 2023 14:39:05 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Wed, 23 Aug 2023 14:39:05 GMT) (full text, mbox, link).


Message #10 received at 1020754-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1020754-close@bugs.debian.org
Subject: Bug#1020754: fixed in shapetools 1.4pl6-16
Date: Wed, 23 Aug 2023 14:36:41 +0000
Source: shapetools
Source-Version: 1.4pl6-16
Done: Matthias Klose <doko@debian.org>

We believe that the bug you reported is fixed in the latest version of
shapetools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020754@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthias Klose <doko@debian.org> (supplier of updated shapetools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 23 Aug 2023 16:03:32 +0200
Source: shapetools
Architecture: source
Version: 1.4pl6-16
Distribution: unstable
Urgency: medium
Maintainer: Matthias Klose <doko@debian.org>
Changed-By: Matthias Klose <doko@debian.org>
Closes: 1007676 1020754
Changes:
 shapetools (1.4pl6-16) unstable; urgency=medium
 .
   * Upgrade to 3.0 source format. Closes: #1007676.
   * Don't embed build path in sttk.h (Vagrant Cascadian). Closes: #1020754.
   * Bump standards version.
Checksums-Sha1:
 595dcbfc972b07f79ef87c2bf57476045d987818 1857 shapetools_1.4pl6-16.dsc
 8ac570fe9fcbfe8804198f8190b941423f5aa352 75172 shapetools_1.4pl6-16.debian.tar.xz
 e21aac9846ae76bf9613cc82f306183d15a83f92 6164 shapetools_1.4pl6-16_source.buildinfo
Checksums-Sha256:
 1fd2160ba7a85621643b37b17a70711ec7fa188204f5315a75bafb81f0dc76b3 1857 shapetools_1.4pl6-16.dsc
 2a6145e133b2c17d43b6ba6e0777e36f097f90f514309834e5b1e58388a5b896 75172 shapetools_1.4pl6-16.debian.tar.xz
 8285e85c69c1f0da87aad1e50d1dce3efbef071d5b30412e96e2194d6d13ee1e 6164 shapetools_1.4pl6-16_source.buildinfo
Files:
 d77c52253d1b02720c1785888f2ebf39 1857 devel optional shapetools_1.4pl6-16.dsc
 abd80c5afda40d92b9af0d3a7496d48c 75172 devel optional shapetools_1.4pl6-16.debian.tar.xz
 082808be847e721277b8293e61d860ec 6164 devel optional shapetools_1.4pl6-16_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE1WVxuIqLuvFAv2PWvX6qYHePpvUFAmTmE28QHGRva29AZGVi
aWFuLm9yZwAKCRC9fqpgd4+m9emqEACOogimd7xNj7FDfArGGbQK0ETWtrMZI3bg
fUd4xZhoBxMjzMWgANpBxuUawo/FI8NmNHyoVUyCjqU9HadikFOFi4a7x/WV9kDv
PIpGJOfP+n+GGFHavtYmcKwyW8eldWefe8hfl9+7KnDjpgfhpw6sTH6lYlmxLsii
Km71zy+EKDZdiH09bnmB4KHi8385V24CLX4yQyyk9P+CYg+X5fMqeiIH8GVpOT9U
O8q43j4TRvkw9R9GaqTc7wJF6BLTEPTd6ee+WTntoD6DR6ZGFVLvc/MFnwaDOeUL
9d6CAmLIJ110FZ/sKbb2yNpco4jvtmjn6ylF3tJx5E6XzoxGXsKZ42pKG9PGwmNL
g8d7J4DWp7vRt5WQvAXP9szgl0LlBG297gxFXU4h7THQZgJtkTuxpDLKFxT6pf9M
vAp9ZaO2NqNGyWUvP9srfn5WfxFh/ofZuAQPpqaElRxt0hASTHmCHqW8VYEAebTq
px+b3EFMhTea4V43qjcoim6E1/Yzqo1scuo14OOhsjxC7gftz2uLjKsvJQC2ubDK
rE2rNpas+DDz9yb3Pvq28ac9uG5y0nFebipCYOsVJRoqM/fLh22nW/mihUbSwxPd
1hM2j13aXZ/mBMnxnLcfmEwtc+7scOfogpce028xPwHCzwn67bLDZw8Njaggs7Us
7bCfUfX2/w==
=L75c
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 26 Sep 2023 07:29:30 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:27:40 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.