1020748">

Debian Bug report logs - #1020748
xcolmix: reproducible-builds: Embedded build path in /usr/bin/xcolmix

version graph

Package: src:xcolmix; Maintainer for src:xcolmix is Peter S Galbraith <psg@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Sun, 25 Sep 2022 22:57:01 UTC

Severity: normal

Tags: patch

Fixed in version xcolmix/1.07-10.1

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Peter S Galbraith <psg@debian.org>:
Bug#1020748; Package src:xcolmix. (Sun, 25 Sep 2022 22:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Peter S Galbraith <psg@debian.org>. (Sun, 25 Sep 2022 22:57:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: xcolmix: reproducible-builds: Embedded build path in /usr/bin/xcolmix
Date: Sun, 25 Sep 2022 15:55:41 -0700
[Message part 1 (text/plain, inline)]
Source: xcolmix
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/xcolmix:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xcolmix.html

  /build/1st/xcolmix-1.07/src/xcolmix.c:55
  vs.
  /build/2/xcolmix-1.07/2nd/src/xcolmix.c:55

The attached patch fixes this in debian/rules by passing
-ffile-prefix-map in STDCFLAGS.

Alternately, adapting this packge to use the default flags passed via
dpkg-buildflags should solve this issue as well.

With this patch applied xcolmix should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining xcolmix!

live well,
  vagrant
[0001-debian-rules-Pass-ffile-prefix-map-in-STDCFLAGS-to-a.patch (text/x-diff, inline)]
From 45adf65a2e6d6c70b78a91064ca468748e8d3c00 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 25 Sep 2022 22:50:54 +0000
Subject: [PATCH] debian/rules: Pass -ffile-prefix-map in STDCFLAGS to avoid
 embedding build path.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 6bfa94a..3bf23e2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,7 +10,7 @@ package=xcolmix
 build:
 	$(checkdir)
 
-	(cd src; make final STDLFLAGS="-L /usr/X11R6/lib" STDCFLAGS="-c -O2 -Wall $(XFINCDIR) -g")
+	(cd src; make final STDLFLAGS="-L /usr/X11R6/lib" STDCFLAGS="-c -O2 -Wall $(XFINCDIR) -g -ffile-prefix-map=$(CURDIR)=.")
 	touch build
 
 clean:
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Peter S Galbraith <psg@debian.org>:
Bug#1020748; Package src:xcolmix. (Thu, 06 Oct 2022 16:57:02 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Peter S Galbraith <psg@debian.org>. (Thu, 06 Oct 2022 16:57:02 GMT) (full text, mbox, link).


Message #10 received at 1020748@bugs.debian.org (full text, mbox, wrote: > tags 1020748 + pending patch > tags 999219 + pending patch > tags 988018 + pending patch > > thanks > > I've just uploaded xcolmix 1.07-10.1 to DELAYED/10: > > xcolmix (1.07-10.1) unstable; urgency=medium > . > * Non-maintainer upload. > * Add missing required debian/rules targets build-arch and/or build-indep. > (Closes: #999219) > * Apply a patch by Helmut Grohne to correctly pass cross-building tools to > Make. (Closes: #988018) > * Make the build reproducible by adapting debian/rules to use CFLAGS from > dpkg-buildflags(1), appending -ffile-prefix-map. (Closes: #1020748) > > The full debdiff is attached. > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` lamby@debian.org / chris-lamb.co.uk > `- &In-Reply-To=<166507502548.175584.16148178068298263093@copycat>">reply):

From: "Chris Lamb" <lamby@debian.org>
To: 1020748@bugs.debian.org, 1020748-submitter@bugs.debian.org, 999219@bugs.debian.org, 999219-submitter@bugs.debian.org, 988018@bugs.debian.org, 988018-submitter@bugs.debian.org
Subject: Re: xcolmix: reproducible-builds: Embedded build path in /usr/bin/xcolmix
Date: Thu, 06 Oct 2022 09:51:52 -0700
[Message part 1 (text/plain, inline)]
tags 1020748 + pending patch
tags 999219 + pending patch
tags 988018 + pending patch

thanks

I've just uploaded xcolmix 1.07-10.1 to DELAYED/10:
  
  xcolmix (1.07-10.1) unstable; urgency=medium
  .
    * Non-maintainer upload.
    * Add missing required debian/rules targets build-arch and/or build-indep.
      (Closes: #999219)
    * Apply a patch by Helmut Grohne to correctly pass cross-building tools to
      Make. (Closes: #988018)
    * Make the build reproducible by adapting debian/rules to use CFLAGS from
      dpkg-buildflags(1), appending -ffile-prefix-map. (Closes: #1020748)

The full debdiff is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[xcolmix_1.07-10.1_amd64.debdiff.txt (text/plain, attachment)]

Added tag(s) pending. Request was from "Chris Lamb" <lamby@debian.org> to control@bugs.debian.org. (Thu, 06 Oct 2022 16:57:06 GMT) (full text, mbox, link).


Message sent on to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug#1020748. (Thu, 06 Oct 2022 16:57:09 GMT) (full text, mbox, link).


Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Sun, 16 Oct 2022 17:51:07 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sun, 16 Oct 2022 17:51:07 GMT) (full text, mbox, link).


Message #20 received at 1020748-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1020748-close@bugs.debian.org
Subject: Bug#1020748: fixed in xcolmix 1.07-10.1
Date: Sun, 16 Oct 2022 17:47:28 +0000
Source: xcolmix
Source-Version: 1.07-10.1
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
xcolmix, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020748@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated xcolmix package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 06 Oct 2022 09:41:37 -0700
Source: xcolmix
Binary: xcolmix xcolmix-dbgsym
Architecture: source amd64
Version: 1.07-10.1
Distribution: unstable
Urgency: medium
Maintainer: Peter S Galbraith <psg@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 xcolmix    - an RGB colour mixer
Closes: 988018 999219 1020748
Changes:
 xcolmix (1.07-10.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Add missing required debian/rules targets build-arch and/or build-indep.
     (Closes: #999219)
   * Apply a patch by Helmut Grohne to correctly pass cross-building tools to
     Make. (Closes: #988018)
   * Make the build reproducible by adapting debian/rules to use CFLAGS from
     dpkg-buildflags(1), appending -ffile-prefix-map. (Closes: #1020748)
Checksums-Sha1:
 eec8271609504f02ce9714d5b40f1ebad77e0ca6 1670 xcolmix_1.07-10.1.dsc
 476f69c3bec8d3b37ab4fa945c7f12368b3f62ac 16460 xcolmix_1.07.orig.tar.gz
 aa619ccf44ec52af24e11cc92d9e884549ded633 4368 xcolmix_1.07-10.1.debian.tar.xz
 9066d1309678a67425f1b216ae4d1cd8320a5d92 21628 xcolmix-dbgsym_1.07-10.1_amd64.deb
 ae76b30965b017e672e582d8e1deb7efaea1cf74 6469 xcolmix_1.07-10.1_amd64.buildinfo
 87d8c01d3537a96e362b80c6b80541d61b28a4a1 11772 xcolmix_1.07-10.1_amd64.deb
Checksums-Sha256:
 c4a2290a54bdca64115c503f79b1b7e351c646bb9bbd4a7d77179ec824025ec0 1670 xcolmix_1.07-10.1.dsc
 1955698b1d9e62d9af8eef8f544e4509025785c49bef914296fa90987780ef17 16460 xcolmix_1.07.orig.tar.gz
 0beb159d6e84b2c6111d362e8cfd1684d2d7fad6fc8501e37c6564292b0e7b41 4368 xcolmix_1.07-10.1.debian.tar.xz
 9d40c34d306aa44c30a1d2a6e9dc381201445a1d9d66af020f5a7626f9a90bff 21628 xcolmix-dbgsym_1.07-10.1_amd64.deb
 dcd014125f7481e7deeddb6c130a48faa6fe03290e94269afcef726bb71e795f 6469 xcolmix_1.07-10.1_amd64.buildinfo
 1d143934a5359972def659e281e2c0dd99db71f24daf231130f6db1d35a7db92 11772 xcolmix_1.07-10.1_amd64.deb
Files:
 ee4c4444daab056d09129df4b598a992 1670 utils optional xcolmix_1.07-10.1.dsc
 8b1b3d5a012415cb402c0c7da8dd3423 16460 utils optional xcolmix_1.07.orig.tar.gz
 f2789239239768389194eafc2bebcc92 4368 utils optional xcolmix_1.07-10.1.debian.tar.xz
 c712cb1a57798b1f2a02b93c1bdb04ed 21628 debug optional xcolmix-dbgsym_1.07-10.1_amd64.deb
 b8b9d543f0c086dcecfe13babf476060 6469 utils optional xcolmix_1.07-10.1_amd64.buildinfo
 a6106110eae9d1056ccf0980fb228dd4 11772 utils optional xcolmix_1.07-10.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmM/B08ACgkQHpU+J9Qx
HljeCw//bIaTuD8mInCAheEsd7ptx7ZZ6Bff9ur7Em8+VrC19LxDjX13NtYnVjFg
sWQ/rTcxFhyRY6aPDPsy1HMGVxiKUqC/CWwLaKVPjp0+xfbhfOXSrpgmQT7lp6Rl
l7dfCbbYBJ9er2AWvCbAZpaRTEe2G9DS2OwYhUpPAF5cVzhjwz73vILKhGTUm9Rz
F1e3S2zUHyWGP+NKgXmWHU2oc0p+sFbZi4WWtmq9L/6rybZ5+rpc5Vk1/KgG9VFw
hSJskTR3Q2T8LXmX56QEcGd3bQ2QQkfWT82sJKspdxw4rXODORIKA0rFDZFBmqZy
xNir0EVSKVa3ZlkLvOXmiZ0auDBLxb9IxKfUIku92CNHVRJsKQsoRkRC0gu3/SE2
Q1OpsZcFFclfpQh4S9jQ1PZ0p6inYlzlNh2UHVI4cBv2W2YO9iQeq7d/ZNV3MGyS
jIRZtgbga1fsHOIbvnvltRU40+AvzFbg6COO+T7t/QYpQCqbIoyJ6lMtjhwRTPI1
5YKCqFuSgxq1W25DZd01Dd1g1p7QXzHZpRM2BES0m8GMFGKgubfNZM/q84vlVqbC
YoFQx68hMUha4efaAvIwPFPJDGCE/JgbTR+5PwdTXX9fcoU5Ojlm1tRN/f6GtkQZ
MIoIChRvJwrQ0VSqoa4AS2HsEAl60nt5x6zDTNcWKJG95XofJTw=
=98qV
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 19 Nov 2022 07:27:43 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:31:56 2025; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.