1018802">

Debian Bug report logs - #1018802
localechooser: reproducible builds: locale and parallelism trigger reproducibility issues

version graph

Package: src:localechooser; Maintainer for src:localechooser is Debian Install System Team <debian-boot@lists.debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Wed, 31 Aug 2022 01:21:02 UTC

Severity: normal

Tags: patch

Fixed in version localechooser/2.98

Done: Philip Hands <phil@hands.com>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#1018802; Package src:localechooser. (Wed, 31 Aug 2022 01:21:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Install System Team <debian-boot@lists.debian.org>. (Wed, 31 Aug 2022 01:21:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: localechooser: reproducible builds: locale and parallelism trigger reproducibility issues
Date: Tue, 30 Aug 2022 18:15:54 -0700
[Message part 1 (text/plain, inline)]
Source: localechooser
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The templates file contains randomness and locale-specific translations
dependent on the host system locale.

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/localechooser.html

  Indices-lo.UTF-8:·1,·2,·3,·4,·5,·6,·7,·8,·9,·10,·11, ... ,·50,·51
  vs.
  Indices-lo.UTF-8:·1,·3,·4,·5,·6,·7,·8,·9,·10,·11, ... ·50,·51,·2,·19

  Choices-lo.UTF-8:·Algeria,·Angola,·Benin,·Botswana, ... Eswatini,·Ethiopia,·Gabon ...
  vs.
  Choices-lo.UTF-8:·Algeria,·ປະເທດອັງໂກລາ,·Benin,·Botswana, ... Eswatini,·ເອທິໂອເປຍ,·Gabon ...

That attached patches fix this by passing --no-parallel to dh (parallism
was probably introduced in the switch from debhelper compat 9 to 13),
and by exporting LC_ALL=C.UTF-8 in debian/rules.


Thanks for maintaining localechooser!


live well,
  vagrant
[0001-debian-rules-Disable-parallelism-for-reproducible-bu.patch (text/x-diff, inline)]
From 29d0987352263aa2ebedf89c558ff2868dd777d4 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 31 Aug 2022 01:04:15 +0000
Subject: [PATCH 1/2] debian/rules: Disable parallelism for reproducible build.

---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 00100dd0..1eefc5fa 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,7 @@
 #! /usr/bin/make -f
 %:
-	dh $@
+	# Avoid parallelism triggering reproducibility issues
+	dh $@ --no-parallel
 
 PACKAGE=localechooser
 
-- 
2.30.2

[0002-debian-rules-Run-the-build-with-the-C.UTF-8-locale-f.patch (text/x-diff, inline)]
From 52ec1950fbeb4af707991b38556438b2e1296133 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 31 Aug 2022 01:04:41 +0000
Subject: [PATCH 2/2] debian/rules: Run the build with the C.UTF-8 locale for
 reproducible build.

---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 1eefc5fa..62c0230d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,9 @@ else # run after network-console for s390
 MENUITEMNUM=2110
 endif
 
+# Avoid locale-specific reproducibility issues
+export LC_ALL=C.UTF-8
+
 override_dh_clean:
 	rm -rf debian/pobuild debian/iso-codes debian/short-tmp
 	rm -rf debian/locales debian/sort-tmp
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#1018802; Package src:localechooser. (Thu, 01 Sep 2022 04:36:03 GMT) (full text, mbox, link).


Acknowledgement sent to Philip Hands <phil@hands.com>:
Extra info received and forwarded to list. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Thu, 01 Sep 2022 04:36:03 GMT) (full text, mbox, link).


Message #10 received at 1018802@bugs.debian.org (full text, mbox, which is a bit of a shame, as I had hoped to be able to show a before > and after with that test passing, but currently the repotest script > includes a '*.deb' that ignores udebs and so finds nothing to test :-/ > > I'll sort out an upload soon -- just thought I'd mention what I've done > so far to save others duplicating effort. > > Cheers, Phil. > -- > |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. > |-| http://www.hands.com/ http://ftp.uk.debian.org/ > |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY &References=<87edwxfc1h.fsf@contorta> <87a67jzpj1.fsf@hands.com>&In-Reply-To=<87a67jzpj1.fsf@hands.com>&subject=Re: Bug#1018802: localechooser: reproducible builds: locale and parallelism trigger reproducibility issues">reply):

From: Philip Hands <phil@hands.com>
To: 1018802@bugs.debian.org
Subject: Re: Bug#1018802: localechooser: reproducible builds: locale and parallelism trigger reproducibility issues
Date: Thu, 01 Sep 2022 06:28:50 +0200
[Message part 1 (text/plain, inline)]
Vagrant Cascadian <vagrant@reproducible-builds.org> writes:

> That attached patches fix this by passing --no-parallel to dh (parallism
> was probably introduced in the switch from debhelper compat 9 to 13),
> and by exporting LC_ALL=C.UTF-8 in debian/rules.

I've stuck this onto salsa:

  https://salsa.debian.org/philh/localechooser/-/commits/bug/1018802

which builds, and passed most of the tests:

  https://salsa.debian.org/philh/localechooser/-/pipelines/417953

which leads on to an openQA tests, where they also pass (apart from a
few that are broken in general at present):

https://openqa.debian.net/tests/overview?distri=debian&build=-salsa-417953:philh:localechooser:bug/1018802&groupid=13&version=salsa_testing

and where one can see here that it really is the patched version of
localechooser that's in use:

  https://openqa.debian.net/tests/73247#step/rescue/53

so that all looks fine to me.

Of course, the "most" regarding passing tests does not include repotest,
which is a bit of a shame, as I had hoped to be able to show a before
and after with that test passing, but currently the repotest script
includes a '*.deb' that ignores udebs and so finds nothing to test :-/

I'll sort out an upload soon -- just thought I'd mention what I've done
so far to save others duplicating effort.

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY
[signature.asc (application/pgp-signature, inline)]

Reply sent to Philip Hands <phil@hands.com>:
You have taken responsibility. (Thu, 01 Sep 2022 09:27:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Thu, 01 Sep 2022 09:27:03 GMT) (full text, mbox, link).


Message #15 received at 1018802-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1018802-close@bugs.debian.org
Subject: Bug#1018802: fixed in localechooser 2.98
Date: Thu, 01 Sep 2022 09:25:29 +0000
Source: localechooser
Source-Version: 2.98
Done: Philip Hands <phil@hands.com>

We believe that the bug you reported is fixed in the latest version of
localechooser, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1018802@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philip Hands <phil@hands.com> (supplier of updated localechooser package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 01 Sep 2022 10:18:21 +0200
Source: localechooser
Architecture: source
Version: 2.98
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Philip Hands <phil@hands.com>
Closes: 1018802
Changes:
 localechooser (2.98) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Vagrant Cascadian ]
   * fix reproducibility issues (closes:1018802)
Checksums-Sha1:
 ced8e581cf8c0b724a7fec38cda9dd9c3ae181c4 1811 localechooser_2.98.dsc
 1410ea72f3ae18e9f88c838df26d2c544f831a98 182776 localechooser_2.98.tar.xz
Checksums-Sha256:
 95536d3a652d734f6213eeb9376b1d04f2b1ac00dc9c339a3784ab4e29a4b1b3 1811 localechooser_2.98.dsc
 9f96905d49f0bed07aebf7010ce7b49f33dc0f2239bcce07b4add0005c615062 182776 localechooser_2.98.tar.xz
Files:
 736ac8f62158da33feef1e8f3190ded4 1811 debian-installer optional localechooser_2.98.dsc
 d95d14f757b83ecd6caa000215f4867e 182776 debian-installer optional localechooser_2.98.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE3/FBWs4yJ/zyBwfW0EujoAEl1cAFAmMQa8UPHHBoaWxAaGFu
ZHMuY29tAAoJENBLo6ABJdXAYzsQAKD4Nk9xxOPvHTDLrA0gOTrSXAis7cTXbMc1
Ow6X7bEx8VgVoXu7YjmoGPfljaO3F0pKJRx5eOkKMwj2zZLBsshX13z2B9DDgpv8
p98HHTj4nEj2+V/BhVNOpIjxYpyrd1zVZTtPCPfLBoXSoTG38QXMN8CbHNCZzJYj
zTIthxLwAilodxmlQMrjxkEBWDKlinp5LP3TXXDbIOoOpJo/v9nWLZOI5AkA4KWq
1ZMi7HsV9k/iPQ+F2iA/fmtIJPlMcKTBSHWGT/VRyilDI0lXeqsut5zdPoEOJYpC
BSW4xBwFG6BT71ONt5gRF4+KoKj6GbJvbTT18Wvs2bRmclp/7NOiQSc7XoRNvH2e
mcEHwN0MzeK0QbOv1zjFo/qlbkgsN3XZfj5jStNzwQTBCcjOp4GFWyggxAT4L/WC
xMXTfCJGO8h/rT4IolyScf9ySEbvVciPogJMaEnbdNR4iQ9oGQPz7g5jJKRF8qR3
d/tsGgsvrGR/TMkd9XD+FF+ViajAEK2QvS7pFv+U/W30SjGizEK8f3iWD/oU3355
JXvKWDJeoigiFA37qD2Vvi3x8rMbmzz3ESO08QqZcNCsMOEOcMilBNgkdb8ibvVN
hW3amdWTMae4PjnFnDSSUL16v+W9/+tamMzK6E3mEj/0pLRYw0BOqTTN21LrRN5l
Ac4mXc0d
=wUZv
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 30 Sep 2022 07:24:39 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 00:37:01 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.