1017372">

Debian Bug report logs - #1017372
plymouth: reproducible builds: year and week embedded in .pc files

version graph

Package: src:plymouth; Maintainer for src:plymouth is Laurent Bigonville <bigon@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Mon, 15 Aug 2022 02:27:02 UTC

Severity: normal

Tags: patch

Fixed in version plymouth/22.02.122-2

Done: Laurent Bigonville <bigon@debian.org>

Bug is archived. No further changes may be made.

Forwarded to https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/188

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Laurent Bigonville <bigon@debian.org>:
Bug#1017372; Package src:plymouth. (Mon, 15 Aug 2022 02:27:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Laurent Bigonville <bigon@debian.org>. (Mon, 15 Aug 2022 02:27:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: plymouth: reproducible builds: year and week embedded in .pc files
Date: Sun, 14 Aug 2022 19:21:56 -0700
[Message part 1 (text/plain, inline)]
Source: plymouth
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build year and week of year is embedded in several .pc files:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/plymouth.html

  /usr/lib/x86_64-linux-gnu/pkgconfig/ply-boot-client.pc

  Version:·22.32.
  vs.
  Version:·23.37.

This is because configure.ac sets the VERSION and PACKAGE_VERSION
variables based on the date and available git information. The attached
patch fixes this by using the version from debian/changelog.

If only the upstream version is preferred, then simply appending a sed
call could also be used:

  dpkg-parsechangelog --show-field Version | sed -e 's,-.*,,g'


With this patch applied, plymouth should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining plymouth!


live well,
  vagrant
[0001-configure.ac-Avoid-embedding-the-date-in-the-version.patch (text/x-diff, inline)]
From b94300e4304484aff3ee7d8a1f50875b341ba789 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 15 Aug 2022 02:11:30 +0000
Subject: [PATCH] configure.ac: Avoid embedding the date in the version.

Use the version from the last debian/changelog entry, otherwise the
build will differ if built on a different year and week and from git
builds vs. builds from source tarball.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6e00c0c..0de1856 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
 AC_INIT([plymouth],
-        m4_esyscmd_s([date +%y.%V.$(git rev-list $(git describe --abbrev=0)..HEAD --count) || echo 0]),
+        m4_esyscmd_s([dpkg-parsechangelog --show-field Version]),
         [https://gitlab.freedesktop.org/plymouth/plymouth/issues])
 AC_CONFIG_SRCDIR(src/main.c)
 AC_CONFIG_HEADER(config.h)
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Laurent Bigonville <bigon@debian.org>:
Bug#1017372; Package src:plymouth. (Thu, 22 Sep 2022 19:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Holger Levsen <holger@layer-acht.org>:
Extra info received and forwarded to list. Copy sent to Laurent Bigonville <bigon@debian.org>. (Thu, 22 Sep 2022 19:06:03 GMT) (full text, mbox, link).


Message #10 received at 1017372@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>
To: 1017372@bugs.debian.org
Subject: re: #1017372 plymouth: reproducible builds: year and week embedded in .pc files
Date: Thu, 22 Sep 2022 19:02:48 +0000
[Message part 1 (text/plain, inline)]
hi Laurent,

what do you think of the proposed patch?

for your convinience: (see https://bugs.debian.org/1017372
for more explainations but this is the diff)

Subject: [PATCH] configure.ac: Avoid embedding the date in the version.

Use the version from the last debian/changelog entry, otherwise the
build will differ if built on a different year and week and from git
builds vs. builds from source tarball.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6e00c0c..0de1856 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
 AC_INIT([plymouth],
-        m4_esyscmd_s([date +%y.%V.$(git rev-list $(git describe --abbrev=0)..HEAD --count) || echo 0]),
+        m4_esyscmd_s([dpkg-parsechangelog --show-field Version]),


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Some people say that the climate crisis  is something that we all have created,
but  that is not true,  because if everyone is guilty  then no one is to blame.
And someone is to blame.  Some people, some companies,  some decision-makers in
particular, have known exactly what priceless values they have been sacrificing
to continue making unimaginable amounts of money. (Greta Thunberg)
[signature.asc (application/pgp-signature, inline)]

Set Bug forwarded-to-address to 'https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/188'. Request was from Laurent Bigonville <bigon@debian.org> to control@bugs.debian.org. (Sun, 25 Sep 2022 07:45:02 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#1017372; Package src:plymouth. (Sun, 25 Sep 2022 08:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Laurent Bigonville <bigon@debian.org>:
Extra info received and forwarded to list. (Sun, 25 Sep 2022 08:09:03 GMT) (full text, mbox, link).


Message #17 received at 1017372@bugs.debian.org (full text, mbox, reply):

From: Laurent Bigonville <bigon@debian.org>
To: Holger Levsen <holger@layer-acht.org>, 1017372@bugs.debian.org
Subject: Re: Bug#1017372: #1017372 plymouth: reproducible builds: year and week embedded in .pc files
Date: Sun, 25 Sep 2022 10:04:40 +0200
Le 22/09/22 à 21:02, Holger Levsen a écrit :
> hi Laurent,
Hello Holger,
>
> what do you think of the proposed patch?
>
> for your convinience: (see https://bugs.debian.org/1017372
> for more explainations but this is the diff)
>
> Subject: [PATCH] configure.ac: Avoid embedding the date in the version.
>
> Use the version from the last debian/changelog entry, otherwise the
> build will differ if built on a different year and week and from git
> builds vs. builds from source tarball.
> ---
>   configure.ac | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6e00c0c..0de1856 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,5 +1,5 @@
>   AC_INIT([plymouth],
> -        m4_esyscmd_s([date +%y.%V.$(git rev-list $(git describe --abbrev=0)..HEAD --count) || echo 0]),
> +        m4_esyscmd_s([dpkg-parsechangelog --show-field Version]),
>
>
Thanks for the patch.

I've modified the command line to 'dpkg-parsechangelog --show-field 
Version | sed -e 's/-[^-]*$//' |  sed -e 's/^[0-9]*://'' to drop the 
epoch and debian revision from the version, and only keep the upstream 
one. (inspired from /usr/share/dpkg/pkg-info.mk)

I also opened a bug upstream: 
https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/188

Kind regards,

Laurent Bigonville




Reply sent to Laurent Bigonville <bigon@debian.org>:
You have taken responsibility. (Sun, 25 Sep 2022 11:51:08 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sun, 25 Sep 2022 11:51:08 GMT) (full text, mbox, link).


Message #22 received at 1017372-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1017372-close@bugs.debian.org
Subject: Bug#1017372: fixed in plymouth 22.02.122-2
Date: Sun, 25 Sep 2022 11:48:38 +0000
Source: plymouth
Source-Version: 22.02.122-2
Done: Laurent Bigonville <bigon@debian.org>

We believe that the bug you reported is fixed in the latest version of
plymouth, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1017372@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laurent Bigonville <bigon@debian.org> (supplier of updated plymouth package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 25 Sep 2022 10:22:04 +0200
Source: plymouth
Architecture: source
Version: 22.02.122-2
Distribution: unstable
Urgency: medium
Maintainer: Laurent Bigonville <bigon@debian.org>
Changed-By: Laurent Bigonville <bigon@debian.org>
Closes: 1017372
Changes:
 plymouth (22.02.122-2) unstable; urgency=medium
 .
   * d/p: Patch the configure.ac to avoid embedding the date in the version.
     Thanks to Holger Levsen <holger@layer-acht.org> (Closes: #1017372)
   * debian/plymouth.lintian-overrides: Fix mismatched-override
Checksums-Sha1:
 5fcf9f3231df796fd44aae834d0e47b736e3a6d8 2041 plymouth_22.02.122-2.dsc
 d7070f613d8f188c83ab0864666c82e4acf73309 28976 plymouth_22.02.122-2.debian.tar.xz
 c71a8e8dcc21be5983fa348baff318ce724e66f3 13458 plymouth_22.02.122-2_source.buildinfo
Checksums-Sha256:
 309ec6330acaee5200823ab64d1640781b8fa709d0b8a1f83ad95889078046c6 2041 plymouth_22.02.122-2.dsc
 6fccdbaf7fa030e24fc98878e5e0d31b6cae16529a6f8914d7ed934f95ec32c3 28976 plymouth_22.02.122-2.debian.tar.xz
 7614cccab30a79303123985b1ee21a58736dff83d7d2daaa4df01faf3e9e2158 13458 plymouth_22.02.122-2_source.buildinfo
Files:
 212f807508b445bc3b850b67fb8cabe3 2041 misc optional plymouth_22.02.122-2.dsc
 f094e1cb64407cc3f35ace3a638a94d7 28976 misc optional plymouth_22.02.122-2.debian.tar.xz
 561d16491dfba081eb4426bf951c923e 13458 misc optional plymouth_22.02.122-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEmRrdqQAhuF2x31DwH8WJHrqwQ9UFAmMwD+ARHGJpZ29uQGRl
Ymlhbi5vcmcACgkQH8WJHrqwQ9VHVQf/Ucjr/z2u5yy16s9x8YQNc6uYyFtxUZ80
stuJUPC5rVAMU7wbri5bzJYXYvP3Dbp3K85vFK3hgXLNv+fwCe/9G3nohXUr957k
/up4XcOYHnrwlZ/DZJx/uhJ2Xsfz6+RKFYkKwJh9gGHXsTqFT7OXBHwqvBBjHclS
c2z5TD8v0jJznLUnvfh8u+dWEIjFXIWO1G0Z1sggqyKZp5Y/ILA8XYbL7O8IiE69
VG0rBF1Em4QMGrmIR5bW2uotZS041ItKpKVac5LK8d5xaXL09EW/Dd7lg2wOg7fO
JSGkXKu9V61eBGyaQVAJIu6a2MN284dVgkde1WrjBOGcsKw+1+Ib3w==
=PcOI
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Laurent Bigonville <bigon@debian.org>:
Bug#1017372; Package src:plymouth. (Mon, 26 Sep 2022 13:27:04 GMT) (full text, mbox, link).


Acknowledgement sent to Holger Levsen <holger@layer-acht.org>:
Extra info received and forwarded to list. Copy sent to Laurent Bigonville <bigon@debian.org>. (Mon, 26 Sep 2022 13:27:04 GMT) (full text, mbox, link).


Message #27 received at 1017372@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>
To: Laurent Bigonville <bigon@debian.org>, 1017372@bugs.debian.org
Subject: Re: Bug#1017372: #1017372 plymouth: reproducible builds: year and week embedded in .pc files
Date: Mon, 26 Sep 2022 13:24:39 +0000
[Message part 1 (text/plain, inline)]
Hi Laurent, 

many thanks for uploading fix plymouth! 
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/plymouth.html
looks good now!

On Sun, Sep 25, 2022 at 10:04:40AM +0200, Laurent Bigonville wrote:
> Thanks for the patch.

Actually it was Vagrant's patch, I've just repeated it to make things easier and
more obvious.
 
> I've modified the command line to 'dpkg-parsechangelog --show-field Version
> | sed -e 's/-[^-]*$//' |  sed -e 's/^[0-9]*://'' to drop the epoch and
> debian revision from the version, and only keep the upstream one. (inspired
> from /usr/share/dpkg/pkg-info.mk)

cool!

> I also opened a bug upstream:
> https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/188

very cool!


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

The way we build software is at an inflection point. Development itself is 
moving to the cloud. AI is revolutionizing the way we code. Software security 
is global security. Open source permeates nearly every product – digital or 
physical. 
https://github.blog/2021-11-03-thank-you-github/ - Nat Friedman
[signature.asc (application/pgp-signature, inline)]

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 28 Oct 2022 07:28:02 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Jan 31 07:52:21 2025; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU General Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.