Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin, category/product listing, metatags on: change icon colour from yellow to green #6728

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

torvista
Copy link
Member

@torvista torvista commented Sep 4, 2024

Yellow implies warning to me.

before
2024-09-04 20_12_26-Admin Category Product Listing — Mozilla Firefox

after
2024-09-04 20_14_38-Admin Category Product Listing — Mozilla Firefox

@drbyte
Copy link
Member

drbyte commented Sep 4, 2024

Perhaps changing the background instead would provide more contrast?

@torvista
Copy link
Member Author

torvista commented Sep 4, 2024

The green is the same as the Enabled icon, and my thinking is that the green should not stand out, as green means "done"...not demanding attention.
Similarly I considered perhaps no-tags-defined should be red and some-tags-defined should be yellow, but that could be argued more as not all products may need tags at all, so I concluded to white as a neutral and green as something done, but certainly not yellow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants