Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Zed to objc2 #22408

Open
1 task done
osiewicz opened this issue Dec 25, 2024 · 1 comment
Open
1 task done

Migrate Zed to objc2 #22408

osiewicz opened this issue Dec 25, 2024 · 1 comment
Labels
admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue

Comments

@osiewicz
Copy link
Contributor

osiewicz commented Dec 25, 2024

Check for existing issues

  • Completed

Describe the feature

It seems like the ecoystem is moving towards using objc2 instead of objc as the latter is unmaintained. Doing so would probably allow us to drop media crate altogether (plus it'd be a win in terms of interacting with Mac platform code). It also seems like the latest version of Blade (0.6.0) is using objc2 as well (though we're not using that for our Mac build I think?)
Related: #17467

Zed Version and System Specs

Zed: v0.168.0 (Zed Nightly 564936e)
OS: macOS 15.1.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@osiewicz osiewicz added enhancement [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 25, 2024
@kvark
Copy link
Contributor

kvark commented Dec 25, 2024

I've recently completed moving Blade to objc2, since it was blocking my blade-graphics-0.6 release. Seems to be working well: there are zero instances of msg_send! left in code now!

Might be worth reconsidering for Zed to just switch to Blade on macOS and drop the metal-rs based graphics backend, to save time instead of porting it. I realize that it may require a few changes in the presentation, related to how it may need to be done in CoreAnimation transaction in some cases but not the others. Happy to help get them in!

The Zed on Blade Metal path is currently available via "gpui/macos-blade" feature, and the latest Blade uprev is coming in #22409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue
Projects
None yet
Development

No branches or pull requests

2 participants