Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signals for observations with grouped counts #489

Open
pstammler opened this issue Dec 6, 2024 · 1 comment
Open

Signals for observations with grouped counts #489

pstammler opened this issue Dec 6, 2024 · 1 comment
Assignees
@sguillot @lmauviard @pstammler
Labels
enhancement New feature or request

Comments

@pstammler
Copy link
Collaborator

Now we can load information from the PHA data and the ARF/RMF/RSP instrument fits files for the signals, but some optional features inside the Data, Instrument and/or Signal classes would be needed for observations with grouped data.
@pstammler pstammler added the enhancement New feature or request label Dec 6, 2024
pstammler added a commit that referenced this issue Dec 18, 2024
@pstammler
Grouping and quality from observations (#489)
365eb03 
New features are implemented in the data, instrument and signals classes, so they can load spectra with removed bad bins and grouped counts.
@sguillot
Copy link
Contributor

I suggest removing this issue from the Sprint Board, so that v3 can be released.

The PR will have to be extensively tested before merging, so it could be part of a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sguillot sguillot

@lmauviard lmauviard

@pstammler pstammler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sguillot @lmauviard @pstammler