You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the likelihood estimator (likelihood.check) with Everywhere and time_invariant=True, different executions give different values of likelihood, either close to llzero or close to the true value of -1.8e3. Doing the exact same thing with time_invariant=False always gives the correct value.
The text was updated successfully, but these errors were encountered:
thjsal
changed the title
Possible bug in Likelihood of Photosphere Everwhere with time_invariant=True
Possible bug in Likelihood of Photosphere Everywhere with time_invariant=True
Nov 29, 2024
It seems to come from the default_background_marginalisation.pyx https://github.com/xpsi-group/xpsi/blob/db1a05795d1e30ab4eb55ca3baa535b5a1266e16/xpsi/likelihoods/default_background_marginalisation.pyx#L397C1-L403C42
The function gsl_interp_eval_integ seems to sometimes be giving huge values that then get added to STAR, leading to a likelihood evaluation that is wrong.
One workaround would be to put a condition of len(phases)>2 to compute that function, and to just assign the component value if not ( STAR[i,j] = components[i][j] ), to deal with Everywhere and time_invariant=True where there is only one phase bin. But then using time_invariant = False leads to an error and needs to be solved
When running the likelihood estimator (likelihood.check) with
Everywhere
and time_invariant=True, different executions give different values of likelihood, either close to llzero or close to the true value of -1.8e3. Doing the exact same thing with time_invariant=False always gives the correct value.The text was updated successfully, but these errors were encountered: