ci: indent and branch #2883
Merged
ci: indent and branch #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pinia-official canceled.
|
posva
reviewed
Jan 10, 2025
packages/pinia/src/storeToRefs.ts
Outdated
| @@ -120,6 +120,6 @@ export function storeToRefs<SS extends StoreGeneric>( | |||
| } | |||
| } | |||
|
|
|||
| return refs | |||
| return { ...store.actions, ...refs } | |||
There was a problem hiding this comment.
I know I know. This is just an example for the debate @posva . This is what I mentioned it would be an idea to change.
posva
reviewed
Jan 10, 2025
| @@ -6,7 +6,7 @@ on: | |||
| - 'packages/docs/**' | |||
| - 'packages/playground/**' | |||
| pull_request: | |||
| branches: v2 | |||
| branches: [v2] | |||
There was a problem hiding this comment.
This branch key is an Array. If defined in one line the Array structure should be provided.
There was a problem hiding this comment.
Are you sure? It seems to work just fine
posva
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
#2506
Description
storeToRefsmethodThis pull request includes several changes to configuration and code files, focusing on workflow updates and a modification to the
storeToRefsfunction in thepiniapackage.Workflow configuration updates:
.github/workflows/ci.yml: Updated thepull_requestbranches configuration to use an array format..github/workflows/pkg.pr.new.yml: Updated thepull_requestbranches configuration to use an array format.Code modification:
packages/pinia/src/storeToRefs.ts: Modified thestoreToRefsfunction to return an object that includes bothstore.actionsandrefs.