-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(gcp_chronicle sink): add support for all Google SecOps regional endpoints #22033
base: master
Are you sure you want to change the base?
Conversation
…endpoints in the chronicle unstructured log sink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChocPanda
We can add a scope for this sink here: https://github.com/vectordotdev/vector/blob/master/.github/workflows/semantic.yml#L31 |
updated @pront , there's a GCP Chronicle semantic in there already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChocPanda !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to run cargo fmt
when you get a moment.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Testing was limited as I don't have access to a chronicle instance outside of europe, however, the risk is minimal as this change just adds Google published endpoints to the available configuration options
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References
https://cloud.google.com/chronicle/docs/reference/ingestion-api#regional_endpoints