Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update Template CI" workflow succeeds on push failure #979

Open
gtbuchanan opened this issue Jul 3, 2024 · 0 comments
Open

"Update Template CI" workflow succeeds on push failure #979

gtbuchanan opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gtbuchanan
Copy link

Describe the bug
The "Update Template CI" workflow appears successful even when a repository rule prevents writing the update to the repository.

A few months ago I converted all of our repositories to use org-level rulesets, but this overrode our Upptime repository exception for our bot user to commit to the master branch. I did not notice this until months later when the "Uptime CI" workflow started failing due to a Node version conflict. After further investigation, I saw that the Node issue had been resolved in the latest release but the "Update Template CI" workflow had been failing.

I imagine the "Uptime CI" and other workflows have a similar issue since none of them failed to push in the months since I broke things.

To Reproduce

  1. Setup Upptime
  2. Set GH_PAT to a token that has the appropriate access
  3. Enable a branch rule on master that requires pull requests
  4. Run "Update Template CI"

Expected behavior
The workflow should fail with an error rather than succeed.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Brave
  • Version: 1.67.123

Additional context
N/A

@gtbuchanan gtbuchanan added the bug Something isn't working label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants