Skip to content

Commit

Permalink
Skip broken test_pantsd_memory_usage for python2. (pantsbuild#7765)
Browse files Browse the repository at this point in the history
As discussed in pantsbuild#7761, although the issue is real, we'll be ditching
the python2 runtime shortly; so skip the test for python2.

Fixes pantsbuild#7761
  • Loading branch information
jsirois authored May 19, 2019
1 parent 13f4baf commit 8d82e4b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/python/pants_test/pantsd/test_pantsd_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 9,7 @@
import os
import re
import signal
import sys
import threading
import time
import unittest
Expand Down Expand Up @@ -400,6 401,9 @@ def test_pantsd_pid_change(self):
# Remove the pidfile so that the teardown script doesn't try to kill process 9.
os.unlink(pidpath)

@unittest.skipIf(sys.version_info[0] == 2,
reason='Increases by ~0.52 under python 2 as described in '
'https://github.com/pantsbuild/pants/issues/7761.')
def test_pantsd_memory_usage(self):
"""Validates that after N runs, memory usage has increased by no more than X percent."""
number_of_runs = 10
Expand Down

0 comments on commit 8d82e4b

Please sign in to comment.