Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table aws_resource_explorer_resource #2351

Open
WSMathias opened this issue Dec 8, 2024 · 2 comments
Open

Add table aws_resource_explorer_resource #2351

WSMathias opened this issue Dec 8, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We are asking the community to submit a PR to resolve this issue new table New table request

Comments

@WSMathias
Copy link

WSMathias commented Dec 8, 2024 •
edited
Loading

References
Currently, the available table aws_resource_explorer_search uses the Search API with maximum results capped at 1000 only.

  • aws resource-explorer-2 search

AWS resource explorer has added a new ListResources API that lists all the results without any cap.

  • aws resource-explorer-2 list-resources
@WSMathias WSMathias added enhancement New feature or request new table New table request labels Dec 8, 2024
@ParthaI ParthaI added help wanted We are asking the community to submit a PR to resolve this issue good first issue Good for newcomers labels Dec 17, 2024
@ParthaI
Copy link
Contributor

ParthaI commented Dec 17, 2024

Hey @WSMathias , thanks for opening this request!

Based on the API details you sent over, I believe adding these tables should be fairly straightforward, with a note that adding in optional key qualifiers would be important, as there could be many findings and/or filters in a region.

If anyone is interested in trying to add these tables, we always appreciate any contributions to the plugin! For more information on our coding and documentation standards, please have a look at Table and Column Standards and Table Documentation Standards. If you have any questions about the development process otherwise, please let us know!

@ParthaI
Copy link
Contributor

ParthaI commented Dec 18, 2024

In our Steampipe AWS plugin, we currently use the Go package github.com/aws/aws-sdk-go-v2/service/resourceexplorer2 at version v1.10.5.

The ListResources API was introduced in version v1.14.0.

To use this feature, we must update the AWS SDK V2 package from version v1.27.0 to v1.31.0. This update is a breaking change, and the AWS SDK V2 package must be upgraded to the latest version before we can add this table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We are asking the community to submit a PR to resolve this issue new table New table request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WSMathias @ParthaI