Trino C# .NET Client #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Great stuff. Can you please squash the commits and reword the commit message to follow https://trino.io/development/process#pull-request-and-commit-guidelines-
Potentially also add some of the description in the PR to the commit message body, add that this is donated by Microsoft, and add any applicable other authors as Co-authored-by: ..
Once that is done we should merge and then iterate in follow up work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A streaming C# Trino client library with ADO.NET interfaces.
These are the libraries that make up the client:
Note
.NET standard 2.0 provides compatibility with .NET Framework 4.7.2 which is widely used.