Fix naming conflicts and tags #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! this fixes it all. |
dgiunta
added a commit
to dgiunta/tpm
that referenced
this pull request
Jun 11, 2024
… syntax fixes for mac
RossBarnie
suggested changes
Jun 17, 2024
| cd "$(tpm_path)" && | ||
| GIT_TERMINAL_PROMPT=0 git clone -b "$branch" --single-branch --recursive "$plugin" >/dev/null 2>&1 | ||
| GIT_TERMINAL_PROMPT=0 git clone $branch --single-branch --recursive "https://git::@github.com/$plugin" $plugin >/dev/null 2>&1 |
There was a problem hiding this comment.
I may be misreading this but does this not break the case where the plugin URL is intended to use SSH? i.e. [email protected]:user/plugin, and [email protected]:user/plugin, effectively removing SSH support for non-GitHub sources?
| @@ -82,10 82,11 @@ tpm_plugins_list_helper() { | |||
| # 2. "user/plugin_name" | |||
| plugin_name_helper() { | |||
| local plugin="$1" | |||
| # get only the part after the last slash, e.g. "plugin_name.git" | |||
| local plugin_basename="$(basename "$plugin")" | |||
| # get only the last part | |||
There was a problem hiding this comment.
nit: This comment provides less context than the original, I think remove it, since the comment for the function is doing the same job.
|
Is there any plans on merging this PR?. |
|
@ch3st3r08 There's very little activity in this repo these days so don't expect it to be merged any time soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix:
TPM should account for the repository's author to prevent naming conflicts #273
using
.tmux/plugins/<user>/<repo>plugin's dir structureAdd functionality to install a certain tag/version number #87
nothing done here, instead of #branch you can use #tag
when updating plugins with #branch were not showing