Allow customization of cell attributes #105
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a new constructor argument to
HeadlessCircuit
that allows customization of attributes for specific cells. These attributes extend or overwrite the attributes that are set by default for the various models.As an example, the below code would make the fill color for all
And
gates light green:A current limitation of this feature is that it relies on the types as passed to the JointJS cells, which makes it more difficult to specify the attributes for specific Yosys prims (e.g.
And
instead of$and
). It would be possible to split off the current lookup table used ingetCellType
, but another solution (which I would prefer) is to convert the current.define('type', ...)
structures into proper class inheritance, similar to what the tutorial does here. That would allow users to get the type usinggetCellType(...).type
, and even allow getting rid of that lookup table altogether by making the Yosys primitive a static field on the models.Let me know what you think 🙂