Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SocketIO #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update SocketIO #6

wants to merge 4 commits into from

Conversation

lofcz
Copy link

@lofcz lofcz commented Jan 9, 2023 •
edited
Loading

This PR updates included SocketIO code to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f.

This comes with three benefits:

  1. should something happen during the connection phase, we now time-out eventually instead of hanging forever (cancellation tokens are passed around and requests to cancel checked in while loops)
  2. allocations significantly reduced
  3. fixes for various bugs in the library, see their changelog.

The only front-facing change is EIO changed to Enum from int, which is reflected in BridgeConnector.
I've tested SampleApp against this branch and it works.

Edit 1: updated to 8d5d25c51ac6257f4bcbe8cf0c67d097ecb2861f

@theolivenbaum
Copy link
Owner

Hi @lofcz thanks for the changes! I started reviewing them here - but I'll need to do some more testing before merging. One issue I found was when starting the sample app using the await Electron.Experimental.StartElectronForDevelopment(webPort); mode, it failed to exit in a reconnecting loop. Maybe if you've some time to check that, otherwise I'll take a look as soon as I've some time again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lofcz @theolivenbaum