Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: MPRIS integration enabled by default #2648

Open
3 of 5 tasks
ungive opened this issue Nov 27, 2024 · 3 comments
Open
3 of 5 tasks

[Feature Request]: MPRIS integration enabled by default #2648

ungive opened this issue Nov 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ungive
Copy link

ungive commented Nov 27, 2024

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.6.2

Checklists

What operating system are you using?

Ubuntu

Operating System Version

Ubuntu 24.04.1 LTS

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Stop the Youtube Music app
  2. Delete ~/.config/YouTube Music
  3. Start the app again
  4. Play a song and observe it only reporting basic metadata

Expected Behavior

$ playerctl -l metadata lists a media player that clearly identifies itself as YouTube Music. The player reports e.g. the xesam:url field when checking its metadata with playerctl metadata to know what URL the song is being played from.

Actual Behavior

$ playerctl -l metadata reports a temporary name chromium.instance650197 which cannot be identified as YouTube Music. playerctl -p chromium.instance650197 metadata does not report any xesam:url field.

$ playerctl -l metadata
chromium.instance650197
$ playerctl -p chromium.instance650197 metadata 
chromium mpris:artUrl              file:///tmp/.org.chromium.Chromium.KHpXUw
chromium mpris:length              391000000
chromium mpris:trackid             '/org/chromium/MediaPlayer2/TrackList/Track113F0C72D4C4DE24FC71139C54580A29'
chromium xesam:album               Legacy
chromium xesam:artist              Eagles
chromium xesam:title               Hotel California

Enabled plugins

  1. The default plugins

Additional Information

Enabling the "Shortcuts (MPRIS)" plugin resolves this issue.

$ playerctl -l metadata
YoutubeMusic
$ playerctl -p YoutubeMusic metadata 
YoutubeMusic mpris:length              391000000
YoutubeMusic mpris:artUrl              https://lh3.googleusercontent.com/s8QFRo91FYOkY2M1967AtulxiQpHXC7pEjWtsGzCQ4ZN25wnvhasHO0S4e_MWm04-HVfmBRvy8jmbq2-ZA=w544-h544-l90-rj
YoutubeMusic xesam:title               Hotel California
YoutubeMusic xesam:url                 https://music.youtube.com/watch?v=BciS5krYL80
YoutubeMusic xesam:artist              Eagles
YoutubeMusic mpris:trackid             '/org/node/mediaplayer/YoutubeMusic/Track/BciS5krYL80'
YoutubeMusic xesam:album               Legacy

This plugin should be enabled by default on Linux.

If this plugin is enabled by default it will allow this YouTube Music app to work with Music Presence out of the box: https://musicpresence.app / https://github.com/ungive/discord-music-presence

I don't really see any reason why this plugin shouldn't be enabled by default.

@ArjixWasTaken
Copy link
Contributor

Honestly, I do agree with you, it makes a lot of sense for it to be enabled by default.
But that would lead to linux users having a different OOB experience from windows users.

Maybe introducing a first-time-setup screen would be for the best?
We could solve a lot of confusion for many other things if we add a first-time-setup screen.

@ungive
Copy link
Author

ungive commented Nov 27, 2024

But that would lead to linux users having a different OOB experience from windows users.

How so? I don't see how enabling MPRIS by default affects the Windows version of the app, since MPRIS is Linux only

@ArjixWasTaken
Copy link
Contributor

ArjixWasTaken commented Nov 27, 2024

taskbar media control is not enabled by default on windows...
(similar plugin)

@JellyBrick JellyBrick added the enhancement New feature or request label Dec 6, 2024
@JellyBrick JellyBrick changed the title [Bug]: Proper MPRIS integration not enabled by default [Feature Request]: MPRIS integration enabled by default Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants