Add a client to Fido which can discover the synoptic AIA series #7841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be tricky but can you undo all of the code formatting changes? There have been discussions around auto formatting the code but they have not been accepted yet |
|
Sorry about that! Of course I set up the formatter to run on save, so I"m not always seeing what changes it makes. How do you think I should go about it? Are there standard approaches? Is there a style guide that I can revert it to? I have a few ideas of what I could do. |
|
Err, honestly I don"t know what would be best. It might be simplest to just start again from a clean branch and add just the new client and attr code. |
|
Replaced by #7842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses Issue #7828 by adding a new client into the dataretriever module
Some discussion should be had regarding the best way to call for this Series since it isn"t managed by JSOC in the usual way. For the moment if a.Instrument is either "AIA" or "AIASynoptic" the client will be called. a.Resolution == "Synoptic" will also trigger alongside a.Instrument == "AIA". That said, I"m not sure the average user would like to have to start specifying a resolution like that in order to not be served with this series, so I"m thinking the unique instrument might be the way to go.