fix: docker section is shown always in rootless mode #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker has rootless mode, where 'docker context ls' command returns besides 'default' entry also 'rootless' entry, which leads to docker prompt section is shown always, to prevent this behavior it need to be filtered out like the 'default' entry
denysdovhan
approved these changes
Nov 6, 2024
|
hello all, I'm not sure if I need to do something, or someone other has to trigger the pipeline again, please advise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docker has rootless mode, where 'docker context ls' command returns besides 'default' entry also 'rootless' entry:
this leads to docker prompt section is shown always,
to prevent this behavior it need to be filtered out like the 'default' entry
a similar fix was already applied in #1025 for macOS specific docker context, or this PR #1376