You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One reason to keep it: Cosign, by default would create an ephemeral key for signing, if the user does not specify a KMS (with an existing stored key) to use. Although it may not be popular to have ephemeral keys with a KMS, I don't think it's invalid.
One detail, Cosign does not create ephemeral keys backed by KMS. Cosign either generates an ephemeral, in-memory key, or uses a provided key either in KMS, an HSM or on-disk.
The only place Cosign uses CreateKey is with cosign generate-key-pair, if a KMS resource is provided. Since it's a limited use case, removing CreateKey would likely have no impact. I might also argue that Cosign shouldn't support generating a key pair at all - either Cosign uses an ephemeral key, or you provide your own key.
Description
re: #1901 (review)
We should consider disabling the
SignerVerifier.CreateKey()
method for KMSs, since there may be no extra security benefit for the user.The text was updated successfully, but these errors were encountered: