-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aryan@07 #2372
base: master
Are you sure you want to change the base?
aryan@07 #2372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future: Aim for each pull request to address a single change. For instance, if you need to improve tests and correct a mistake in README.md
, it's better to submit two separate pull requests:
- One for updating the test files.
- Another for correcting the
docs/README.md
file.
Additionally, please use meaningful titles for your pull requests instead of placeholder text like aryan@07
. Descriptive titles will help understand the purpose of the PR at a glance.
Also, a minor suggestion: Instead of pulling from the
master
/main
branch, create a new branch for each pull request. This helps avoid accidentally adding extra commits to existing pull requests.
<br> | ||
<span>Hunt down social media accounts by username across <a href="https://sherlockproject.xyz/sites">400 social networks</a></span> | ||
<br> | ||
</p> | ||
</p>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quote definitely should not be here, I believe you should consider removing it
@@ -1,10 1,10 @@ | |||
<p align=center> | |||
<br> | |||
<a href="https://sherlock-project.github.io/" target="_blank"><img src="images/sherlock-logo.png"/></a> | |||
<a href="https://sherlock-project.github.io/" target="_blank"><img src="https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRc-5ujSNENxW3xta7D0DSnmCZeb_eCp5_ASgQiNBIIuGkuZ0B9axO8hoQF2SCzPTroQcM&usqp=CAU"/></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely clear on why you replaced the file path with a Google CDN URL, especially since it links to an outdated Sherlock logo, - it would be better to use the newer logo version instead.
I want to commit this change to this code