Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

What happens if repository has a remote under different name? #74

Open
schultyy opened this issue Mar 29, 2016 · 4 comments
Open

What happens if repository has a remote under different name? #74

schultyy opened this issue Mar 29, 2016 · 4 comments

Comments

@schultyy
Copy link
Member

Right now we check for the remote origin. But in case the remote has a different name it's not possible to run semantic-rs right now.
There should be a mechanism in place that allows users to run semantic-rs with a different remote than origin.

@schultyy
Copy link
Member Author

schultyy commented Apr 2, 2016

EDIT: with #80 being merged it's possible to run semantic-rs but it does not push any changes and also does not create a release on GitHub.

I gave that issue some thought and my proposal here is to have a configuration file in place which denotes the remote to be used. The other option would be to ask the user but since the user is probably going to run semantic-rs multiple times they probably don't want to name the remote every time again.

@schultyy
Copy link
Member Author

Also asking the user doens't make a lot of sense when semantic-rs is run on a CI server.

@schultyy
Copy link
Member Author

schultyy commented Aug 24, 2016

So we could search for a .semantic-rs.toml in the project directory and extract the remote's name from there.

remote="production"

TODO for this one:

  • Look for a .semantic-rs.toml config file
  • Extract the remote value if present and use it
  • Document it in README.md

UPDATE:

Updated to toml as suggested by @badboy.

@badboy
Copy link
Member

badboy commented Aug 26, 2016

Why json? It's hard to write for a human. TOML is pretty much the go-to format in the Rust world and far easier to write.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants