Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microkit: remove const qualifiers from domain variables #1308

Open
wants to merge 1 commit into
base: microkit
Choose a base branch
from

Conversation

JE-Archer
Copy link
Member

This PR removes the const qualifiers from domain variables. This will allow the Microkit tool to patch the kernel's domain schedule. See #1301 for more information.

@lsf37
Copy link
Member

lsf37 commented Aug 14, 2024

Since this will make simulation and hardware tests fail, could you make corresponding PR in sel4test (which we won't merge) that removes the const qualifier from the test schedule there?

With that, we can use Test with to make sure that the microkit branch keeps passing sel4test.

@axel-h
Copy link
Member

axel-h commented Aug 14, 2024

I wonder if const volatile is what to use them. These are still runtime constants, right?

@lsf37
Copy link
Member

lsf37 commented Aug 14, 2024

I wonder if const volatile is what to use them. These are still runtime constants, right?

They are still runtime constants, yes

@JE-Archer
Copy link
Member Author

Since this will make simulation and hardware tests fail, could you make corresponding PR in sel4test (which we won't merge) that removes the const qualifier from the test schedule there?

With that, we can use Test with to make sure that the microkit branch keeps passing sel4test.

I've done this (see seL4/sel4test#126). How would I go about changing which seL4test branch this PR is tested with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants