Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New assert occurs with v9.34 when instantiating an Omega_h::Library #375

Open
tristan0x opened this issue Oct 20, 2021 · 1 comment
Open

New assert occurs with v9.34 when instantiating an Omega_h::Library #375

tristan0x opened this issue Oct 20, 2021 · 1 comment

Comments

@tristan0x
Copy link
Contributor

I am surprised to notice this change that now expects argc and argv to not be nullptr:

omega_h/src/Omega_h_library.cpp

Lines 70 to 74 in 140c951

OMEGA_H_CHECK(argc != nullptr);
OMEGA_H_CHECK(argv != nullptr);
for (int ic = 0; ic < *argc; ic ) {
argv_.push_back((*argv)[ic]);
}

... since Library provides a default constructor:

omega_h/src/Omega_h_library.hpp

Line 13 in 140c951

inline Library() : Library(nullptr, nullptr) {}

Blue Brain Project doesn't mind updating its usage to now passes argc and argv, but maybe introduce 2 breaking changes in Library API:

  1. remove the Library default constructor
  2. expect argc and argv to be rvalue, not pointers.
@ibaned
Copy link
Collaborator

ibaned commented May 2, 2022

@tristan0x my bad, it looks like I allowed in some changes that I shouldn't have. I will remove those asserts in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tristan0x @ibaned