Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure default values globally #30

Open
salu133445 opened this issue Dec 25, 2020 · 1 comment
Open

Allow to configure default values globally #30

salu133445 opened this issue Dec 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@salu133445
Copy link
Owner

Currently, setting muspy.DEFAULT_VELOCITY = 100 does not affect muspy.classes.DEFAULT_VELOCITY (still 64). As a result, a newly-created Note(time=0, pitch=60, duration=1) still has a default velocity of 64. We should find a better way to configure these default values globally. One possible way is to store the configuration in a dictionary and provide a function for the users to modify these default values at runtime, pretty much like matplotlib.rcParams (the dictionary) and matplotlib.rc (the function).
@salu133445 salu133445 added enhancement New feature or request good first issue Good for newcomers labels Dec 25, 2020
@cifkao
Copy link
Contributor

cifkao commented Dec 25, 2020

And matplotlib.rc_context, the context manager.

@salu133445 salu133445 removed the good first issue Good for newcomers label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cifkao @salu133445