Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPL-27 Performance issues using service now plugin #9510

Conversation

Jesus-Osuna-M
Copy link
Contributor

@Jesus-Osuna-M Jesus-Osuna-M commented Dec 20, 2024

Before submitting this PR:

  • Jira ticket is present in the title or in the description
  • All items marked FILL IN are filled
  • Any required labels are applied (Bug bash, exclude release notes, backport, etc.)
  • Testing/reviewer instructions are filled out

About this change:

Jira Ticket: https://pagerduty.atlassian.net/browse/RPL-27

Purpose of the Changes:

Improve the ServiceNow plugin to prevent excessive delays when loading the list of groups from ServiceNow. Avoid unnecessary API calls to Snow when the information is not required.

Customer Impact:
Significantly reduces the time it takes to load the list of groups from ServiceNow, enhancing productivity and eliminating unnecessary delays.

Improves user satisfaction by providing a smoother and faster integration between Rundeck and ServiceNow.

Release Notes:

Kind of Change

  • Bug Fix
  • Enhancement/New Feature/Behavior
  • Maintenance
  • Backport (Other sections can be skipped)
  • Other... (FILL IN)

Development Checklist

  • Unit Tests added for modified/added code
  • Documentation PR:
  • Documentation Not needed

Specific Considerations:

  • Feature Flag required (New behavior), name:
    • The new behavior is OFF by default (flag is false by default)
  • API Functional Tests added (API Changes)
  • API Version Increment needed (implies Documentation needed)

GUI Changes:

  • No GUI Changes, OR
  • Selenium UI Tests added

Testing:

Start a Rundeck instance.
Configure the ServiceNow plugin at the project level.
Create a job.
Add a notification to create an incident in ServiceNow.
Previously, loading the groups took 6–8 seconds. This time should now be significantly reduced.

ServiceNow Instance:
https://pagerduty.atlassian.net/browse/RPL-27?focusedCommentId=795301

Acceptance Criteria:

The ServiceNow plugin should function correctly when:

  • Creating Snow notifications
  • Modifying Snow incidents
  • Snow plugin should be able to create notification
  • Snow plugin should be able to execute workflow step

QA/Bug Bash Needed?

  • manual-qa/bug-bash Label is applied, OR
    • Not needed

Manual QA Notes:

Reviewer Checklist

Functionality (choose one):

  • I built and tested locally and code behaves as expected: OR
    • I tested via via Docker image, OR
    • It was not necessary, reason:

Code:

  • Meets quality and style guidelines
    • Has complete Unit tests
    • Has complete Functional Tests

@Jesus-Osuna-M Jesus-Osuna-M force-pushed the RPL-27-performance-issues-using-service-now-plugin-project-configuration branch 3 times, most recently from 30eb6e3 to a075578 Compare December 23, 2024 15:21
@Jesus-Osuna-M Jesus-Osuna-M marked this pull request as ready for review December 23, 2024 15:41
@Jesus-Osuna-M Jesus-Osuna-M added this to the 5.9.0 milestone Dec 23, 2024
@Jesus-Osuna-M Jesus-Osuna-M force-pushed the RPL-27-performance-issues-using-service-now-plugin-project-configuration branch from a075578 to c8bfef3 Compare January 3, 2025 17:24
@ronaveva ronaveva self-requested a review January 6, 2025 18:59
Copy link
Contributor

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jesus-Osuna-M Jesus-Osuna-M merged commit 6ba1dc6 into main Jan 10, 2025
3 checks passed
@Jesus-Osuna-M Jesus-Osuna-M deleted the RPL-27-performance-issues-using-service-now-plugin-project-configuration branch January 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants