Move skill_onskillusage from skill_attack to skill_castend #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstumpf
added
component:core
aleos89
approved these changes
Apr 24, 2024
datawulf
reviewed
Apr 28, 2024
src/map/skill.cpp
Outdated
| @@ -7181,7 7179,7 @@ int skill_castend_damage_id (struct block_list* src, struct block_list *bl, uint | |||
| {// consume arrow on last invocation to this skill. | |||
| battle_consume_ammo(sd, skill_id, skill_lv); | |||
| } | |||
|
|
|||
| skill_onskillusage(sd,bl,skill_id,skill_lv); | |||
There was a problem hiding this comment.
shouldn't this be skill_onskillusage(sd, bl, skill_id, tick); ?
Lemongrass3110
approved these changes
May 2, 2024
src/map/skill.cpp
Outdated
| @@ -7181,7 7179,7 @@ int skill_castend_damage_id (struct block_list* src, struct block_list *bl, uint | |||
| {// consume arrow on last invocation to this skill. | |||
| battle_consume_ammo(sd, skill_id, skill_lv); | |||
| } | |||
|
|
|||
| skill_onskillusage(sd,bl,skill_id,skill_lv); | |||
Badarosk0
reviewed
May 10, 2024
| @@ -4138,8 4138,6 @@ int64 skill_attack (int attack_type, struct block_list* src, struct block_list * | |||
| } | |||
| break; | |||
| } | |||
| if( sd ) | |||
| skill_onskillusage(sd, bl, skill_id, tick); | |||
There was a problem hiding this comment.
This solves the problem, but seems to generate another one.
This bonus has stopped working:
bonus4 bAutoSpellOnSkill,"RK_DRAGONBREATH_WATER","NPC_ACIDBREATH",getskilllv("RK_DRAGONBREATH_WATER"),1000;
bonus4 bAutoSpellOnSkill,"RK_DRAGONBREATH","NPC_THUNDERBREATH",getskilllv("RK_DRAGONBREATH"),1000;
Probably a skill calling another skill of a different type fails?
I need this modification to work.
Nicapone1
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8256