Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Windows vSphere Node Driver Nodes Improperly Handle Multiple Agent Env Vars #48499

Open
HarrisonWAffel opened this issue Dec 18, 2024 · 0 comments
Assignees
Labels
feature/windows internal kind/bug Issues that are defects reported by users or that we know have reached a real release
Milestone

Comments

@HarrisonWAffel
Copy link
Contributor

Rancher Server Setup

  • Rancher version: main
  • Installation option (Docker install/Helm Chart):
    • If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):
  • Proxy/Cert Details:

Information about the Cluster

  • Kubernetes version: 1.30.2
  • Cluster Type (Local/Downstream):
    • If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

  • What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)
    • If custom, define the set of permissions:

Describe the bug
When provisioning a Windows cluster using the vSphere node driver, Rancher will improperly generate the rancher-wins install file if multiple agent environment variables are provided. All environment variables will be rendered onto a single line, resulting in invalid powershell syntax. This does not reproduce for custom clusters.

To Reproduce
Provision a vSphere cluster with a windows node while specifying multiple agent environment variables

Result
The rancher-wins install script has multiple environment variables set on a single line, and the node will not come up

Expected Result
Only one variable is added on each line, and the node connects to the cluster

Screenshots

Additional context
As a workaround, you can manually adjust the install.ps1 file to ensure each environment variable is on a single line, then run the script

This is due to a missing newline when generating the install file, here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/windows internal kind/bug Issues that are defects reported by users or that we know have reached a real release
Projects
None yet
Development

No branches or pull requests

2 participants