Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test output of Exporter #2060

Open
fsimonis opened this issue Jul 24, 2024 · 0 comments
Open

Test output of Exporter #2060

fsimonis opened this issue Jul 24, 2024 · 0 comments
Labels
good first issue Everybody is invited to help: students, users, externals, ...
Milestone

Comments

@fsimonis
Copy link
Member

Please describe the problem you are trying to solve.

Exporter tests only test if they don't fail while exporting.
This still leaves many open questions:

  • do all expected files exist?
  • have empty piece files been correctly skipped?
  • is their content correct?

Describe the solution you propose.

The first two could be as simple as deleting files before the test and checking for existing files afterwards.

The final one is more tricky. Checking the syntax of the XML-based formats should be easy, as preCICE already relies on libxml2.
Checking the semantics could be done using a XSD schema file, but VTK doesn't seem to provide one.
Checking the content should be easy for XML-based files, but will be hacky for legacy VTK.
Other files like the CSV and the series (JSON) files require additional dependencies, which may not be worth the hassle.

Additional context

Follow-up of #2055

@fsimonis fsimonis added this to the Version 3.x.x milestone Jul 24, 2024
@fsimonis fsimonis changed the title Test output Exporter Test output of Exporter Jul 24, 2024
@uekerman uekerman added the good first issue Everybody is invited to help: students, users, externals, ... label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everybody is invited to help: students, users, externals, ...
Projects
None yet
Development

No branches or pull requests

2 participants