Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/oauth2: require scope to be set on /authorize #4705

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

frankie567
Copy link
Member

No description provided.

@frankie567 frankie567 enabled auto-merge (rebase) December 20, 2024 07:51
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
polar ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:52am
polar-sandbox ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:52am

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 154.46 KB (🟡 1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_not-found/page 364 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/login/magic-link/request/page 363 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/verify-email/page 364 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/[organization]/(header)/subscriptions/page 364 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/dashboard/layout 363 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/docs/layout 364 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/(topbar)/(backer)/purchases/page 363 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/(landing)/(mdx)/layout 365 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/(landing)/(mdx)/careers/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/(mdx)/customers/purchases/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/(mdx)/countries/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/(mdx)/fees/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/(mdx)/merchant-of-record/compliance/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/(mdx)/payments-taxes/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/developers/guides/page 363 B 154.82 KB 44.23% ( /- <0.01%)
/(main)/docs/developers/open-source/page 33.59 KB 188.05 KB 53.73% ( /- <0.01%)
/(main)/docs/developers/sdk/polar-init/page 33.59 KB 188.05 KB 53.73% ( /- <0.01%)
/(main)/docs/developers/sdk/python/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/developers/sdk/github-actions/page 33.59 KB 188.05 KB 53.73% ( /- <0.01%)
/(main)/docs/developers/sdk/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/support/(mdx)/page 33.1 KB 187.56 KB 53.59% ( /- <0.01%)
/(main)/docs/support/(mdx)/faq/page 33.59 KB 188.05 KB 53.73% ( /- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see " /- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit d791dd1 into main Dec 20, 2024
11 checks passed
@frankie567 frankie567 deleted the fix/oauth2-authorize-no-scope branch December 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant